-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Untab the plugin users and plugin developers grids #593
Conversation
Hmm, I dunno about this one. That's my initial thought anyways--not a blocker, will sleep on it. |
Personally, I like untabbing because the information is already not so dense and it brings forward a strength of napari: how integrated being a plugin user and being a potential plugin developer can be. One other progression (that I think I see amongst many plugin developers) is advanced bioimage user (ie fiji/imagej, cellprofiler) -> desire to share resources with others -> see how easy that can be in napari -> become plugin developer almost before being a napari user. But, also ok if we don't change. |
There's no rush to do this right now. Let's get the docs build stable and we can noodle more on this. There are definitely pros/cons to untabbing. |
Hmmm...
and we have warnings as fails. Edit: No, that's not it, this run (which passed) has that line too: I dunno, I can't find it. We really need to fix the _status_bar spam, which I think is due to threading. |
@psobolewskiPhD Let me rebase and see if that solves it. |
a9c8017
to
a43fc08
Compare
The actual failure is this one:
|
This is a benign warning that doesn't fail the docs build. It comes from the fact that napoleon admits custom sections (which I defined for the Events section of the docstrings) but numpydoc doesn't like when it doesn't recognize a section 😅 Maybe that will change in the future, though. |
@melissawm 🎉 you've got hawk eyes! I was looking for "warning" and things like that, didn't expect "Error" to be the thing. |
I think this is a good compromise - segments the audience without hiding content. I like it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm convinced! looks solid!
References and relevant issues
Partially addresses #582
Description
This PR untabs the plugin landing page so a reader can quickly skim info for plugin users and plugin developers without having to click the tab.