Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Protect few possible access to window that may be triggered by callback #7565

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Jan 28, 2025

References and relevant issues

Hardening suggested in #7560 (comment)

Description

Protect few qt slots with check if qt object still exists

This is a temporary solution. We should move callbacks that require Qt into Qt object

@github-actions github-actions bot added the qt Relates to qt label Jan 28, 2025
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.85%. Comparing base (c81efa9) to head (ddc5857).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
napari/_qt/qt_main_window.py 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7565      +/-   ##
==========================================
- Coverage   92.88%   92.85%   -0.04%     
==========================================
  Files         630      630              
  Lines       59066    59071       +5     
==========================================
- Hits        54864    54849      -15     
- Misses       4202     4222      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Czaki Czaki added the maintenance PR with maintance changes, label Jan 28, 2025
@jni jni added the bugfix PR with bugfix label Jan 29, 2025
@jni jni added this to the 0.6.0 milestone Jan 29, 2025
@willingc willingc added the needs:core-review Needs core dev review label Feb 17, 2025
@psobolewskiPhD
Copy link
Member

@jni jni added ready to merge Last chance for comments! Will be merged in ~24h and removed needs:core-review Needs core dev review labels Feb 27, 2025
@jni jni merged commit c944373 into napari:main Feb 27, 2025
42 checks passed
@jni jni deleted the protect_status_bar branch February 27, 2025 01:43
@github-actions github-actions bot removed the ready to merge Last chance for comments! Will be merged in ~24h label Feb 27, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bugfix PR with bugfix maintenance PR with maintance changes, qt Relates to qt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants