Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix #2034, Update CodeQL workflow #2035

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

astrogeco
Copy link
Contributor

@astrogeco astrogeco commented Jan 21, 2022

Describe the contribution

Depends on nasa/cFS#413

Fixes #2034

  • Replace Checkout Action for bundle with git clone
  • Use symlink to map calling repo workspace to expected cFS Bundle
    directory location
  • Replace bundle checkout action with git clone
  • Adds component-path input parameter
  • Adds "code snippets" to CodeQL Analyze action

Testing performed

See PR checks Tab

Expected behavior changes

CodeQL Action executes successfully.

System(s) tested on

  • Github actions, Ubuntu 18.04

Additional context
None

Contributor Info - All information REQUIRED for consideration of pull request
Gerardo E. Cruz-Ortiz, NASA

@astrogeco astrogeco force-pushed the fix-codeql-workflow branch 3 times, most recently from 46eddc3 to b31f405 Compare January 21, 2022 18:17
@astrogeco astrogeco added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jan 21, 2022
@ArielSAdamsNASA
Copy link

I will approve once the commits are fixed so the only change is the codeql workflow yml file.

Instead of using astrogeco/cFS/.github/workflows/codeql-build.yml@fix-codeql-workflow, shouldn't it use the nasa/cFS codeql workflow?

@astrogeco astrogeco force-pushed the fix-codeql-workflow branch 2 times, most recently from 1d64681 to 6bdb77e Compare January 24, 2022 16:50
@astrogeco
Copy link
Contributor Author

astrogeco commented Jan 24, 2022

I will approve once the commits are fixed so the only change is the codeql workflow yml file.

Instead of using astrogeco/cFS/.github/workflows/codeql-build.yml@fix-codeql-workflow, shouldn't it use the nasa/cFS codeql workflow?

Good catch! I just rebased it to remove the extraneous commits. Once the CI passes I'll update the tag to the nasa one.

Can you look at nasa/cFS#413?

@astrogeco astrogeco force-pushed the fix-codeql-workflow branch 2 times, most recently from 4a3d05a to 7fbc58e Compare January 26, 2022 23:25
@astrogeco astrogeco marked this pull request as draft January 26, 2022 23:54
@astrogeco
Copy link
Contributor Author

Converted to draft until cFS-level PR is merged

@astrogeco astrogeco force-pushed the fix-codeql-workflow branch from 7fbc58e to 43de2bf Compare January 26, 2022 23:56
@astrogeco astrogeco removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jan 26, 2022
@astrogeco
Copy link
Contributor Author

CCB:2022-01-27 APPROVED

@astrogeco astrogeco added the CCB:Approved Indicates code review and approval by community CCB label Jan 27, 2022
- Add new parameters to match updated cFS-CodeQL workflow interface
introduced in nasa/cFS#413
- Add file-exclusion checks to Action trigger so workflow doesn't run if
only changes in commit or pull request are to documentation
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CCB:Approved Indicates code review and approval by community CCB continuous-integration dependency draco-rc1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeQL Workflow Fails after "upload" stage
3 participants