Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CodeQL Workflow Broken due to Name Change #1225

Closed
astrogeco opened this issue Feb 23, 2022 · 1 comment · Fixed by #1249 or #1251
Closed

CodeQL Workflow Broken due to Name Change #1225

astrogeco opened this issue Feb 23, 2022 · 1 comment · Fixed by #1249 or #1251
Labels
continuous-integration draco-rc2
Milestone
Draco

Comments

@astrogeco
Copy link
Contributor

astrogeco commented Feb 23, 2022 •
edited
Loading

Describe the bug

Merging nasa/cFS#413 broke the components' CodeQL workflow as expected.

Need to update the osal codeQL workflows to match the patterns implemented in nasa/cFE#2035

To Reproduce

See failed workflows

Expected behavior

Workflow executes

Code snips
None

System observed on:
GitHub Actions

Additional context
None

Reporter Info
Gerardo E. Cruz-Ortiz NASA
chillfig added a commit to chillfig/osal that referenced this issue Mar 11, 2022
@chillfig
Fix nasa#1225, Testing fix to codeql build
33b0261 
changes tests input to boolean, changes source input for uses
chillfig added a commit to chillfig/osal that referenced this issue Mar 11, 2022
@chillfig
Partial nasa#1225, Testing fix to codeql build
ca0d090 
changes tests input to boolean, changes source input for uses,
component-path to osal, changes to tests to test, removes makeprep input
@chillfig chillfig mentioned this issue Mar 11, 2022
Merged
chillfig added a commit to chillfig/osal that referenced this issue Mar 14, 2022
@chillfig
Fix nasa#1225, Update cFS-build CodeQL reusable worfklow target
158f5fa 
changes source input for uses, changes make-prep to prep,
adds component-paths
chillfig added a commit to chillfig/osal that referenced this issue Mar 16, 2022
@chillfig
Partial nasa#1225, Update cFS-build CodeQL reusable worfklow target
349ce0e 
changes tests input to boolean, changes source input for uses, adds new lines
component-path to osal, changes tests to test, removes makeprep input
chillfig added a commit to chillfig/osal that referenced this issue Mar 16, 2022
@chillfig
Partial nasa#1225, Update cFS-build CodeQL reusable worfklow target
a3065d9 
changes tests input to boolean, changes source input for uses, adds new lines
component-path to osal, changes tests to test, removes makeprep input
astrogeco added a commit that referenced this issue Mar 16, 2022
@astrogeco
Merge pull request #1230 from chillfig/codeql_workflow_fix
da2a61d 
Partial #1225, Update cFS-build CodeQL reusable worfklow target
@astrogeco astrogeco mentioned this issue Mar 16, 2022
Merged
@skliper
Copy link
Contributor

skliper commented Mar 28, 2022

@chillfig - not sure what happened here, but please work with @astrogeco on the process for merges. Reopening and we'll likely revert c4865bf

@skliper skliper reopened this Mar 28, 2022
@skliper skliper removed the bug label Apr 20, 2022
skliper added a commit to skliper/osal that referenced this issue Apr 20, 2022
@skliper
Fix nasa#1225, Update codeql workflows for reusable update
07395cd
skliper added a commit to skliper/osal that referenced this issue Apr 20, 2022
@skliper
Fix nasa#1225, Update codeql workflows for reusable update
fc3eee5
skliper added a commit to skliper/osal that referenced this issue Apr 20, 2022
@skliper
Fix nasa#1225, Update codeql workflows for reusable update
05e4817
@skliper skliper mentioned this issue Apr 20, 2022
Merged
2 tasks
astrogeco added a commit that referenced this issue May 2, 2022
@astrogeco
Merge pull request #1249 from skliper/fix1225-codeql_workflow
a0ec380 
Fix #1225, Update codeql workflows for reusable update
@astrogeco astrogeco mentioned this issue May 2, 2022
Merged
2 tasks
@skliper skliper added this to the Draco milestone Jul 20, 2022
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#1225 from jphickey/fix-1224-core-coverage-tests
fa10af7 
Fix nasa#1224, reinstate recipes for coverage test
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
continuous-integration draco-rc2
Projects
None yet
Milestone
Draco
2 participants
@skliper @astrogeco