Fix #235, add check against OS_MAX_QUEUE_DEPTH #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OS_QueueCreate() function will now sanity check the depth parameter against the configured OS_MAX_QUEUE_DEPTH value. If it is too large, an error will be returned. This is a hard limit and independent of the "permissive" mode. The OS_MAX_QUEUE_DEPTH should be configured to the largest value that an application may reasonably request.
skliper
approved these changes
May 7, 2020
skliper
added
enhancement
CCB:Ready
skliper
added
CCB-20200513
and removed
CCB:Ready
|
CCB 20200513 - Approved |
astrogeco
added
CCB:Approved
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
The
OS_QueueCreate()function will now sanity check the depth parameter against the configured OS_MAX_QUEUE_DEPTH value. If it is too large, an error will be returned. This is a hard limitand independent of the "permissive" mode.
The OS_MAX_QUEUE_DEPTH should be configured to the largest value that an application may reasonably request.
Fix #235
Testing performed
Confirm CFE framework starts and operates normally (but see nasa/to_lab#36)
Confirm OSAL unit tests pass
Expected behavior changes
OS_QueueCreate()will return an error code if the depth parameter is larger than the configuredOS_MAX_QUEUE_DEPTH.System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.