Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Hardcoded queue depth of 64 #36

Closed
jphickey opened this issue May 7, 2020 · 0 comments · Fixed by #37 or #39
Closed

Hardcoded queue depth of 64 #36

jphickey opened this issue May 7, 2020 · 0 comments · Fixed by #37 or #39
Labels
bug Something isn't working
Milestone
Bootes

Comments

@jphickey
Copy link
Contributor

jphickey commented May 7, 2020

Describe the bug
TO_LAB creates a queue depth of 64, which is beyond the limit of some queue implementations.

To Reproduce
Run TO_LAB on a system that does not allow a queue depth of 64.

Expected behavior
Should not hard code a large queue depth that could be beyond the implementation limit.

Code snips

to_lab/fsw/src/to_lab_app.c

Line 179 in 545710c

ToTlmPipeDepth = 64;

System observed on:
Ubuntu 20.04, after enabling max depth enforcement in OSAL.

Additional context
If the goal is to create a deep queue, then use OS_MAX_QUEUE_DEPTH.

Reporter Info
Joseph Hickey, Vantage Systems, Inc.
jphickey added a commit to jphickey/to_lab that referenced this issue May 7, 2020
@jphickey
Fix nasa#36, Use OS_MAX_QUEUE_DEPTH rather than 64.
aaa76d9 
This should configure the maximum depth supported by
OSAL, rather than a hard coded 64.
jphickey added a commit to jphickey/to_lab that referenced this issue May 7, 2020
@jphickey
Fix nasa#36, Use OS_MAX_QUEUE_DEPTH rather than 64.
1886aaa 
This should configure the maximum depth supported by
OSAL, rather than a hard coded 64.
@jphickey jphickey mentioned this issue May 7, 2020
Merged
jphickey added a commit to jphickey/to_lab that referenced this issue May 7, 2020
@jphickey
Fix nasa#36, Use OS_MAX_QUEUE_DEPTH rather than 64.
76a0d31 
This should configure the maximum depth supported by
OSAL, rather than a hard coded 64.

Moved both pipe depth configurations to a macro in the
header file.
@jphickey jphickey mentioned this issue May 7, 2020
Merged
@skliper skliper added the bug Something isn't working label May 7, 2020
@skliper skliper added this to the 2.4.0 milestone May 7, 2020
astrogeco added a commit that referenced this issue May 19, 2020
@astrogeco
Merge pull request #37 from jphickey/fix-36-queue-depth
d814475 
Fix #36, Use OS_MAX_QUEUE_DEPTH rather than 64.
@astrogeco astrogeco mentioned this issue May 20, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Bootes
2 participants
@jphickey @skliper