[IMPROVED] Optimized calculating source sequences for sourced stream with lots of deletes. #6461
+164
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce sequences and we have lots of interior deletes. Signed-off-by: Derek Collison <derek@nats.io>
| if err != nil || len(sm.hdr) == 0 { | ||
| for seq := state.LastSeq; seq >= state.FirstSeq; { | ||
| sm, err := mset.store.LoadPrevMsg(seq, &smv) | ||
| if err == ErrStoreEOF || err != nil { |
There was a problem hiding this comment.
Seems like a tautological condition, if the err is ErrStoreEOF then it's also not nil. Is the EOF meant to be handled differently?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added LoadPrevMsg to optimize when we walk backwards looking for source sequences and we have lots of interior deletes.
Signed-off-by: Derek Collison derek@nats.io