-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Cherry-picks for 2.10.26-RC.1 #6462
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Twigg <neil@nats.io>
We intended to deprecate this but did not do so in the end and it is critical in current API clients Signed-off-by: R.I.Pienaar <rip@devco.net>
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
This should make the output of `healthz` less opaque when there are stream or consumer healthcheck errors. Signed-off-by: Neil Twigg <neil@nats.io>
[ci skip] Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Evan Anderson <evan@stacklok.com>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
The relevant code for multi-filtered consumers differs considerably between the two stores, so we need to be watching both. Signed-off-by: Neil Twigg <neil@nats.io>
This avoids a potentially expensive linear walk if it is obvious that the block FSS contains less subjects than sequences that we would otherwise have to scan. Signed-off-by: Neil Twigg <neil@nats.io>
…alls Signed-off-by: Neil Twigg <neil@nats.io>
This updates `dios` to range up to 50% of the core count on a system with more than 32 CPU cores, otherwise obeying the 4 to 16 limit. Signed-off-by: Neil Twigg <neil@nats.io>
This updates `generatePerSubjectInfo`, `NumPending` and `NumPendingMulti` to avoid updating the last load timestamp in a tight-loop while skipping over a potentially large number of interior deletes, as this becomes noticeable in the CPU profile. Signed-off-by: Neil Twigg <neil@nats.io>
This should ensure the compressors are more aggressively cleared and also handle a couple of error scenarios better by releasing/repooling buffers. Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
…lient info Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
derekcollison
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ce sequences and we have lots of interior deletes. Signed-off-by: Derek Collison <derek@nats.io>
348f8e0
to
84474c6
Compare
derekcollison
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following:
TestJetStreamClusterGhostEphemeralsAfterRestart
#6406Leaderless
andHadPreviousLeader
#6438raftz
andipqueuesz
via system account #6439IntersectStree
for matching subject literals #6446BenchmarkJetStreamConsumeWithFilters
#6447LoadNextMsgMulti
#6448sliceHeader
for zero-copy parsing of message headers, use for client info #6453Iter
intoIterFast
andIterOrdered
#6458Signed-off-by: Neil Twigg neil@nats.io