Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix ordered consumer creation #746

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Fix ordered consumer creation #746

merged 2 commits into from
Feb 24, 2025

Conversation

mtmk
Copy link
Collaborator

@mtmk mtmk commented Feb 19, 2025

Fixing issues found in internal testing

@mtmk mtmk self-assigned this Feb 19, 2025
@mtmk
Add exponential backoff with jitter for retries
c814f7f 
Introduce `BackoffWithJitterAsync` to calculate delay with jitter, improving retry logic. Update `NatsJSOrderedConsumer` to utilize the new method during connection reset attempts.
@mtmk mtmk requested a review from scottf February 19, 2025 19:06
@mtmk mtmk marked this pull request as ready for review February 19, 2025 19:07
@mtmk mtmk requested a review from MauriceVanVeen February 24, 2025 13:58
MauriceVanVeen
MauriceVanVeen approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@MauriceVanVeen MauriceVanVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtmk mtmk merged commit a4a3058 into main Feb 24, 2025
13 checks passed
@mtmk mtmk deleted the ordered-consumer-fixes branch February 24, 2025 14:00
mtmk added a commit that referenced this pull request Feb 24, 2025
@mtmk
Release 2.5.9
961e79f 
* Fix ordered consumer creation (#746)
* Consumer pause docs update (#742)
@mtmk mtmk mentioned this pull request Feb 24, 2025
Merged
mtmk added a commit that referenced this pull request Feb 24, 2025
@mtmk
Release 2.5.9 (#748)
58e1646 
* Release 2.5.9

* Fix ordered consumer creation (#746)
* Consumer pause docs update (#742)

* Update version.txt
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@MauriceVanVeen MauriceVanVeen MauriceVanVeen approved these changes

@scottf scottf Awaiting requested review from scottf

Assignees

@mtmk mtmk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtmk @MauriceVanVeen