Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

normalize parent material, geomorp, ecosite, flattening strategies #84

Closed
dylanbeaudette opened this issue Oct 31, 2018 · 3 comments
Closed
Labels
NASIS-local This tag is used for pull requests, issues, discussions etc. for soilDB local NASIS functions

Comments

@dylanbeaudette
Copy link
Member

dylanbeaudette commented Oct 31, 2018

There are several implementations which all do slightly different things:

  • .copm_prep: applies to data returned by SDA
  • .formatParentMaterialString: applies to pedon objects
  • .formatcoParentMaterialString: applies to component objects

The strategies used by formatcoParentMaterialString and formatParentMaterialString are more or less the same, with the component version employing additional checks on the source data. Missing or inconsistent record IDs, sequence numbers, vertical order sequences, and "exists on" logic contribute to the complexity of the code.

There are likely some corner-cases not yet handled by these functions, see #83 for an example.

Notes to myself for next time.

library(soilDB)

x <- fetchNASIS(from='components')
knitr::kable(site(x)[1:5, c('compname', 'pmkind', 'pmorigin')])

z <- fetchNASIS(from='pedons')
knitr::kable(site(z)[10:15, c('taxonname', 'pmkind', 'pmorigin', 'bedrckkind')])
@dylanbeaudette
Copy link
Member Author

See also #47

dylanbeaudette added a commit that referenced this issue Oct 31, 2018
@brownag brownag added the NASIS-local This tag is used for pull requests, issues, discussions etc. for soilDB local NASIS functions label Jan 16, 2021
@brownag
Copy link
Member

brownag commented Nov 12, 2021

With recent work on fetchNASIS (0b3d517) .formatcoParentMaterialString has been deprecated in favor of .formatParentMaterialString for component data.

@brownag
Copy link
Member

brownag commented Apr 28, 2023

I believe this issue has been resolved.

The .formatcoXXX() functions have been subsumed into `.formatXXX() for NASIS.

In this issue we are not going to address harmonizing the above parent material functions with the SDA function .copm_prep() that is used for SDA and SSURGO File Geodatabases.

A variety of new tools and derived values are available for geomorph and parent material in the NASIS and SDA derived results compared to when this issue was made in 2018. If there are any specific further needs, let's create a new issue.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
NASIS-local This tag is used for pull requests, issues, discussions etc. for soilDB local NASIS functions
Projects
None yet
Development

No branches or pull requests

2 participants