Skip to content

config: upgrade NeoFS chains protocol configuration #3858

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 1, 2025
Merged

config: upgrade NeoFS chains protocol configuration #3858

merged 4 commits into from
Apr 1, 2025

Conversation

AnnaShaleva
Copy link
Member

@AnnaShaleva AnnaShaleva commented Mar 31, 2025 •
edited
Loading

Description

We're close to v3.8.0 which means that C# node will be able to process NeoFS chains. We need NeoFS protocol configuration to be up-to-date with the one that is used in real NeoFS mainnet/testnet. Port the nspcc-dev/neo-go#3833.

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • TestMaxValidUntilBlockIncrement, TestDefaultMaxValidUntilBlockIncrementValue

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@AnnaShaleva
config: adjust MillisecondsPerBlock for FS networks
0c00580 
We use 1-second blocks in NeoFS mainnet/testnet for quite a long time,
follow nspcc-dev/neo-go#3833.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@AnnaShaleva AnnaShaleva added this to the v3.8.0 milestone Mar 31, 2025
@AnnaShaleva
ProtocolSettings: fetch MaxValidUntilBlockIncrement from config
6b05a68 
It's the protocol setting, hence it needs to be fetched from JSON node
configuration file.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@AnnaShaleva
config: adjust MaxValidUntilBlockIncrement for FS networks
7f7f6f3 
Follow the nspcc-dev/neo-go#3833.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@AnnaShaleva AnnaShaleva requested a review from superboyiii March 31, 2025 13:11
@Wi1l-B0t Wi1l-B0t added the Easy-to-Review a simple edit; just a few lines label Mar 31, 2025
@shargon shargon merged commit bbe17a0 into master Apr 1, 2025
6 checks passed
@shargon shargon deleted the fs-cfg-upd branch April 1, 2025 17:44
Jim8y added a commit to Jim8y/neo that referenced this pull request Apr 9, 2025
@Jim8y
Merge branch 'master' into opcode-bench-files
5a4c994 
* master: (163 commits)
  [style] Added some var styles (neo-project#3867)
  [`fix`] stop syncing on block 1465790 (neo-project#3888)
  Optimize block deserialization (neo-project#3879)
  Avoid double `ToArray` on `OnInvMessageReceived` (neo-project#3875)
  style: format long lines (neo-project#3884)
  optimize: return GetFileNameWithoutExtension(Path) if name is not set (neo-project#3883)
  Fix possible null exception (neo-project#3880)
  Remove linkedList (neo-project#3873)
  Optimize Uint160 and Uint256 constructor (neo-project#3872)
  Release the resources (neo-project#3868)
  [Clean] Remove `IRawReadOnlyStore` (neo-project#3869)
  move non-plugins out of plugins (neo-project#3863)
  feature: set name when create wallet (neo-project#3866)
  Native: swap Policy's `[get/set]AttributeFee` implementations (neo-project#3859)
  Fix: concurrent conflict in Cache.CopyTo (neo-project#3860)
  Fix: add default key parameter in help cmd (neo-project#3865)
  [Plugin UT] add more rpcserver UTs (neo-project#3864)
  config: upgrade NeoFS chains protocol configuration (neo-project#3858)
  [`Optimization`]: add exception message to `ArgumentException` (neo-project#3862)
  Native: unify arguments naming of CryptoLib's `verifyWith*` methods (neo-project#3855)
  ...

# Conflicts:
#	benchmarks/Neo.VM.Benchmarks/OpCode/Arrays/OpCode.ReverseN.cs
#	benchmarks/Neo.VM.Benchmarks/Program.cs
#	src/Neo/Neo.csproj
#	src/Neo/ProtocolSettings.cs
#	src/Neo/SmartContract/ApplicationEngine.cs
#	src/Neo/SmartContract/Native/NeoToken.cs
#	src/Neo/SmartContract/Native/RoleManagement.cs
#	tests/Neo.UnitTests/SmartContract/Manifest/UT_ContractManifest.cs
#	tests/Neo.UnitTests/SmartContract/Manifest/UT_ContractPermission.cs
#	tests/Neo.UnitTests/SmartContract/Native/UT_NativeContract.cs
#	tests/Neo.UnitTests/SmartContract/Native/UT_NeoToken.cs
#	tests/Neo.UnitTests/UT_ProtocolSettings.cs
#	tests/Neo.VM.Tests/UT_ReferenceCounter.cs
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@shargon shargon shargon approved these changes

@Jim8y Jim8y Jim8y approved these changes

@vncoelho vncoelho vncoelho approved these changes

@Wi1l-B0t Wi1l-B0t Wi1l-B0t approved these changes

@cschuchardt88 cschuchardt88 Awaiting requested review from cschuchardt88

@roman-khimov roman-khimov Awaiting requested review from roman-khimov

@superboyiii superboyiii Awaiting requested review from superboyiii

Assignees
No one assigned
Labels
Easy-to-Review a simple edit; just a few lines Ready to Merge
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@AnnaShaleva @shargon @Jim8y @vncoelho @Wi1l-B0t