Native: swap Policy's [get/set]AttributeFee implementations
#3859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: `[get/set]AttributeFee` method of native Policy contract has two implementations: pre-Echidna and post-Echidna (ref. #3175). The problem is that two implementaitons of this method have reversed ActiveIn/ActiveTill meaning. Solution: GetAttributeFeeV0 implementaiton of Policy's `getAttributeFee` method should be enabled *till* Echidna, whereas GetAttributeFee should be enabled *starting from* Echidna. The same is relevant for SetAttributeFeeV0 and SetAttributeFeeV1 implementations. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
This renaming allows to avoid bugs and collisions with ActiveIn/ActiveTill. Also, this renaming follows the setters style (for setters we have `SetAttributeFeeV0` and `SetAttributeFeeV1`. No functional changes, just a refactoring. Contract manifest is not affected. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
requested review from
shargon,
cschuchardt88,
Jim8y,
vncoelho,
roman-khimov and
Wi1l-B0t
|
LMAO, that is really easy to be ignored, maybe we should explicityly use deactive = true.... |
Jim8y
approved these changes
Apr 1, 2025
shargon
approved these changes
Apr 1, 2025
AnnaShaleva
added a commit
that referenced
this pull request
Apr 3, 2025
No functional changes, just adopt the #3859. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Jim8y
added a commit
to Jim8y/neo
that referenced
this pull request
Apr 9, 2025
* master: (163 commits) [style] Added some var styles (neo-project#3867) [`fix`] stop syncing on block 1465790 (neo-project#3888) Optimize block deserialization (neo-project#3879) Avoid double `ToArray` on `OnInvMessageReceived` (neo-project#3875) style: format long lines (neo-project#3884) optimize: return GetFileNameWithoutExtension(Path) if name is not set (neo-project#3883) Fix possible null exception (neo-project#3880) Remove linkedList (neo-project#3873) Optimize Uint160 and Uint256 constructor (neo-project#3872) Release the resources (neo-project#3868) [Clean] Remove `IRawReadOnlyStore` (neo-project#3869) move non-plugins out of plugins (neo-project#3863) feature: set name when create wallet (neo-project#3866) Native: swap Policy's `[get/set]AttributeFee` implementations (neo-project#3859) Fix: concurrent conflict in Cache.CopyTo (neo-project#3860) Fix: add default key parameter in help cmd (neo-project#3865) [Plugin UT] add more rpcserver UTs (neo-project#3864) config: upgrade NeoFS chains protocol configuration (neo-project#3858) [`Optimization`]: add exception message to `ArgumentException` (neo-project#3862) Native: unify arguments naming of CryptoLib's `verifyWith*` methods (neo-project#3855) ... # Conflicts: # benchmarks/Neo.VM.Benchmarks/OpCode/Arrays/OpCode.ReverseN.cs # benchmarks/Neo.VM.Benchmarks/Program.cs # src/Neo/Neo.csproj # src/Neo/ProtocolSettings.cs # src/Neo/SmartContract/ApplicationEngine.cs # src/Neo/SmartContract/Native/NeoToken.cs # src/Neo/SmartContract/Native/RoleManagement.cs # tests/Neo.UnitTests/SmartContract/Manifest/UT_ContractManifest.cs # tests/Neo.UnitTests/SmartContract/Manifest/UT_ContractPermission.cs # tests/Neo.UnitTests/SmartContract/Native/UT_NativeContract.cs # tests/Neo.UnitTests/SmartContract/Native/UT_NeoToken.cs # tests/Neo.UnitTests/UT_ProtocolSettings.cs # tests/Neo.VM.Tests/UT_ReferenceCounter.cs
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem:
[get/set]AttributeFeemethod of native Policy contract has two implementations: pre-Echidna and post-Echidna (ref. #3175). The problem is that two implementations of this method have reversed ActiveIn/ActiveTill meaning.Solution:
GetAttributeFeeV0 implementaiton of Policy's
getAttributeFeemethod should be enabled till Echidna, whereas GetAttributeFee should be enabled starting from Echidna. The same is relevant for SetAttributeFeeV0 and SetAttributeFeeV1 implementations.Type of change
How Has This Been Tested?
Checklist: