-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove --cgroups support #5200
Labels
removal
Removal of a feature/option
Comments
Marking it a bug, I'll clean them up. |
netblue30
added a commit
that referenced
this issue
Jun 16, 2022
I think that the code related to the option is all gone now: $ git show --pretty='%h %ai %s' -s
0e0804635 2022-06-16 16:52:02 -0300 update_deb.sh: remove cgroup-related code
$ git grep cgroup | grep -v '^RELNOTES:' | grep cgroup
etc/inc/disable-proc.inc:blacklist /proc/cgroups
etc/inc/disable-proc.inc:blacklist /proc/kpagecgroup
test/fs/sys_fs.exp: "cgroup" Thanks for continuing the removal until the end. |
kmk3
added a commit
to kmk3/firejail
that referenced
this issue
Sep 19, 2022
And add the missing issue/PR references. Misc: The items in question were added on commit 6d740d7 ("RELNOTES and README.md - existing functionality modified for the next version", 2022-08-29). Relates to netblue30#5190 netblue30#5196 netblue30#5200 netblue30#5209 netblue30#5216.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
(Continued from #5190)
Some commits have been made to remove support for
--cgroups
:But there is still quite a bit of cgroup-related code left:
At a glance, I think that the syntax/completion/test code should probably also
be removed; not sure about the rest.
Cc: @netblue30
The text was updated successfully, but these errors were encountered: