Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove shell none from profiles #5209

Merged
merged 1 commit into from
Jun 19, 2022

Conversation

rusty-snake
Copy link
Collaborator

Command: sed -i "/^shell none/d" etc/*/*

TODO:

etc/profile-a-l/beaker.profile:ignore shell none
etc/profile-a-l/default.profile:# shell none
etc/profile-a-l/fdns.profile:#shell none
etc/profile-a-l/gnome-nettool.profile:#shell none
etc/profile-a-l/jitsi-meet-desktop.profile:ignore shell none
etc/profile-m-z/pidgin.profile:# shell none
etc/profile-m-z/rocketchat.profile:ignore shell none
etc/profile-m-z/server.profile:# shell none
etc/templates/profile.template:#   OPTIONS (caps*, net*, no*, protocol, seccomp*, shell none, tracelog)
etc/templates/profile.template:#shell none
  • manpage
  • RELNOTES
  • fbuilder

Command: sed -i "/^shell none/d" etc/*/*

TODO:

```
etc/profile-a-l/beaker.profile:ignore shell none
etc/profile-a-l/default.profile:# shell none
etc/profile-a-l/fdns.profile:#shell none
etc/profile-a-l/gnome-nettool.profile:#shell none
etc/profile-a-l/jitsi-meet-desktop.profile:ignore shell none
etc/profile-m-z/pidgin.profile:# shell none
etc/profile-m-z/rocketchat.profile:ignore shell none
etc/profile-m-z/server.profile:# shell none
etc/templates/profile.template:#   OPTIONS (caps*, net*, no*, protocol, seccomp*, shell none, tracelog)
etc/templates/profile.template:#shell none
```

- manpage
- RELNOTES
- fbuilder
Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glitsj16
Copy link
Collaborator

Now that shell is checked via passwd, should we ensure private-etc contains passwd?

@netblue30
Copy link
Owner

Thanks!

@netblue30 netblue30 merged commit da268cf into netblue30:master Jun 19, 2022
@rusty-snake rusty-snake deleted the shell-none-default branch June 20, 2022 15:13
@kmk3
Copy link
Collaborator

kmk3 commented Jun 20, 2022

Relates to #5196.

@kmk3 kmk3 added the removal Removal of a feature/option label Aug 20, 2022
kmk3 added a commit to kmk3/firejail that referenced this pull request Sep 19, 2022
And add the missing issue/PR references.

Misc: The items in question were added on commit 6d740d7 ("RELNOTES
and README.md - existing functionality modified for the next version",
2022-08-29).

Relates to netblue30#5190 netblue30#5196 netblue30#5200 netblue30#5209 netblue30#5216.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
removal Removal of a feature/option
Projects
Status: Done (on RELNOTES)
Development

Successfully merging this pull request may close these issues.

4 participants