npm preinstall and postinstall scripts are not run

[denis-sokolov]

npm preinstall and postinstall scripts are not run, resulting in breaking builds that are valid outside of Netlify.

This is caused by our caching mechanism only restoring the node_modules/ directory:

build-image/run-build-functions.sh

Line 478 in d84c794

restore_cwd_cache node_modules "node modules"

And then running npm install conditionally:

build-image/run-build-functions.sh

Lines 149 to 153 in d84c794

	if install_deps package.json $NODE_VERSION $NETLIFY_CACHE_DIR/package-sha
	then
	echo "Installing NPM modules using NPM version $(npm --version)"
	run_npm_set_temp
	if npm install ${NPM_FLAGS:+"$NPM_FLAGS"}

An existing PR fixes this: #510.

[agostbiro]

What's the status on this? I'm running into this on the focal image.

[jonsherrard]

Is it possible to add other folders to be cache in netlify.toml at all?

I haven't seen anything outside the docs though.

Currently breaks builds that use playwright because the browser images are cached outside node_modules.

[jonsherrard]

OK idea for peeps out there stuck wthith is issue: I'm just running my "postinstall" command before the npm build command in Netlify config now.

npx [my postinstalll]] && npm run build

[mwood23]

Just got bit by this breaking our environments because patch-package wasn't run. 😬

[pimlie]

@jobala Thanks for the PR, a quick review seems to indicate this issue is only fixed for npm users but not for yarn users? Is that correct?