Detsim city with IC dataflow structure #700
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following issue #691:
8. upload detsim city with dataflow structure in invisible_cities/cities/detsim.py
This detsim city read MC energy hits and performs the physics probabilistic simulation, which is not the full simulation. The output is in waveform form.
Comments:
-A modification in the city imports would be required once the PRs are approved: #694 #695 #697 #698 #699.
-For the full simulation city consult PR #