Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Detsim city with IC dataflow structure #700

Closed
wants to merge 2 commits into from

Conversation

gondiaz
Copy link
Collaborator

@gondiaz gondiaz commented Feb 26, 2020

Following issue #691:
8. upload detsim city with dataflow structure in invisible_cities/cities/detsim.py

This detsim city read MC energy hits and performs the physics probabilistic simulation, which is not the full simulation. The output is in waveform form.

Comments:
-A modification in the city imports would be required once the PRs are approved: #694 #695 #697 #698 #699.
-For the full simulation city consult PR #

carmenromo pushed a commit that referenced this pull request Nov 27, 2020
#758

[author: andLaing]

Moves some of the pipe from buffy to a compound component in components so it
can be used by the parametrized detsim city (under development).

Also adds a couple of protections to the buffer functions so that they are safe
for both cities.

[reviewer: mmkekic]

This PR adapts bufferization functions and extract the pipe that creates buffers
from the buffy flow allowing it to be reused in the detsim city as
well (#691,#700). Tests are added to show that the functions work both with
pandas and numpy inputs. Thanks for the effort!
@gondiaz gondiaz closed this Feb 3, 2021
@gondiaz
Copy link
Collaborator Author

gondiaz commented Feb 3, 2021

Close deprecated PR. A new open will be open.

@gondiaz gondiaz deleted the detsim_city branch September 9, 2021 07:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant