Bufferization pipe #758
Merged
Bufferization pipe #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmkekic
reviewed
Nov 25, 2020
| @@ -141,6 +141,9 @@ def position_signal(triggers : List , | |||
| pmt_q = np.asarray(pmt_charge.tolist()) | |||
| sipm_q = np.empty((0,0))\ | |||
| if sipm_charge.empty else np.asarray(sipm_charge.tolist()) | |||
| else: | |||
There was a problem hiding this comment.
Could you add a test for this, it should be very straightforward. Something similar to
test_buffer_calculator flow but just asserting that the output is the same when using pandas and numpy array as input?
Makes a compound component for use in buffy and the new parametrized detsim city
andLaing
force-pushed
the
bufferization-pipe
branch
from
157741a
to
8c28229
Compare
andLaing
force-pushed
the
bufferization-pipe
branch
from
8c28229
to
35a1c31
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moves some of the pipe from buffy to a compound component in components so it can be used by the parametrized detsim city (under development).
Also adds a couple of protections to the buffer functions so that they are safe for both cities.