Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add task.ext.args to phantompeakqualtools and finish the module #1474

Merged
merged 5 commits into from
Mar 31, 2022

Conversation

JoseEspinosa
Copy link
Member

@JoseEspinosa JoseEspinosa commented Mar 31, 2022

As explained here, when the data set is too big the phantompeakqualtools throws an exception. Adding the option fixes the problem --max-ppsize=500000. On this PR, task.ext.args to the phantompeakqualtools command and also, all the missing bits of the module were added (tests + meta.yml file)

PR checklist

  • This comment contains a description of changes (with reason).
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@JoseEspinosa JoseEspinosa marked this pull request as ready for review March 31, 2022 21:15
@JoseEspinosa JoseEspinosa changed the title Add --max--ppsize option to phantompeakqualtools Add task.ext.args to phantompeakqualtools and finish the module Mar 31, 2022
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you went with args and not args2 too? It can be changed later if required.

@drpatelh drpatelh merged commit 5e7daa7 into nf-core:master Mar 31, 2022
@JoseEspinosa
Copy link
Member Author

Yep thought it was going to be more simpler since there are no other arguments passed to the tool

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants