Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Test fix for downloading #566

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Test fix for downloading #566

merged 4 commits into from
Jan 10, 2025

Conversation

sofstam
Copy link
Collaborator

@sofstam sofstam commented Jan 9, 2025

This PR tests the download fix and fixes some typos from #563

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/taxprofiler branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@sofstam sofstam merged commit b4e9985 into nf-core:dev Jan 10, 2025
25 checks passed
@MatthiasZepper MatthiasZepper mentioned this pull request Jan 13, 2025
Merged
4 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@LilyAnderssonLee LilyAnderssonLee LilyAnderssonLee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sofstam @LilyAnderssonLee