Use "Color" type for "InvertY" group #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Candoran2
approved these changes
Dec 8, 2022
|
Color is indeed more consistent with the node socket types that are incoming/outgoing. However, what do you mean by "Cycles renderer is not happy"? |
|
Cycles ignores input (Normal map in this case) if image types are being used rather than color. |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@niftools/blender-niftools-addon-reviewer
Overview
Use
NodeSocketColorforInvertYgroup for normal maps.Detailed Description
Eevee is okay but Cycles renderer is not happy if
NodeSocketImageis used. Also blender GUI won't allow you to setNodeSocketImageas a socket type.Fixes Known Issues
[Ordered list of issues fixed by this PR]
Documentation
[Overview of updates to documentation]
Testing
Blender 3.3.1 Windows
Manual
[Set of steps to manually verify updates are working correctly]
Automated
[List of tests run, updated or added to avoid future regressions]
Additional Information
[Anything else you deem relevant]