Reorganize tests & add sort-key support #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikstur
force-pushed
the
reorganize-crates
branch
3 times, most recently
from
5d5b9e4 to
bbfcf22
Compare
|
This is gonna mega-mergeconflict with my stuff :D… |
|
Can we leave 98095c0 out for now and revisit this later? |
|
Or just keep the minimum out of it (e.g. display renames). |
Yes let's do it. |
nikstur
force-pushed
the
reorganize-crates
branch
from
bbfcf22 to
3c0644c
Compare
nikstur
changed the title
|
@RaitoBezarius CI is green now (minus the buildbot glitch that says its not green). |
RaitoBezarius
approved these changes
Jun 12, 2024
Putting all the tests in one module makes it much easier to re-use common code and also increases test speed. This is why the cargo test suite does the same: https://matklad.github.io/2021/02/27/delete-cargo-integration-tests.html
nikstur
force-pushed
the
reorganize-crates
branch
from
3c0644c to
b92cf84
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganize crates (names and directories) to be more consistentboot.lanzaboote.sortKeyoption. Closes boot.loader.systemd-boot.sortKey has no effect #349Review commit by commit.