Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Preparing v4.2.2 LTS Maintenance #50

Closed
jasnell opened this issue Oct 28, 2015 · 12 comments
Closed

Preparing v4.2.2 LTS Maintenance #50

jasnell opened this issue Oct 28, 2015 · 12 comments
Assignees
@jasnell

Comments

@jasnell
Copy link
Member

jasnell commented Oct 28, 2015

@nodejs/lts ... preparing for the v4.2.2 LTS Maintenance release... Here's the list of candidate commits currently sitting in v4.x-staging. Please let me know if any of these SHOULD NOT be in the v4.2.2 release (https://github.com/nodejs/node/commits/v4.x-staging)

List of commits in v4.x-staging: #50 (comment)
List of commits remaining in master: #50 (comment)

/cc @nodejs/collaborators
@jasnell jasnell self-assigned this Oct 28, 2015
@rvagg
Copy link
Member

rvagg commented Oct 28, 2015

I've just published a new version of branch-diff with a --patch-only commandline option so we can see what the candidates are, I think that adding a --start-ref might help too so we can limit the list to only those within a certain date range (e.g. --start-ref=v4.2.2), but that can come later.

For the purpose of looking at the commits that are still candidates because that's worth discussing too.

$ branch-diff v4.x-staging master --patch-only --group
  • [b52142fe80] - Working on 6.0.0 (Rod Vagg)
  • [0a7076b0f1] - 2015-10-13, Version 4.2.1 'Argon' (LTS) Release (James M Snell)
  • [4a6f1feecb] - 2015-09-22, Version 4.1.1 (Stable) Release (Rod Vagg) #2995
  • [b9813641dc] - 2015-09-15 io.js v3.3.1 Release (Rod Vagg) #2698
  • [380a3d89c3] - 2015-09-08, Version 4.0.0 (Stable) Release (Rod Vagg) #2742
  • [42a8a0a53e] - Working on v5.0.0 (Rod Vagg)
  • [15bcbf853e] - build: Updates for AIX npm support - part 1 (Michael Dawson) #3114
  • [753509f579] - build: rectify --link-module help text (P.S.V.R) #3379
  • [6456fcf4f3] - deps: update V8 to 4.6.85.28 (Michaël Zasso) #3484
  • [68471dd37c] - deps: fix upgrade to npm 3.3.6 (Rebecca Turner) #3494
  • [41923c0c07] - deps: upgrade npm to 3.3.6 (Rebecca Turner) #3310
  • [a334ddc467] - _Revert_ "deps: backport 03ef3cd from V8 upstream" (Ali Ijaz Sheikh) #3237
  • [6fff47ffac] - deps: backport 03ef3cd from V8 upstream (Ali Ijaz Sheikh) #3165
  • [680dda8023] - dns: remove nonexistant exports.ADNAME (Roman Reiss) #3051
  • [052611b0d1] - doc: add TSC meeting minutes 2015-10-21 (Rod Vagg) #3480
  • [0a0926e863] - doc: add TSC meeting minutes 2015-10-14 (Rod Vagg) #3463
  • [d381290854] - doc: more use-cases for promise events (Domenic Denicola) #3438
  • [829eb97fef] - doc: update WORKING_GROUPS.md - add missing groups (Michael Dawson) #3450
  • [cba5d2b948] - doc: add TSC meeting minutes 2015-09-30 (Rod Vagg) #3235
  • [b78de124d6] - doc: add TSC meeting minutes 2015-10-07 (Rod Vagg) #3364
  • [a441aa6e1d] - doc: update WORKING_GROUPS.md to include Intl (Steven R. Loomis) #3251
  • [3ef2e4acf3] - doc: fix typos in changelog (reggi) #3291
  • [b9279aa193] - doc: remove old note, 'cluster' is marked stable (Balázs Galambosi) #3314
  • [cdfa271164] - doc: update AUTHORS list (Rod Vagg)
  • [aaf9b488e2] - lib,test: update let to const where applicable (Sakthipriyan Vairamani) #3152
  • [9adc6a6bd0] - lttng: update flags for gc tracing (Glen Keane) #3388
  • [494227bb03] - node: improve GetActiveRequests performance (Trevor Norris) #3375
  • [53e64bb29e] - src: fix race condition in debug signal on exit (Ben Noordhuis) #3528
  • [a3b238a0d0] - src: bump NODE_MODULE_VERSION To 47 (Rod Vagg) #3400
  • [2d3560767e] - src: fix exception message encoding on Windows (Brian White) #3288
  • [ff877e93e1] - src: fix stuck debugger process (Liang-Chi Hsieh) #2778
  • [3a091d29bf] - test: add node::MakeCallback() test coverage (Ben Noordhuis) #3478
  • [642928b502] - test: port domains regression test from v0.10 (Jonas Dohse) #3356
  • [6f14b3a7db] - test: remove util from common (Rich Trott) #3324
  • [7d94611ac9] - test: split up buffer tests for reliability (Rich Trott) #3323
  • [3202456baa] - test: remove util properties from common (Rich Trott) #3304
  • [31c971d641] - test: parallelize long-running test (Rich Trott) #3287
  • [5bbc6df7de] - test: change call to deprecated util.isError() (Rich Trott) #3084
  • [3eecdf9f14] - timers: reuse timer in setTimeout().unref() (Fedor Indutny) #3407
  • [b0e7b362c2] - tools: enable prefer-const eslint rule (Sakthipriyan Vairamani) #3152
  • [9b8886446d] - tools: ensure npm always uses the local node (Jeremiah Senkpiel) #3489
  • [349fbe96ae] - tools: update test-npm to work with npm 3 (Rebecca Turner) #3489
  • [f5445db4cd] - tools: use absolute paths in test-npm (Rebecca Turner) #3309
  • [1cbc2d05b5] - v8: pull fix for builtin code size on PPC (Michael Dawson) #3474
  • [b244f139bf] - vm: remove Watchdog dependency on Environment (Ido Ben-Yair) #3274

@rvagg
Copy link
Member

rvagg commented Oct 28, 2015

I'm not meaning to spam here, but this is @jasnell's original list shown in the standard format, grouped (also demonstrating how branch-diff and changelog-maker can be used here):

$ branch-diff v4.x v4.x-staging --group
  • [bc2120caa1] - buffer: fix value check for writeUInt{B,L}E (Trevor Norris) #3500
  • [287e8306fd] - buffer: don't CHECK on zero-sized realloc (Ben Noordhuis) #3499
  • [9061aa2a75] - deps: backport 8d6a228 from the v8's upstream (Fedor Indutny) #3549
  • [e223fc7499] - doc: fix indent in tls resumption example (Roman Reiss) #3372
  • [31a9ecf504] - doc: fix typo in changelog (Timothy Gu) #3353
  • [925953d1bc] - doc: show keylen in pbkdf2 as a byte length (calebboyd) #3334
  • [4023c7dc34] - doc: add information about Assert behavior and maintenance (Rich Trott) #3330
  • [4afcf5732b] - doc: clarify API buffer.concat (Martii) #3255
  • [282618e237] - doc: clarify the use of option.detached (Kyle Smith) #3250
  • [240046ccc6] - doc: binary encoding is not deprecated (Trevor Norris) #3441
  • [47ab7c76f0] - docs: add missing shell option to execSync (fansworld-claudio) #3440
  • [fb3b8489de] - fs: reduced duplicate code in fs.write() (ronkorving) #2947
  • [87f8ccfe35] - http: fix stalled pipeline bug (Fedor Indutny) #3342
  • [e4417a1bfa] - lib: fix cluster handle leak (Rich Trott) #3510
  • [1888f84204] - lib: avoid REPL exit on completion error (Rich Trott) #3358
  • [594e8e7a54] - repl: limit persistent history correctly on load (Jeremiah Senkpiel) #2356
  • [5db1f070fe] - stream: avoid unnecessary concat of a single buffer. (Calvin Metcalf) #3300
  • [172cccfe0c] - stream: fix signature of _write() in a comment (Fábio Santos) #3248
  • [12d83858f7] - test: improve tests for util.inherits (Michaël Zasso) #3507
  • [9e05af7d31] - test: print helpful err msg on test-dns-ipv6.js (Junliang Yan) #3501
  • [5222fcc117] - test: fix domain with abort-on-uncaught on PPC (Julien Gilli) #3354
  • [9fa8c32d35] - test: cleanup, improve repl-persistent-history (Jeremiah Senkpiel) #2356
  • [6305d26f40] - test: add Symbol test for assert.deepEqual() (Rich Trott) #3327
  • [bc2a80b493] - test: disable test-tick-processor - aix and be ppc (Michael Dawson) #3491
  • [304eda46a4] - test: harden test-child-process-fork-regr-gh-2847 (Michael Dawson) #3459
  • [e99823bf5a] - test: fix test-net-keepalive for AIX (Imran Iqbal) #3458
  • [635f74366f] - test: wrap assert.fail when passed to callback (Myles Borins) #3453
  • [49549c9b2a] - test: skip test-dns-ipv6.js if ipv6 is unavailable (Junliang Yan) #3444
  • [3d1f57d9dd] - test: repl-persistent-history is no longer flaky (Jeremiah Senkpiel) #3437
  • [0b324142ca] - test: fix flaky test-child-process-emfile (Rich Trott) #3430
  • [0c23e81d7a] - test: remove flaky status from eval_messages test (Rich Trott) #3420
  • [d62d15843c] - test: fix flaky test for symlinks (Rich Trott) #3418
  • [d540666bfe] - test: apply correct assert.fail() arguments (Rich Trott) #3378
  • [41a4258f57] - test: replace util with backtick strings (Myles Borins) #3359
  • [e43c611be5] - test: add test-child-process-emfile fail message (Rich Trott) #3335
  • [f6ea99f67b] - tls: TLSSocket options default isServer false (Yuval Brik) #2614

@jasnell
Copy link
Member Author

jasnell commented Oct 28, 2015

@rvagg .. hope you don't mind, I turned your first list into a checklist so we can more easily reconcile the two lists... the checked items are things that I identify should land in v4.x-staging (if any)

@jasnell
Copy link
Member Author

jasnell commented Oct 28, 2015

Ok, landed another round of commits based on the checked items above. Here's the updated list of commits in v4.x-staging that are being considered for the v4.2.2 release (generated using @rvagg's fancy tools ;-) )

  • [bc2120caa1] - buffer: fix value check for writeUInt{B,L}E (Trevor Norris) #3500
  • [287e8306fd] - buffer: don't CHECK on zero-sized realloc (Ben Noordhuis) #3499
  • [77511eb108] - deps: backport 010897c from V8 upstream (Ali Ijaz Sheikh) #3520
  • [9061aa2a75] - deps: backport 8d6a228 from the v8's upstream (Fedor Indutny) #3549
  • [282065f48b] - doc: mention the behaviour if URL is invalid (Sakthipriyan Vairamani) #2966
  • [e223fc7499] - doc: fix indent in tls resumption example (Roman Reiss) #3372
  • [31a9ecf504] - doc: fix typo in changelog (Timothy Gu) #3353
  • [925953d1bc] - doc: show keylen in pbkdf2 as a byte length (calebboyd) #3334
  • [4023c7dc34] - doc: add information about Assert behavior and maintenance (Rich Trott) #3330
  • [4afcf5732b] - doc: clarify API buffer.concat (Martii) #3255
  • [282618e237] - doc: clarify the use of option.detached (Kyle Smith) #3250
  • [240046ccc6] - doc: binary encoding is not deprecated (Trevor Norris) #3441
  • [47ab7c76f0] - docs: add missing shell option to execSync (fansworld-claudio) #3440
  • [fb3b8489de] - fs: reduced duplicate code in fs.write() (ronkorving) #2947
  • [87f8ccfe35] - http: fix stalled pipeline bug (Fedor Indutny) #3342
  • [e4417a1bfa] - lib: fix cluster handle leak (Rich Trott) #3510
  • [1888f84204] - lib: avoid REPL exit on completion error (Rich Trott) #3358
  • [d918838723] - repl: handle comments properly (Sakthipriyan Vairamani) #3515
  • [594e8e7a54] - repl: limit persistent history correctly on load (Jeremiah Senkpiel) #2356
  • [c85736eed7] - src: fix race condition in debug signal on exit (Ben Noordhuis) #3528
  • [9bffceb336] - src: fix exception message encoding on Windows (Brian White) #3288
  • [5db1f070fe] - stream: avoid unnecessary concat of a single buffer. (Calvin Metcalf) #3300
  • [172cccfe0c] - stream: fix signature of _write() in a comment (Fábio Santos) #3248
  • [2fc13e500c] - test: fix missing unistd.h on windows (Junliang Yan) #3532
  • [37aec6a97a] - test: add regression test for --debug-brk -e 0 (Ben Noordhuis) #3585
  • [b8869bdc27] - test: port domains regression test from v0.10 (Jonas Dohse) #3356
  • [d4fced7cb7] - test: remove util from common (Rich Trott) #3324
  • [4c411ae8f2] - test: remove util properties from common (Rich Trott) #3304
  • [a8425abfe5] - test: split up buffer tests for reliability (Rich Trott) #3323
  • [c76ef6c20c] - test: parallelize long-running test (Rich Trott) #3287
  • [5bb6e0f64d] - test: change call to deprecated util.isError() (Rich Trott) #3084
  • [12d83858f7] - test: improve tests for util.inherits (Michaël Zasso) #3507
  • [9e05af7d31] - test: print helpful err msg on test-dns-ipv6.js (Junliang Yan) #3501
  • [5222fcc117] - test: fix domain with abort-on-uncaught on PPC (Julien Gilli) #3354
  • [9fa8c32d35] - test: cleanup, improve repl-persistent-history (Jeremiah Senkpiel) #2356
  • [6305d26f40] - test: add Symbol test for assert.deepEqual() (Rich Trott) #3327
  • [bc2a80b493] - test: disable test-tick-processor - aix and be ppc (Michael Dawson) #3491
  • [304eda46a4] - test: harden test-child-process-fork-regr-gh-2847 (Michael Dawson) #3459
  • [e99823bf5a] - test: fix test-net-keepalive for AIX (Imran Iqbal) #3458
  • [635f74366f] - test: wrap assert.fail when passed to callback (Myles Borins) #3453
  • [49549c9b2a] - test: skip test-dns-ipv6.js if ipv6 is unavailable (Junliang Yan) #3444
  • [3d1f57d9dd] - test: repl-persistent-history is no longer flaky (Jeremiah Senkpiel) #3437
  • [0b324142ca] - test: fix flaky test-child-process-emfile (Rich Trott) #3430
  • [0c23e81d7a] - test: remove flaky status from eval_messages test (Rich Trott) #3420
  • [d62d15843c] - test: fix flaky test for symlinks (Rich Trott) #3418
  • [d540666bfe] - test: apply correct assert.fail() arguments (Rich Trott) #3378
  • [41a4258f57] - test: replace util with backtick strings (Myles Borins) #3359
  • [e43c611be5] - test: add test-child-process-emfile fail message (Rich Trott) #3335
  • [40bb8024c6] - timers: reuse timer in setTimeout().unref() (Fedor Indutny) #3407
  • [f6ea99f67b] - tls: TLSSocket options default isServer false (Yuval Brik) #2614

@jasnell
Copy link
Member Author

jasnell commented Oct 28, 2015

And the updated comparison of master <==> v4.x-staging ... (these are the commits that have not made it into v4.x-staging). #3474 is still an open question about whether it should make it into v4.x-staging or not.

[b52142fe80] - Working on 6.0.0 (Rod Vagg)

  • [0a7076b0f1] - 2015-10-13, Version 4.2.1 'Argon' (LTS) Release (James M Snell)
  • [4a6f1feecb] - 2015-09-22, Version 4.1.1 (Stable) Release (Rod Vagg) #2995
  • [b9813641dc] - 2015-09-15 io.js v3.3.1 Release (Rod Vagg) #2698
  • [380a3d89c3] - 2015-09-08, Version 4.0.0 (Stable) Release (Rod Vagg) #2742
  • [42a8a0a53e] - Working on v5.0.0 (Rod Vagg)
  • [15bcbf853e] - build: Updates for AIX npm support - part 1 (Michael Dawson) #3114
  • [753509f579] - build: rectify --link-module help text (P.S.V.R) #3379
  • [6456fcf4f3] - deps: update V8 to 4.6.85.28 (Michaël Zasso) #3484
  • [68471dd37c] - deps: fix upgrade to npm 3.3.6 (Rebecca Turner) #3494
  • [41923c0c07] - deps: upgrade npm to 3.3.6 (Rebecca Turner) #3310
  • [a334ddc467] - _Revert_ "deps: backport 03ef3cd from V8 upstream" (Ali Ijaz Sheikh) #3237
  • [6fff47ffac] - deps: backport 03ef3cd from V8 upstream (Ali Ijaz Sheikh) #3165
  • [680dda8023] - dns: remove nonexistant exports.ADNAME (Roman Reiss) #3051
  • [d394e9e6bb] - doc: add LTS info to COLLABORATOR_GUIDE.md (Myles Borins) #3442
  • [5d5a4c4c18] - doc: createServer's key option can be an array (Sakthipriyan Vairamani) #3123
  • [052611b0d1] - doc: add TSC meeting minutes 2015-10-21 (Rod Vagg) #3480
  • [0a0926e863] - doc: add TSC meeting minutes 2015-10-14 (Rod Vagg) #3463
  • [d381290854] - doc: more use-cases for promise events (Domenic Denicola) #3438
  • [829eb97fef] - doc: update WORKING_GROUPS.md - add missing groups (Michael Dawson) #3450
  • [cba5d2b948] - doc: add TSC meeting minutes 2015-09-30 (Rod Vagg) #3235
  • [b78de124d6] - doc: add TSC meeting minutes 2015-10-07 (Rod Vagg) #3364
  • [a441aa6e1d] - doc: update WORKING_GROUPS.md to include Intl (Steven R. Loomis) #3251
  • [3ef2e4acf3] - doc: fix typos in changelog (reggi) #3291
  • [b9279aa193] - doc: remove old note, 'cluster' is marked stable (Balázs Galambosi) #3314
  • [cdfa271164] - doc: update AUTHORS list (Rod Vagg)
  • [aaf9b488e2] - lib,test: update let to const where applicable (Sakthipriyan Vairamani) #3152
  • [9adc6a6bd0] - lttng: update flags for gc tracing (Glen Keane) #3388
  • [494227bb03] - node: improve GetActiveRequests performance (Trevor Norris) #3375
  • [c9e682d587] - test: use port number from env in tls socket test (Stefan Budeanu) #3557
  • [3a091d29bf] - test: add node::MakeCallback() test coverage (Ben Noordhuis) #3478
  • [b0e7b362c2] - tools: enable prefer-const eslint rule (Sakthipriyan Vairamani) #3152
  • [9b8886446d] - tools: ensure npm always uses the local node (Jeremiah Senkpiel) #3489
  • [349fbe96ae] - tools: update test-npm to work with npm 3 (Rebecca Turner) #3489
  • [f5445db4cd] - tools: use absolute paths in test-npm (Rebecca Turner) #3309
  • [1cbc2d05b5] - v8: pull fix for builtin code size on PPC (Michael Dawson) #3474
  • [b244f139bf] - vm: remove Watchdog dependency on Environment (Ido Ben-Yair) #3274

@jasnell
Copy link
Member Author

jasnell commented Oct 28, 2015

@rvagg : might be worthwhile having an option on branch-diff to exclude commits whose PRs are tagged as meta

@rvagg
Copy link
Member

rvagg commented Oct 28, 2015

was also thinking about an option to include a third branch and have it print a GitHub style checklist where the items that exist on the third branch are already ticked

@rvagg
Copy link
Member

rvagg commented Oct 28, 2015

@jasnell published a new version with --exclude-label so you can exclude what you like, provide multiple options to exclude multiple labels or just provide a comma-separated list. --patch-only is now just an alias for --exclude-label=semver-major,semver-minor but in this case --exclude-label=semver-major,semver-minor,meta would be what you're after. This'll also be helpful for excluding only semver-minor from stable releases.

@jasnell
Copy link
Member Author

jasnell commented Oct 29, 2015

@rvagg +1 ... awesome. How about the commit lists? Going to do the RC build tomorrow morning based on this list.

@jasnell
Copy link
Member Author

jasnell commented Oct 29, 2015

RC1 build queued up: https://ci.nodejs.org/job/iojs+release/238/

Scratch that... the windows systems on CI are giving me fits. ICU download keeps failing.

Update: Ok, finally kicked it enough and did the right magic incantation for it to work. RC1 build running now

@jasnell
Copy link
Member Author

jasnell commented Oct 29, 2015

@nodejs/lts @nodejs/collaborators ... v4.2.2-RC1 Builds Here: https://nodejs.org/download/rc/v4.2.2-rc.1/
Please smoke test!! Targeting Monday as the release date

@jasnell
Copy link
Member Author

jasnell commented Oct 29, 2015

Release Proposal: nodejs/node#3588

@jasnell jasnell closed this as completed Oct 29, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@jasnell jasnell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasnell @rvagg