Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test: remove flaky status from eval_messages test #3420

Closed
wants to merge 1 commit into from
Closed

test: remove flaky status from eval_messages test #3420

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 18, 2015

This test has not failed on armv7-wheezy in over 6 weeks. Let's remove its
"flaky" status.

Fixes: #2672

@Trott
test: remove flaky status from eval_messages test
486349c 
This test has not failed on armv7-wheezy in over 6 weeks. Let's remove its
"flaky" status.

Fixes: nodejs#2672
@Trott
Copy link
Member Author

Trott commented Oct 18, 2015

CI: https://ci.nodejs.org/job/node-test-commit/868/

@mscdex mscdex added the test Issues and PRs related to the tests. label Oct 18, 2015
@rvagg
Copy link
Member

rvagg commented Oct 19, 2015

lgtm

@Fishrock123
Copy link
Contributor

LGTM

@orangemocha
Copy link
Contributor

I agree based on the findings you mentioned that this test would be more useful without the flaky status. Even better diligence would be to run this test in a loop and see if the intermittent failures can be reproduced. Locally on a linux box, or in CI with a special test run. I can get to it later this week.

@jasnell
Copy link
Member

jasnell commented Oct 20, 2015

LGTM

Trott added a commit that referenced this pull request Oct 20, 2015
@Trott @jasnell
test: remove flaky status from eval_messages test
7cb89f5 
This test has not failed on armv7-wheezy in over 6 weeks. Let's remove its
"flaky" status.

Fixes: #2672
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #3420
@jasnell
Copy link
Member

jasnell commented Oct 20, 2015

Landed in 7cb89f5

@jasnell jasnell closed this Oct 20, 2015
Trott added a commit that referenced this pull request Oct 21, 2015
@Trott @rvagg
test: remove flaky status from eval_messages test
eef0f0c 
This test has not failed on armv7-wheezy in over 6 weeks. Let's remove its
"flaky" status.

Fixes: #2672
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #3420
@rvagg rvagg mentioned this pull request Oct 21, 2015
Merged
Trott added a commit that referenced this pull request Oct 26, 2015
@Trott @jasnell
test: remove flaky status from eval_messages test
0c23e81 
This test has not failed on armv7-wheezy in over 6 weeks. Let's remove its
"flaky" status.

Fixes: #2672
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #3420
@jasnell
Copy link
Member

jasnell commented Oct 26, 2015

Landed in v4.x-staging in 0c23e81

@rvagg rvagg mentioned this pull request Oct 28, 2015
Closed
Trott added a commit that referenced this pull request Oct 29, 2015
@Trott @jasnell
test: remove flaky status from eval_messages test
eac2acc 
This test has not failed on armv7-wheezy in over 6 weeks. Let's remove its
"flaky" status.

Fixes: #2672
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #3420
@snyk-bot snyk-bot mentioned this pull request Aug 10, 2020
Closed
@Trott Trott deleted the eval_messages branch January 13, 2022 22:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @rvagg @Fishrock123 @orangemocha @jasnell @mscdex