-
-
Notifications
You must be signed in to change notification settings - Fork 170
ansible,jenkins: install and use GCC 10 on ubuntu2004_sharedlibs #3485
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
I'm getting an unrelated error while trying to apply it:
I don't know what to do now.. |
I'm seeing the same error too 😞 |
Wonder if it's related to ansible/ansible#79602 |
It's needed by Ansible to create temporary directories with the correct permissions.
I confirm that installing |
Docker images are now building.
|
That is likely related to the version of Python 3 being used. tap2junit 0.1.6 requires Python 3.7: https://pypi.org/project/tap2junit/. I had to use a non-system Python 3 for RHEL 8, for example, #3306. |
There's another broken docker build with
I'm not sure how to proceed at this point, as the playbook stops because of those two build failures. |
Ah, this one is #3067 (comment) -- zlib only keep the most recent version available to download from https://zlib.net/ but older ones are available on https://www.zlib.net/fossils/. Apparently I updated the docker templates for the Ubuntu 20.04 sharedlibs containers in https://github.com/nodejs/build/pull/3076/files#diff-12b3498626d53cb9267e5ec7cec164c7bf5a3d703c0239277071edac9f3b69da but not the Ubuntu 18.04 based ones. @targos if you like I can take a look at fixing the two failing containers today after lunch. |
That would be awesome. I won't have much more time for this today |
Once zlib releases a new version they remove the older one and move it to https://www.zlib.net/fossils/. Use this more stable URL to fetch the zlib source when building containers.
Current versions of tap2junit require Python > 3.7. The default python3 package on CentOS 7 is Python 3.6.
I've pushed two commits to this PR to fix the issues with the CentOS 7 container and Ubuntu 18.04 sharedlibs container. ansible-playbook --limit test-osuosl-ubuntu2004_docker-arm64-1 ansible/playbooks/jenkins/docker-host.yaml successfully ran to completion with c73b708. @targos FYI we might also need to add ICU 73 to the sharedlib containers (either as part of this PR or a follow-up) in preparation for nodejs/node#49639. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't approve because it's my PR, but @richardlau's commits LGTM. Thanks for the help!
It looks like something's wrong: https://ci.nodejs.org/job/node-test-commit-arm-debug/9398/nodes=ubuntu2004_debug-arm64/console |
|
@targos ah from https://ci.nodejs.org/job/node-test-commit-arm-debug/9398/nodes=ubuntu2004_debug-arm64/injectedEnvVars/ the value of build/jenkins/scripts/select-compiler.sh Line 242 in 12ecb2d
I guess we've actually run into #3485 (comment) 🙂. |
Update to the compiler selector script: #3493 |
Refs: #3317