deps: update V8 to 11.8 #49639

targos · 2023-09-13T14:32:43Z

Notable changes from Node.js 20 (V8 11.3), based on https://chromestatus.com/roadmap:

nodejs-github-bot · 2023-09-13T14:32:48Z

Review requested:

@nodejs/gyp
@nodejs/v8-update

nodejs-github-bot · 2023-09-13T14:33:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53930/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/5562/

nodejs-github-bot · 2023-09-13T14:34:26Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5562/

nodejs-github-bot · 2023-09-13T14:34:50Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5562/

nodejs-github-bot · 2023-09-13T14:37:57Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5562/

targos · 2023-09-13T14:59:00Z

I cherry-picked the fix for compilation on macOS

nodejs-github-bot · 2023-09-14T05:30:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53945/

debadree25 · 2023-09-14T15:41:05Z

The coverage windows job says There is not enough space on the disk. : 'D:\a\_temp\_runner_file_commands\add_path_f4e6d426-3628-4fdb-9b84-b7dc372c0b77' is this a github issue?

targos · 2023-09-15T07:30:40Z

It's becoming critical that someone finds a fix for the zlib error. It happens in two of the builds:

https://ci.nodejs.org/job/node-test-commit-linux-containered/39302/nodes=ubuntu1804_sharedlibs_shared_x64/console

07:43:16 /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/v8_zlib/deps/v8/third_party/zlib/cpu_features.o:(.bss.x86_cpu_enable_avx512+0x0): multiple definition of `x86_cpu_enable_avx512'
07:43:16 /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/zlib/deps/zlib/cpu_features.o:(.bss+0x0): first defined here

https://ci.nodejs.org/job/node-test-commit-smartos/51054/nodes=smartos20-64/console

07:51:39 ld: fatal: symbol 'x86_cpu_enable_avx512' is multiply-defined:
07:51:39 	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/obj.target/deps/zlib/libzlib.a(cpu_features.o) type=OBJT; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/obj.target/tools/v8_gypfiles/libv8_zlib.a(cpu_features.o) type=OBJT);
07:51:39 ld: fatal: symbol 'x86_cpu_enable_avx512' is multiply-defined:
07:51:39 	(file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/obj.target/deps/zlib/libzlib.a(cpu_features.o) type=OBJT; file /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/obj.target/tools/v8_gypfiles/libv8_zlib.a(cpu_features.o) type=OBJT);
07:51:39 ld: fatal: file processing errors. No output written to /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/embedtest

@nodejs/cpp-reviewers @nodejs/tsc

targos · 2023-09-15T07:31:16Z

@nodejs/platform-aix PTAL at this:

https://ci.nodejs.org/job/node-test-commit-aix/48012/nodes=aix72-ppc64/console

07:58:44 ../deps/v8/src/heap/factory.cc: In member function 'v8::internal::Handle<v8::internal::WasmContinuationObject> v8::internal::Factory::NewWasmContinuationObject(v8::internal::Address, v8::internal::Handle<v8::internal::Foreign>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::AllocationType)':
07:58:44 ../deps/v8/src/heap/factory.cc:1921:11: error: 'class v8::internal::WasmContinuationObject' has no member named 'init_jmpbuf'; did you mean 'init___jmpbuf'?
07:58:44  1921 |   result->init_jmpbuf(isolate(), jmpbuf);
07:58:44       |           ^~~~~~~~~~~
07:58:44       |           init___jmpbuf
07:58:44 gmake[2]: *** [tools/v8_gypfiles/v8_base_without_compiler.target.mk:1102: /home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/out/Release/obj.target/v8_base_without_compiler/deps/v8/src/heap/factory.o] Error 1

RaisinTen · 2023-09-15T07:59:39Z

@targos for the first one, does adding static next to the variables in https://github.com/targos/node/blob/763cfa9333be821123cb1b24ef65a02a981604b8/deps/zlib/cpu_features.c#L25-L34 and https://github.com/targos/node/blob/763cfa9333be821123cb1b24ef65a02a981604b8/deps/v8/third_party/zlib/cpu_features.c#L25-L34 like this:

before:

int ZLIB_INTERNAL x86_cpu_enable_avx512 = 0;

after:

static int ZLIB_INTERNAL x86_cpu_enable_avx512 = 0;

fix the issue?

targos · 2023-09-15T08:00:09Z

It seems that a recent push to main breaks this PR. @joyeecheung maybe #48510 ?

/home/runner/work/node/node/out/Release/.deps//home/runner/work/node/node/out/Release/obj.target/libnode/src/node.o.d.raw   -c
In file included from ../deps/v8/include/v8-profiler.h:15,
                 from ../src/memory_tracker.h:5,
                 from ../src/base_object.h:29,
                 from ../src/module_wrap.h:9,
                 from ../src/module_wrap.cc:1:
../deps/v8/include/v8-local-handle.h: In instantiation of ‘v8::Local<T>::Local(v8::Local<S>) [with S = v8::Module; T = v8::Value]’:
../src/module_wrap.cc:61:27:   required from here
../deps/v8/include/v8-local-handle.h:253:42: error: static assertion failed: type check
  253 |     static_assert(std::is_base_of<T, S>::value, "type check");
      |                                          ^~~~~
../deps/v8/include/v8-local-handle.h:253:42: note: ‘std::integral_constant<bool, false>::value’ evaluates to false
make[2]: *** [libnode.target.mk:492: /home/runner/work/node/node/out/Release/obj.target/libnode/src/module_wrap.o] Error 1
make[2]: *** Waiting for unfinished jobs....
rm 9ac559b3661ef3e3ae7143f36ccc6691e578b31c.intermediate 2ad06b2c9baade6b27c5c82cdcc7af11c369378d.intermediate

joyeecheung · 2023-09-15T11:13:53Z

@targos You need both #49491 and #49419 for that to work. I suspect they are not yet in 11.8.

targos · 2023-09-15T12:28:17Z

@RaisinTen static breaks it for me:

[16/3966] CC obj/deps/v8/third_party/zlib/v8_zlib.cpu_features.o
FAILED: obj/deps/v8/third_party/zlib/v8_zlib.cpu_features.o
cc -MMD -MF obj/deps/v8/third_party/zlib/v8_zlib.cpu_features.o.d -D_GLIBCXX_USE_CXX11_ABI=1 -DNODE_OPENSSL_CONF_NAME=nodejs_conf -DNODE_OPENSSL_HAS_QUIC -DICU_NO_USER_DATA_OVERRIDE -DV8_GYP_BUILD -DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=64 -D_DARWIN_USE_64_BIT_INODE=1 -DOPENSSL_NO_PINSHARED -DOPENSSL_THREADS -DV8_TARGET_ARCH_ARM64 -DV8_HAVE_TARGET_OS -DV8_TARGET_OS_MACOS '-DV8_EMBEDDER_STRING="-node.7"' -DENABLE_DISASSEMBLER -DV8_PROMISE_INTERNAL_FIELD_COUNT=1 -DOBJECT_PRINT -DV8_INTL_SUPPORT -DV8_ATOMIC_OBJECT_FIELD_WRITES -DV8_ENABLE_LAZY_SOURCE_POSITIONS -DV8_USE_SIPHASH -DV8_SHARED_RO_HEAP -DV8_WIN64_UNWINDING_INFO -DV8_ENABLE_REGEXP_INTERPRETER_THREADED_DISPATCH -DV8_USE_ZLIB -DV8_ENABLE_TURBOFAN -DV8_ENABLE_SYSTEM_INSTRUMENTATION -DV8_ENABLE_WEBASSEMBLY -DV8_ENABLE_JAVASCRIPT_PROMISE_HOOKS -DV8_ALLOCATION_FOLDING -DV8_ALLOCATION_SITE_TRACKING -DV8_SCRIPTORMODULE_LEGACY_LIFETIME -DV8_ADVANCED_BIGINT_ALGORITHMS -DZLIB_IMPLEMENTATION -I../../deps/v8 -I../../deps/v8/include -I../../deps/v8/third_party/zlib -I../../deps/v8/third_party/zlib/google -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=11.0 -arch arm64 -Wall -Wendif-labels -W -Wno-unused-parameter -Wno-invalid-offsetof -fno-strict-aliasing  -c ../../deps/v8/third_party/zlib/cpu_features.c -o obj/deps/v8/third_party/zlib/v8_zlib.cpu_features.o
../../deps/v8/third_party/zlib/cpu_features.c:28:26: error: static declaration of 'Cr_z_arm_cpu_enable_crc32' follows non-static declaration
static int ZLIB_INTERNAL arm_cpu_enable_crc32 = 0;
                         ^
../../deps/v8/third_party/zlib/chromeconf.h:193:30: note: expanded from macro 'arm_cpu_enable_crc32'
#define arm_cpu_enable_crc32 Cr_z_arm_cpu_enable_crc32
                             ^
../../deps/v8/third_party/zlib/cpu_features.h:12:12: note: previous declaration is here
extern int arm_cpu_enable_crc32;
           ^
../../deps/v8/third_party/zlib/chromeconf.h:193:30: note: expanded from macro 'arm_cpu_enable_crc32'
#define arm_cpu_enable_crc32 Cr_z_arm_cpu_enable_crc32
                             ^
../../deps/v8/third_party/zlib/cpu_features.c:29:26: error: static declaration of 'Cr_z_arm_cpu_enable_pmull' follows non-static declaration
static int ZLIB_INTERNAL arm_cpu_enable_pmull = 0;
                         ^
../../deps/v8/third_party/zlib/chromeconf.h:194:30: note: expanded from macro 'arm_cpu_enable_pmull'
#define arm_cpu_enable_pmull Cr_z_arm_cpu_enable_pmull
                             ^
../../deps/v8/third_party/zlib/cpu_features.h:13:12: note: previous declaration is here
extern int arm_cpu_enable_pmull;
           ^
../../deps/v8/third_party/zlib/chromeconf.h:194:30: note: expanded from macro 'arm_cpu_enable_pmull'
#define arm_cpu_enable_pmull Cr_z_arm_cpu_enable_pmull
                             ^
../../deps/v8/third_party/zlib/cpu_features.c:31:26: error: static declaration of 'Cr_z_x86_cpu_enable_sse2' follows non-static declaration
static int ZLIB_INTERNAL x86_cpu_enable_sse2 = 0;
                         ^
../../deps/v8/third_party/zlib/chromeconf.h:201:29: note: expanded from macro 'x86_cpu_enable_sse2'
#define x86_cpu_enable_sse2 Cr_z_x86_cpu_enable_sse2
                            ^
../../deps/v8/third_party/zlib/cpu_features.h:14:12: note: previous declaration is here
extern int x86_cpu_enable_sse2;
           ^
../../deps/v8/third_party/zlib/chromeconf.h:201:29: note: expanded from macro 'x86_cpu_enable_sse2'
#define x86_cpu_enable_sse2 Cr_z_x86_cpu_enable_sse2
                            ^
../../deps/v8/third_party/zlib/cpu_features.c:32:26: error: static declaration of 'Cr_z_x86_cpu_enable_ssse3' follows non-static declaration
static int ZLIB_INTERNAL x86_cpu_enable_ssse3 = 0;
                         ^
../../deps/v8/third_party/zlib/chromeconf.h:184:30: note: expanded from macro 'x86_cpu_enable_ssse3'
#define x86_cpu_enable_ssse3 Cr_z_x86_cpu_enable_ssse3
                             ^
../../deps/v8/third_party/zlib/cpu_features.h:15:12: note: previous declaration is here
extern int x86_cpu_enable_ssse3;
           ^
../../deps/v8/third_party/zlib/chromeconf.h:184:30: note: expanded from macro 'x86_cpu_enable_ssse3'
#define x86_cpu_enable_ssse3 Cr_z_x86_cpu_enable_ssse3
                             ^
../../deps/v8/third_party/zlib/cpu_features.c:33:26: error: static declaration of 'Cr_z_x86_cpu_enable_simd' follows non-static declaration
static int ZLIB_INTERNAL x86_cpu_enable_simd = 0;
                         ^
../../deps/v8/third_party/zlib/chromeconf.h:180:29: note: expanded from macro 'x86_cpu_enable_simd'
#define x86_cpu_enable_simd Cr_z_x86_cpu_enable_simd
                            ^
../../deps/v8/third_party/zlib/cpu_features.h:16:12: note: previous declaration is here
extern int x86_cpu_enable_simd;
           ^
../../deps/v8/third_party/zlib/chromeconf.h:180:29: note: expanded from macro 'x86_cpu_enable_simd'
#define x86_cpu_enable_simd Cr_z_x86_cpu_enable_simd
                            ^
../../deps/v8/third_party/zlib/cpu_features.c:34:26: error: static declaration of 'x86_cpu_enable_avx512' follows non-static declaration
static int ZLIB_INTERNAL x86_cpu_enable_avx512 = 0;
                         ^
../../deps/v8/third_party/zlib/cpu_features.h:17:12: note: previous declaration is here
extern int x86_cpu_enable_avx512;
           ^
6 errors generated.

nodejs-github-bot · 2023-09-15T13:59:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53965/

nodejs-github-bot · 2023-09-15T13:59:49Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5566/

nodejs-github-bot · 2023-09-15T14:00:12Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5566/

nodejs-github-bot · 2023-09-15T14:04:21Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5566/

joyeecheung · 2023-09-15T14:14:00Z

I am not familiar with the zlib update process (I think there used to be a doc, but I cannot find it any more), but I see that x86_cpu_enable_avx512 is added from https://chromium.googlesource.com/chromium/src/+/refs/heads/main/third_party/zlib/patches/0011-avx512.patch which does not get renamed like other similar flags in chromeconf.h.

Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221 PR-URL: nodejs/node#49639 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221 PR-URL: #49639 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221 PR-URL: nodejs/node#49639 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221 PR-URL: #49639 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221 PR-URL: nodejs/node#49639 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

nodejs/node#49639

* chore: bump Node.js to v22.9.0 * build: drop base64 dep in GN build nodejs/node#52856 * build,tools: make addons tests work with GN nodejs/node#50737 * fs: add fast api for InternalModuleStat nodejs/node#51344 * src: move package_json_reader cache to c++ nodejs/node#50322 * crypto: disable PKCS#1 padding for privateDecrypt nodejs-private/node-private#525 * src: move more crypto code to ncrypto nodejs/node#54320 * crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey nodejs/node#50234 * src: shift more crypto impl details to ncrypto nodejs/node#54028 * src: switch crypto APIs to use Maybe<void> nodejs/node#54775 * crypto: remove DEFAULT_ENCODING nodejs/node#47182 * deps: update libuv to 1.47.0 nodejs/node#50650 * build: fix conflict gyp configs nodejs/node#53605 * lib,src: drop --experimental-network-imports nodejs/node#53822 * esm: align sync and async load implementations nodejs/node#49152 * esm: remove unnecessary toNamespacedPath calls nodejs/node#53656 * module: detect ESM syntax by trying to recompile as SourceTextModule nodejs/node#52413 * test: adapt debugger tests to V8 11.4 nodejs/node#49639 * lib: update usage of always on Atomics API nodejs/node#49639 * test: adapt test-fs-write to V8 internal changes nodejs/node#49639 * test: adapt to new V8 trusted memory spaces nodejs/node#50115 * deps: update libuv to 1.47.0 nodejs/node#50650 * src: use non-deprecated v8::Uint8Array::kMaxLength nodejs/node#50115 * src: update default V8 platform to override functions with location nodejs/node#51362 * src: add missing TryCatch nodejs/node#51362 * lib,test: handle new Iterator global nodejs/node#51362 * src: use non-deprecated version of CreateSyntheticModule nodejs/node#50115 * src: remove calls to recently deprecated V8 APIs nodejs/node#52996 * src: use new V8 API to define stream accessor nodejs/node#53084 * src: do not use deprecated V8 API nodejs/node#53084 * src: do not use soon-to-be-deprecated V8 API nodejs/node#53174 * src: migrate to new V8 interceptors API nodejs/node#52745 * src: use supported API to get stalled TLA messages nodejs/node#51362 * module: print location of unsettled top-level await in entry points nodejs/node#51999 * test: make snapshot comparison more flexible nodejs/node#54375 * test: do not set concurrency on parallelized runs nodejs/node#52177 * src: move FromNamespacedPath to path.cc nodejs/node#53540 * test: adapt to new V8 trusted memory spaces nodejs/node#50115 * build: add option to enable clang-cl on Windows nodejs/node#52870 * chore: fixup patch indices * chore: add/remove changed files * esm: drop support for import assertions nodejs/node#54890 * build: compile with C++20 support nodejs/node#52838 * deps: update nghttp2 to 1.62.1 nodejs/node#52966 * src: parse inspector profiles with simdjson nodejs/node#51783 * build: add GN build files nodejs/node#47637 * deps,lib,src: add experimental web storage nodejs/node#52435 * build: add missing BoringSSL dep * src: rewrite task runner in c++ nodejs/node#52609 * fixup! build: add GN build files * src: stop using deprecated fields of v8::FastApiCallbackOptions nodejs/node#54077 * fix: shadow variable * build: add back incorrectly removed SetAccessor patch * fixup! fixup! build: add GN build files * crypto: fix integer comparison in crypto for BoringSSL * src,lib: reducing C++ calls of esm legacy main resolve nodejs/node#48325 * src: move more crypto_dh.cc code to ncrypto nodejs/node#54459 * chore: fixup GN files for previous commit * src: move more crypto code to ncrypto nodejs/node#54320 * Fixup Perfetto ifdef guards * fix: missing electron_natives dep * fix: node_use_node_platform = false * fix: include src/node_snapshot_stub.cc in libnode * 5507047: [import-attributes] Remove support for import assertions https://chromium-review.googlesource.com/c/v8/v8/+/5507047 * fix: restore v8-sandbox.h in filenames.json * fix: re-add original-fs generation logic * fix: ngtcp2 openssl dep * test: try removing NAPI_VERSION undef * chore(deps): bump @types/node * src: move more crypto_dh.cc code to ncrypto nodejs/node#54459 * esm: remove unnecessary toNamespacedPath calls nodejs/node#53656 * buffer: fix out of range for toString nodejs/node#54553 * lib: rewrite AsyncLocalStorage without async_hooks nodejs/node#48528 * module: print amount of load time of a cjs module nodejs/node#52213 * test: skip reproducible snapshot test on 32-bit nodejs/node#53592 * fixup! src: move more crypto_dh.cc code to ncrypto * test: adjust emittedUntil return type * chore: remove redundant wpt streams patch * fixup! chore(deps): bump @types/node * fix: gn executable name on Windows * fix: build on Windows * fix: rename conflicting win32 symbols in //third_party/sqlite On Windows otherwise we get: lld-link: error: duplicate symbol: sqlite3_win32_write_debug >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:47987 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_sleep >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48042 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_is_nt >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48113 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_unicode >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48470 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_unicode_to_utf8 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48486 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48502 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8_v2 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48518 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48534 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs_v2 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48550 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj * docs: remove unnecessary ts-expect-error after types bump * src: move package resolver to c++ nodejs/node#50322 * build: set ASAN detect_container_overflow=0 nodejs/node#55584 * chore: fixup rebase * test: disable failing ASAN test * win: almost fix race detecting ESRCH in uv_kill libuv/libuv#4341

targos added help wanted Issues that need assistance from volunteers or PRs that need help to proceed. semver-major PRs that contain breaking changes and should be released in the next major version. labels Sep 13, 2023

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Sep 13, 2023

github-actions bot mentioned this pull request Sep 14, 2023

CI Reliability 2023-09-14 nodejs/reliability#665

Open

15 tasks

github-actions bot mentioned this pull request Sep 15, 2023

CI Reliability 2023-09-15 nodejs/reliability#666

Open

13 tasks

targos force-pushed the v8-118 branch from 763cfa9 to 40869f3 Compare September 15, 2023 12:29

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2023

richardlau mentioned this pull request Sep 15, 2023

ansible,jenkins: install and use GCC 10 on ubuntu2004_sharedlibs nodejs/build#3485

Merged

codebytere added a commit to electron/electron that referenced this pull request Oct 16, 2024

test: adapt debugger tests to V8 11.4

6ed6ff2

nodejs/node#49639

codebytere added a commit to electron/electron that referenced this pull request Oct 16, 2024

lib: update usage of always on Atomics API

40373c5

nodejs/node#49639

codebytere added a commit to electron/electron that referenced this pull request Oct 16, 2024

test: adapt test-fs-write to V8 internal changes

69a1cb7

nodejs/node#49639

legendecas mentioned this pull request Oct 17, 2024

Node.js REPL freezes with "while (true);" or "while (true){}" input #54193

Closed

codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024

test: adapt debugger tests to V8 11.4

faa9628

nodejs/node#49639

codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024

lib: update usage of always on Atomics API

74c1038

nodejs/node#49639

codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024

test: adapt test-fs-write to V8 internal changes

3579285

nodejs/node#49639

codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024

test: adapt debugger tests to V8 11.4

8c70412

nodejs/node#49639

codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024

lib: update usage of always on Atomics API

db6fe24

nodejs/node#49639

codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024

test: adapt test-fs-write to V8 internal changes

b84e450

nodejs/node#49639

codebytere added a commit to electron/electron that referenced this pull request Oct 22, 2024

test: adapt debugger tests to V8 11.4

9f66ae8

nodejs/node#49639

codebytere added a commit to electron/electron that referenced this pull request Oct 22, 2024

lib: update usage of always on Atomics API

9726fbc

nodejs/node#49639

codebytere added a commit to electron/electron that referenced this pull request Oct 22, 2024

test: adapt test-fs-write to V8 internal changes

d694964

nodejs/node#49639

joyeecheung mentioned this pull request Oct 26, 2024

Potential startup regression since on Node.js >= 22 nodejs/performance#180

Closed

codebytere added a commit to electron/electron that referenced this pull request Oct 28, 2024

test: adapt debugger tests to V8 11.4

4e6f996

nodejs/node#49639

codebytere added a commit to electron/electron that referenced this pull request Oct 28, 2024

lib: update usage of always on Atomics API

2577c22

nodejs/node#49639

codebytere added a commit to electron/electron that referenced this pull request Oct 28, 2024

test: adapt test-fs-write to V8 internal changes

8425d20

nodejs/node#49639

codebytere added a commit to electron/electron that referenced this pull request Oct 29, 2024

test: adapt debugger tests to V8 11.4

79167c5

nodejs/node#49639

codebytere added a commit to electron/electron that referenced this pull request Oct 29, 2024

lib: update usage of always on Atomics API

99d6164

nodejs/node#49639

codebytere added a commit to electron/electron that referenced this pull request Oct 29, 2024

test: adapt test-fs-write to V8 internal changes

1505f48

nodejs/node#49639

codebytere added a commit to electron/electron that referenced this pull request Oct 31, 2024

test: adapt debugger tests to V8 11.4

c7671da

nodejs/node#49639

codebytere added a commit to electron/electron that referenced this pull request Oct 31, 2024

lib: update usage of always on Atomics API

c78e4b9

nodejs/node#49639

codebytere added a commit to electron/electron that referenced this pull request Oct 31, 2024

test: adapt test-fs-write to V8 internal changes

111129b

nodejs/node#49639

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: update V8 to 11.8 #49639

deps: update V8 to 11.8 #49639

targos commented Sep 13, 2023 •

edited

Loading

nodejs-github-bot commented Sep 13, 2023

nodejs-github-bot commented Sep 13, 2023 •

edited by targos

Loading

nodejs-github-bot commented Sep 13, 2023

nodejs-github-bot commented Sep 13, 2023

nodejs-github-bot commented Sep 13, 2023

targos commented Sep 13, 2023

nodejs-github-bot commented Sep 14, 2023

debadree25 commented Sep 14, 2023

targos commented Sep 15, 2023

targos commented Sep 15, 2023

RaisinTen commented Sep 15, 2023 •

edited

Loading

targos commented Sep 15, 2023

joyeecheung commented Sep 15, 2023

targos commented Sep 15, 2023

nodejs-github-bot commented Sep 15, 2023

nodejs-github-bot commented Sep 15, 2023

nodejs-github-bot commented Sep 15, 2023

nodejs-github-bot commented Sep 15, 2023

joyeecheung commented Sep 15, 2023

deps: update V8 to 11.8 #49639

deps: update V8 to 11.8 #49639

Conversation

targos commented Sep 13, 2023 • edited Loading

nodejs-github-bot commented Sep 13, 2023

nodejs-github-bot commented Sep 13, 2023 • edited by targos Loading

nodejs-github-bot commented Sep 13, 2023

nodejs-github-bot commented Sep 13, 2023

nodejs-github-bot commented Sep 13, 2023

targos commented Sep 13, 2023

nodejs-github-bot commented Sep 14, 2023

debadree25 commented Sep 14, 2023

targos commented Sep 15, 2023

targos commented Sep 15, 2023

RaisinTen commented Sep 15, 2023 • edited Loading

targos commented Sep 15, 2023

joyeecheung commented Sep 15, 2023

targos commented Sep 15, 2023

nodejs-github-bot commented Sep 15, 2023

nodejs-github-bot commented Sep 15, 2023

nodejs-github-bot commented Sep 15, 2023

nodejs-github-bot commented Sep 15, 2023

joyeecheung commented Sep 15, 2023

targos commented Sep 13, 2023 •

edited

Loading

nodejs-github-bot commented Sep 13, 2023 •

edited by targos

Loading

RaisinTen commented Sep 15, 2023 •

edited

Loading