Skip to content

new lint option on windows is missing documentation #11971

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
refack opened this issue Mar 21, 2017 · 7 comments
Closed

new lint option on windows is missing documentation #11971

refack opened this issue Mar 21, 2017 · 7 comments
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.

Comments

@refack
Copy link
Contributor

refack commented Mar 21, 2017 •
edited
Loading

#11856 (review)
/cc @liusy182
New options should be documented in help line (now 420) of vcbuild.bat
@refack refack changed the title no lint option, missing documentation new lint option on windows is missing documentation Mar 21, 2017
@gibfahn gibfahn added the good first issue Issues that are suitable for first-time contributors. label Mar 21, 2017
@gibfahn
Copy link
Member

gibfahn commented Mar 21, 2017 •
edited
Loading

This seems like a good first contribution for someone (@refack if you want to fix it yourself feel free).

@refack
Copy link
Contributor Author

refack commented Mar 21, 2017 •
edited
Loading

Not first! 😛

@gibfahn
Copy link
Member

gibfahn commented Mar 21, 2017 •
edited
Loading

Not first!

@refack not sure what you mean. If you're intending to fix it yourself then go for it, I assumed you weren't planning to, normally people don't bother to raise an Issue first if it's a simple PR.

@refack
Copy link
Contributor Author

refack commented Mar 21, 2017 via email

@refack
Copy link
Contributor Author

refack commented Mar 21, 2017

Ohh, did you mean you wanted to? Sorry 😬. Go ahead! I'm working on something else...

@gibfahn
Copy link
Member

gibfahn commented Mar 21, 2017 •
edited
Loading

@refack good-first-contribution means that this would be a good first contribution for someone who hasn't contributed to node before, not that it is or has to be your first contribution. If someone wants to have a go, then the label means anyone can go ahead ahead and raise a PR. Having some easy issues with that label helps new contributors get started.

I assumed you weren't planning to raise a PR yourself, so added the tag to open it up to anybody. If you're going to fix it then great, please do!

Also I believe even a post-mortem code review helps the original author...

Agreed, not saying you shouldn't raise an issue, just that most people wouldn't bother.

And yeah, I'm following the node-gyp repo, I'm aware that this isn't your first contribution 😄

@Fishrock123 Fishrock123 added the doc Issues and PRs related to the documentations. label Mar 22, 2017
@brennemo
Copy link
Contributor

I'll give this a go as a first contribution.

brennemo added a commit to brennemo/node that referenced this issue Mar 22, 2017
@brennemo
Adds options for cpp linting to help section of Windows build script
ab470d6 
Fixes: nodejs#11971
@brennemo brennemo mentioned this issue Mar 22, 2017
Closed
3 tasks
brennemo added a commit to brennemo/node that referenced this issue Mar 23, 2017
@brennemo
build: add lint option to vcbuild.bat help
73b0204 
Fixes: nodejs#11971
brennemo added a commit to brennemo/node that referenced this issue Mar 23, 2017
@brennemo
build: add lint option to vcbuild.bat help
e52cb17 
Fixes: nodejs#11971
MylesBorins pushed a commit that referenced this issue Mar 28, 2017
@brennemo @MylesBorins
build: add lint option to vcbuild.bat help
fb41ee3 
PR-URL: #11992
Fixes: #11971
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
refack pushed a commit to refack/node that referenced this issue Aug 22, 2017
@brennemo @refack
build: add lint option to vcbuild.bat help
180bec1 
PR-URL: nodejs#11992
Fixes: nodejs#11971
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Sep 19, 2017
@brennemo @MylesBorins
build: add lint option to vcbuild.bat help
c9ae894 
180bec1
PR-URL: #11992
Fixes: #11971
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: adds options for cpp linting to help section of Windows build script brennemo/node
4 participants
@refack @Fishrock123 @gibfahn @brennemo