-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
doc: adds options for cpp linting to help section of Windows build script #11992
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
cc/ @refack |
@brennemo Thank you for the contribution. A nit: it seems the commit title exceed required 50 characters and lacks subsystem prefix (@gibfahn, should it be |
LGTM pending @vsemozhetbyt's comment |
Good point @vsemozhetbyt , @brennemo maybe something like this for the commit message:
Also your name in git is currently:
People usually choose to use their full names for commits. To set your name globally you can do: git config --global user.name "Morgan Brenner" To change the author and commit message you can do: git commit --amend --author="Morgan Brenner <brennemo@oregonstate.edu>"
# Edit commit message when it pops up
git push --force-with-lease |
ab470d6
to
e52cb17
Compare
Sure, I amended the author to add my last name and updated the commit message. |
Landed in a8a042a |
should this be backported? |
I'm +0.1 (it's a tiny documentation change, so little gain little risk) |
PR-URL: nodejs#11992 Fixes: nodejs#11971 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Adds options for cpp linting to help section of Windows build script
Fixes: #11971
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)