Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test: parallel/test-dns-setserver-when-querying is sensitive to network conditions #25664

Closed
joyeecheung opened this issue Jan 23, 2019 · 2 comments
Closed

test: parallel/test-dns-setserver-when-querying is sensitive to network conditions #25664

joyeecheung opened this issue Jan 23, 2019 · 2 comments
Labels
test Issues and PRs related to the tests.

Comments

@joyeecheung
Copy link
Member

joyeecheung commented Jan 23, 2019 •
edited
Loading

  • Version: master
  • Platform: macOS Mojave 10.14
  • Subsystem: test

I have been observing timeout failure of parallel/test-dns-setserver-when-querying quite frequently lately - this seems to be sensitive to network conditions somehow.

# Behind Chinese GFW
> time out/Release/node /Users/joyee/projects/node/test/parallel/test-dns-setserver-when-querying.js
out/Release/node
0.07s user 0.02s system 1% cpu 6.032 total

# After bypassing Chinese GFW
> time out/Release/node /Users/joyee/projects/node/test/parallel/test-dns-setserver-when-querying.js
out/Release/node
0.07s user 0.02s system 38% cpu 0.226 total

From a glance I couldn't tell if this test is actually sending any network requests but from my observation I think it may need to be moved to test/internet?

(Note: this test is using the Google DNS servers to test dns.setServer - the addresses are constant targets of the Chinese GFW)
@joyeecheung joyeecheung added the test Issues and PRs related to the tests. label Jan 23, 2019
Trott added a commit to Trott/io.js that referenced this issue Jan 25, 2019
@Trott
test: replace Google servers with localhost
472dfc1 
Replace Google DNS servers with 127.0.0.1 in
test-dns-setserver-when-querying.

Refs: nodejs#25664
@Trott Trott mentioned this issue Jan 25, 2019
Closed
2 tasks
@Trott
Copy link
Member

Trott commented Jan 25, 2019

Maybe just change goog to [ '127.0.0.1' ] (and rename it to localhost)? Test would still seem to be valid in that situation.

PR to do exactly that: #25694

Trott added a commit to Trott/io.js that referenced this issue Jan 27, 2019
@Trott
test: replace Google servers with localhost
6d937c0 
Replace Google DNS servers with 127.0.0.1 in
test-dns-setserver-when-querying.

Refs: nodejs#25664

PR-URL: nodejs#25694
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member

Trott commented Jan 27, 2019

Fixed in 6d937c0, I believe. (Re-open if I'm wrong, of course!)

@Trott Trott closed this as completed Jan 27, 2019
addaleax pushed a commit that referenced this issue Jan 28, 2019
@Trott @addaleax
test: replace Google servers with localhost
190c063 
Replace Google DNS servers with 127.0.0.1 in
test-dns-setserver-when-querying.

Refs: #25664

PR-URL: #25694
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this issue Apr 16, 2019
@Trott @BethGriggs
test: replace Google servers with localhost
3fab8be 
Replace Google DNS servers with 127.0.0.1 in
test-dns-setserver-when-querying.

Refs: #25664

PR-URL: #25694
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Trott @joyeecheung