test: replace Google servers with localhost #25694
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace Google DNS servers with 127.0.0.1 in test-dns-setserver-when-querying. Refs: nodejs#25664
targos
approved these changes
Jan 25, 2019
cjihrig
approved these changes
Jan 25, 2019
lpinca
approved these changes
Jan 26, 2019
|
Now that the pesky test-performance issue has been resolved, let's re-run CI: |
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/20339/ ✅ |
Trott
added
the
author ready
|
Landed in 6d937c0 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 27, 2019
Replace Google DNS servers with 127.0.0.1 in test-dns-setserver-when-querying. Refs: nodejs#25664 PR-URL: nodejs#25694 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jan 28, 2019
Replace Google DNS servers with 127.0.0.1 in test-dns-setserver-when-querying. Refs: #25664 PR-URL: #25694 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 16, 2019
Replace Google DNS servers with 127.0.0.1 in test-dns-setserver-when-querying. Refs: #25664 PR-URL: #25694 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This was referenced May 29, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace Google DNS servers with 127.0.0.1 in
test-dns-setserver-when-querying.
Refs: #25664
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes