-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
build: addon tests need more descriptive names than test.js #6651
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Labels
test
Issues and PRs related to the tests.
Comments
Actually stringbytes-external-exceed-max has tests in the form |
#6653 for a potential fix. |
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this issue
May 13, 2016
Print test name as (for example) "parallel/test-assert". Tests that are scraped from the addons documentation are all named test.js, making it hard to decipher what test is running when only the filename is printed. Fixes: nodejs#6651 PR-URL: nodejs#6653 Reviewed-By: James M Snell <jasnell@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
When looking at test failures, the only way to identify which test failed is by the name. Unfortunately all the tests in the addons folder are called
test.js
, which leads to unhelpful output (see below).Currently it looks like there is only one test.js file in each folder in test/addons, so the simplest solution would be to name each test
$ADDON_NAME-test.js
. If that makes sense I can open a PR to do it.Sample output from the community CI
The text was updated successfully, but these errors were encountered: