-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
test: include component in tap output #6653
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
idea sgtm but won't review python XD |
@bnoordhuis Does the node-test-commit not use the new tools/test.py? Seems to still be test.js for the addons. https://ci.nodejs.org/job/node-test-commit-linux/nodes=ubuntu1404-64/3282/console |
It's possible the buildbots aren't actually testing the change in this PR; looking at other runs, they seem to be having connectivity issues. It's working for me locally:
|
Makes sense, your change works manually for me as well. |
LGTM |
I decided we could do a little better still for nested directories so PTAL. Before, it printed:
Now it prints:
|
@jasnell Can I ask you to give this a quick look again? The changes since the last review are in the second commit (not that the total diff is that huge: +9 −1.) |
Still LGTM |
Print test name as (for example) "parallel/test-assert". Tests that are scraped from the addons documentation are all named test.js, making it hard to decipher what test is running when only the filename is printed. Fixes: nodejs#6651 PR-URL: nodejs#6653 Reviewed-By: James M Snell <jasnell@gmail.com>
Commit 084b2ec ("test: include component in tap output") introduced an in hindsight glaringly obvious but fortunately not very critical Windows-specific bug by failing to take the path separator into account. This commit rectifies that, the prefix is now correctly stripped. PR-URL: nodejs#6915 Refs: nodejs#6653 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Commit 084b2ec ("test: include component in tap output") introduced an in hindsight glaringly obvious but fortunately not very critical Windows-specific bug by failing to take the path separator into account. This commit rectifies that, the prefix is now correctly stripped. PR-URL: #6915 Refs: #6653 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Commit 084b2ec ("test: include component in tap output") introduced an in hindsight glaringly obvious but fortunately not very critical Windows-specific bug by failing to take the path separator into account. This commit rectifies that, the prefix is now correctly stripped. PR-URL: #6915 Refs: #6653 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Commit 084b2ec ("test: include component in tap output") introduced an in hindsight glaringly obvious but fortunately not very critical Windows-specific bug by failing to take the path separator into account. This commit rectifies that, the prefix is now correctly stripped. PR-URL: #6915 Refs: #6653 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Commit 084b2ec ("test: include component in tap output") introduced an in hindsight glaringly obvious but fortunately not very critical Windows-specific bug by failing to take the path separator into account. This commit rectifies that, the prefix is now correctly stripped. PR-URL: #6915 Refs: #6653 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Commit 084b2ec ("test: include component in tap output") introduced an in hindsight glaringly obvious but fortunately not very critical Windows-specific bug by failing to take the path separator into account. This commit rectifies that, the prefix is now correctly stripped. PR-URL: #6915 Refs: #6653 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Commit 084b2ec ("test: include component in tap output") introduced an in hindsight glaringly obvious but fortunately not very critical Windows-specific bug by failing to take the path separator into account. This commit rectifies that, the prefix is now correctly stripped. PR-URL: #6915 Refs: #6653 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Commit 084b2ec ("test: include component in tap output") introduced an in hindsight glaringly obvious but fortunately not very critical Windows-specific bug by failing to take the path separator into account. This commit rectifies that, the prefix is now correctly stripped. PR-URL: #6915 Refs: #6653 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Commit 084b2ec ("test: include component in tap output") introduced an in hindsight glaringly obvious but fortunately not very critical Windows-specific bug by failing to take the path separator into account. This commit rectifies that, the prefix is now correctly stripped. PR-URL: #6915 Refs: #6653 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Print test name as (for example) "parallel/test-assert". Tests that are
scraped from the addons documentation are all named test.js, making it
hard to decipher what test is running when only the filename is printed.
Fixes: #6651
CI: https://ci.nodejs.org/job/node-test-pull-request/2547/