-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
v6.4.0 Release Proposal #8020
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
#7111 is, unfortunately a semver-major because of the ABI change. Given that, we technically can't land it here. |
Do the |
hmm.. ok, perhaps then just opening a new backport PR with those combined that can be reviewed separately as a semver-minor against v6.x? |
SGTM, I’ll do that. (edit: #8022) |
Wait, haven't we already gotten that? Are you sure this is correct? |
I pulled it back from v6.3.1 iirc. Something about it breaking the installer |
Also, running with |
@evanlucas is it good to go, as of #7798?
I would never be sure of such a thing :-) That's why I included the command I ran, in case anyone wanted to double check. |
@cjihrig tbh, I'm not sure. It looks like the translations require a nightly version of Wix? If so, not sure if we should just hold off until it actually supports the translations or not? |
OK, thanks. I'm going to hold it out unless someone confirms otherwise. |
I guess Trevor’s signoff on it is the best I can get right now anyway, so yeah, I’m landing it. |
There are currently three outstanding items:
|
I think we should include #7796 as it updates the license. We have a fix in-flight upstream https://codereview.chromium.org/2235753003/ that fixes the issue w/ landing on |
Leaving it out is fine. It's not important, just some refactoring. |
It looks like the fix in https://codereview.chromium.org/2235753003/ may have landed already. |
Yea, I'm fine with cherry-picking the broken update and the new update both back to v6.x. |
In respect to #7796 we absolutely need to the license update as its prevented us from shipping/consuming (within IBM) 6.x in the last few releases. I believe we should wait until we get the license issue resolved. |
Notable changes: * build: zlib symbols and additional OpenSSL symbols are now exposed on Windows platforms. (Alex Hultman) #7983 and #7576 * child_process, cluster: Forked child processes and cluster workers now support stdio configuration. (Colin Ihrig) #7811 and #7838 * fs: fs.ReadStream now exposes the number of bytes it has read so far. (Linus Unnebäck) #7942 * repl: The REPL now supports editor mode. (Prince J Wesley) #7275 * util: inspect() can now be configured globally using util.inspect.defaultOptions. (Roman Reiss) #8013 Refs: #8020 PR-URL: #8070
Moving this to the actual PR (#8070). |
Notable changes: * build: zlib symbols and additional OpenSSL symbols are now exposed on Windows platforms. (Alex Hultman) #7983 and #7576 * child_process, cluster: Forked child processes and cluster workers now support stdio configuration. (Colin Ihrig) #7811 and #7838 * child_process: argv[0] can now be set to arbitrary values in spawned processes. (Pat Pannuto) #7696 * fs: fs.ReadStream now exposes the number of bytes it has read so far. (Linus Unnebäck) #7942 * repl: The REPL now supports editor mode. (Prince J Wesley) #7275 * util: inspect() can now be configured globally using util.inspect.defaultOptions. (Roman Reiss) #8013 Refs: #8020 PR-URL: #8070
Notable changes: * build: zlib symbols and additional OpenSSL symbols are now exposed on Windows platforms. (Alex Hultman) #7983 and #7576 * child_process, cluster: Forked child processes and cluster workers now support stdio configuration. (Colin Ihrig) #7811 and #7838 * child_process: argv[0] can now be set to arbitrary values in spawned processes. (Pat Pannuto) #7696 * fs: fs.ReadStream now exposes the number of bytes it has read so far. (Linus Unnebäck) #7942 * repl: The REPL now supports editor mode. (Prince J Wesley) #7275 * util: inspect() can now be configured globally using util.inspect.defaultOptions. (Roman Reiss) #8013 Refs: #8020 PR-URL: #8070
Notable changes: * build: zlib symbols and additional OpenSSL symbols are now exposed on Windows platforms. (Alex Hultman) nodejs#7983 and nodejs#7576 * child_process, cluster: Forked child processes and cluster workers now support stdio configuration. (Colin Ihrig) nodejs#7811 and nodejs#7838 * child_process: argv[0] can now be set to arbitrary values in spawned processes. (Pat Pannuto) nodejs#7696 * fs: fs.ReadStream now exposes the number of bytes it has read so far. (Linus Unnebäck) nodejs#7942 * repl: The REPL now supports editor mode. (Prince J Wesley) nodejs#7275 * util: inspect() can now be configured globally using util.inspect.defaultOptions. (Roman Reiss) nodejs#8013 Refs: nodejs#8020 PR-URL: nodejs#8070
Here are the commits, as determined by
branch-diff v6.x master --exclude-label=semver-major,dont-land-on-v6.x --filter-release
:e925b62771
] - doc: fix cluster message event docs (Zach Bjornson) #80174c62892a4b
] - test: console constructor missing new keyword (Rich Trott) #80038726a1c318
] - tools: enable linting for chained properties (Rich Trott) #7999e313c0286b
] - tools: update to ESLint 3.2.2 (Rich Trott) #799949e473a45f
] - test: fix failing inspector cctest (Eugene Ostroukhov) #8019c628982a06
] - doc: addadded:
information for cluster (Anna Henningsen) #7640ae25ed3ccd
] - benchmark: favor === over == (Rich Trott) #80001b99093df7
] - timers: remove unused repeat param in timer_wrap (Jan Schär) #7994dabac8a2fb
] - doc: remove spurious new line in CHANGELOG_V6.md (Luigi Pinca) #80091a6a69a8e0
] - (SEMVER-MINOR) util: add inspect.defaultOptions (Roman Reiss) #8013a8438a0438
] - test,assert: add deepEqual/deepStrictEqual tests for typed arrays (Feross Aboukhadijeh) #8002387ab62939
] - assert: fix deepEqual/deepStrictEqual on equivalent typed arrays (Feross Aboukhadijeh) #8002bb3b4d7d49
] - doc: fix typo in vm.runInNewContext() description (Luigi Pinca) #8005a7222052d4
] - build: add correct shared library naming on OS X (Stewart Addison) #7687e03a7b2a2b
] - build: turn on thin static archives (Ben Noordhuis) #795755852e1421
] - module: fix node_modules search path in edge case (hefangshi) #66705111e789e6
] - deps: float gyp patch for long filenames (Anna Henningsen) #7963eb172feebf
] - doc: Clean up roff source in manpage (Alhadis) #78194a87abb8e8
] - (SEMVER-MINOR) fs: add bytesRead to ReadStream (Linus Unnebäck) #7942f59b8888f1
] - repl: disable Ctrl+C support on win32 for now (Anna Henningsen) #797743ef58005e
] - src: remove unused using decls (Haojian Wu) #7990827eed1ce3
] - doc: add CTC meeting minutes 2016-08-03 (Josh Gavant) #798035109ddaf2
] - lib: remove double check of string type (Franziska Hinkelmann) #7985accaa34377
] - doc: clarify collaborators & ctc members relationships (yorkie) #79962d4a521d58
] - repl: don't override all internal repl defaults (cjihrig) #7826f18b1c91b8
] - test: allow globals to be whitelisted (cjihrig) #782699f45b2476
] - (SEMVER-MINOR) child_process: control argv0 for spawned processes (Pat Pannuto) #7696a804db1af7
] - (SEMVER-MINOR) process: save original argv[0] (Pat Pannuto) #7696beea23af65
] - doc: clarify fd closing byfs.readFile
etc. (kibertoad) #7561359352c9e9
] - (SEMVER-MINOR) build: export zlib symbols on Windows (Alex Hultman) #7983be73480eec
] - test: fix flaky test-vm-sigint-existing-handler (Anna Henningsen) #7982b635f7b0e7
] - zlib: remove unneeded property (Jan Schär) #79874c86fa30d8
] - doc: fix a markdown error in CTC meeting minutes (Сковорода Никита Андреевич) #7729d997448ea6
] - tools: add remark-lint configuration in .remarkrc (Сковорода Никита Андреевич) #7729b779eb423d
] - (SEMVER-MINOR) repl: Add editor mode support (Prince J Wesley) #7275769f63ccd8
] - doc: addadded:
information for events (Luigi Pinca) #782266af6a9028
] - doc: improve server.listen() random port (Phillip Johnsen) #79765d6d3ee5fb
] - doc: clarify "Reviewed-By" iff "LGTM" (Bryan English) #71839a0d26fa43
] - test: remove internal headers from addons (Gibson Fahnestock) #79471e1bbe5af7
] - tools: add .vscode folder to .gitignore (Josh Gavant) #7967b866fdc516
] - doc: add CTC meeting minutes 2016-07-13 (Josh Gavant) #79682458bdb1f0
] - doc: add CTC meeting minutes 2016-07-20 (Josh Gavant) #7970ff7a841f4d
] - src: make EnvDelete behave like the delete operator (Franziska Hinkelmann) #7975cc3a9e7947
] - doc: use consistent markdown in README (Rich Trott) #797199296eedbe
] - http: specify _implicitHeader in OutgoingMessage (yorkie) #79490f3f76cada
] - doc: usegit-secure-tag
for release tags (Fedor Indutny) #7603e3e3588e0e
] - meta: clarify process for breaking changes (Rich Trott) #7955c809b88345
] - doc: use blockquotes for Stability: markers (Anna Henningsen) #7757561958e565
] - doc: fix default encoding mention in crypto.md (hugnosis) #7805588ee2296a
] - src: do not copy on failing setProperty() (Franziska Hinkelmann) #7908a52b1c0580
] - doctool: improve the title of pages in doc (yorkie) #7939(deps: cherry-pick 6f68f30 from v8 upstream #7802)
c5a18e748d
] - _Revert_ "fs: validate args of truncate functions in js" (Myles Borins) #7950320f433dcd
] - util: support classes in util.deprecate() (vladimir) #7690e1643ccc5a
] - doc: fix minor formatting issue in 0.10 changelog (Сковорода Никита Андреевич) #7727f3f5a89a10
] - doc: *.md formatting fixes in the benchmark dir (Сковорода Никита Андреевич) #7727fc11fe8e5d
] - doc: remove extra indentation in iojs changelog (Сковорода Никита Андреевич) #77274aa8120aea
] - doc: *.md formatting fixes in the top-level dir (Сковорода Никита Андреевич) #77279ddc915a9c
] - doc: convert tabs to spaces (Сковорода Никита Андреевич) #77277400a4a3bd
] - doc: piscisaureus has stepped-down from the CTC (James M Snell) #79690c73685273
] - doc: add @addaleax to the CTC (Anna Henningsen) #7966c9e670ea2a
] - win,msi: fix inclusion of translations (João Reis) #779805c15a057f
] - build: fix dependency on missing header file (Ben Noordhuis) #7945c0676f3f0f
] - build: fix typo in non-essential source file name (Ben Noordhuis) #7945b4258bba11
] - test: improve chained property readability (Rich Trott) #792093ac2ea36e
] - test: fix test-vm-sigint flakiness (Santiago Gimeno) #78541b24b37299
] - util: fix formatting of objects with SIMD enabled (Anna Henningsen) #786480b10b4fe2
] - src: fix use-after-free in inspector agent (Ben Noordhuis) #790775c6d9dd95
] - (SEMVER-MINOR) cluster: support stdio option for workers (cjihrig) #78386d9a500064
] - doc: add CTC meeting minutes 2016-06-22 (Josh Gavant) #7390681736183c
] - doc: add CTC meeting minutes 2016-07-06 (Josh Gavant) #757059fd48e5b3
] - doc: add CTC meeting minutes 2016-06-29 (Josh Gavant) #75711495053046
] - meta: include a minimal CTC removal policy (Rich Trott) #7720eeaff74af2
] - build: adding config.gypi dep to addons/.buildstamp (Daniel Bevenius) #78938ae227c971
] - doc: add CTC meeting minutes 2016-07-27 (William Kapke) #7900c52a9730b8
] - test: don't hard code deprecation count (Prince J Wesley) #792765a42ab892
] - doc: fix path markdown formatting (Joey Cozza) #78176945aa7085
] - build: don't link against liblog on host system (Ben Noordhuis) #7762c8c1f96abe
] - src: avoid manual memory management in inspector (Ben Noordhuis) #79060190db44ac
] - test: fix memory leaks in inspector tests (Ben Noordhuis) #79061658297f47
] - doc: add missing semicolon (Ravindra barthwal) #79150de55d864d
] - test: decrease inconsistency in the common.js (Vse Mozhet Byt) #7758df4ef63aa5
] - tools,test: show signal code when test crashes (Santiago Gimeno) #7859bc464a8a3b
] - test: fix flaky test-tls-wrap-timeout (Rich Trott) #7857f789eb3106
] - inspector: Do not crash if the port is n/a (Eugene Ostroukhov) #78747d75338c0e
] - timers: fix cleanup of nested same-timeout timers (Erin Spiceland) #78271896ca9e8e
] - doc: fill in missing V8 version (Timothy Gu) #78786ea8c669df
] - doc: remove extra spaces and concats in examples (Joe Esposito) #78858fbdfb9c4e
] - test: speed up test-net-reconnect-error (Rich Trott) #788699e2d43801
] - meta: provide example activities (Rich Trott) #774496611d097a
] - doc: add information about CTC quorum rules (Rich Trott) #7813b896057109
] - src: unifying PipeConnectWrap and TCPConnectWrap (Daniel Bevenius) #7501c948877688
] - doc: align breakEvalOnSigint - repl option (Prince J Wesley) #7849868638b903
] - doc: remove platform assumption from CONTRIBUTING (Bethany N Griggs) #778368ac0d0d7d
] - (SEMVER-MINOR) repl: Use displayErrors for SyntaxError (Prince J Wesley) #75892554549ab5
] - deps: v8_inspector: remove jinja2 tests (Ali Ijaz Sheikh) #77967db495ab6d
] - doc: update licenses (Ali Ijaz Sheikh) #77963534600185
] - tools: update license-builder.sh for v8_inspector (Ali Ijaz Sheikh) #77964be6271c43
] - deps: remove jinja.el from deps/v8_inspector (Ali Ijaz Sheikh) #7796b9445bfecd
] - deps: update v8_inspector (Ali Ijaz Sheikh) #7796ea725eda42
] - test: ensure stream preprocessing order (Vse Mozhet Byt) #77411d83013d19
] - doc: minor typo fixes in stream docs (Alex Perkins) #776334d58ce334
] - src: Only use TR1 type_traits on OSX<10.9 (Ehsan Akhgari) #7778dee0e3a333
] - test: use common platform helpers everywhere (Santiago Gimeno) #7845e22ffefff2
] - deps: cherry-pick a76d133 from v8 upstream (Matt Loring) #7689a3d62bdbaa
] - deps: cherry-pick b93c80a from v8 upstream (Matt Loring) #7689809aabcc13
] - src: fix build on CentOS (Rich Trott) #787346633934fe
] - src: pull OnConnection from pipe_wrap and tcp_wrap (Daniel Bevenius) #7547b3127df59a
] - doc: add/fix version metadata for Buffer methods (Brian White) #7784ac57089960
] - doc: improve function parameter descriptions (Brian White) #77843f208c70da
] - doc: add missing properties in Buffer docs (Brian White) #778487a097da51
] - doc: improve wording and style of Buffer docs (Brian White) #7784cc1318b5ed
] - doc: improve links in Buffer docs (Brian White) #7784344cac112b
] - doc: reorganize Buffer link references (Brian White) #7784fe89848dc6
] - doc: improve Buffer code examples (Brian White) #7784ff3ce11894
] - (SEMVER-MINOR) child_process: support stdio option in fork() (cjihrig) #7811814b8c3cf7
] - test: handle IPv6 localhost issues within tests (Rich Trott) #7766a58b48bc3b
] - doc: various documentation formatting fixes (Сковорода Никита Андреевич) #7637a2a711a373
] - (SEMVER-MINOR) dgram: generalized send queue to handle close (Matteo Collina) #7066c01d61af59
] - win,msi: Added Italian translation (Matteo Collina) #4647b8b8c36b6a
] - (SEMVER-MINOR) build: export more openssl symbols on Windows (Alex Hultman) #75762d77cba7e7
] - test: fix flaky test-*-connect-address-family (Rich Trott) #7605c9f6776d2b
] - (SEMVER-MINOR) crypto: fix undefined behavior in ParseExtension (Fedor Indutny) #749446f40cfb4c
] - (SEMVER-MINOR) buffer: fix unintended unsigned overflow (Fedor Indutny) #74949fbe456db1
] - (SEMVER-MINOR) repl: add support for custom completions (Diosney Sarmiento) #752718ae74cf98
] - src: suppress coverity message (cjihrig) #7587630096bc80
] - src: guard against overflow in ParseArrayIndex() (Ben Noordhuis) #74976ae20433c9
] - src: move ParseArrayIndex() to src/node_buffer.cc (Ben Noordhuis) #7497781713d5ef
] - src: remove unused isolate member (Ben Noordhuis) #7334The text was updated successfully, but these errors were encountered: