Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: prepare test/testpy/__init__.py for Python 3 #24794

Closed

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 3, 2018

label: python

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 3, 2018
@Trott
Copy link
Member

Trott commented Dec 6, 2018

@Trott
Copy link
Member

Trott commented Dec 6, 2018

@Trott
Copy link
Member

Trott commented Dec 7, 2018

@Trott
Copy link
Member

Trott commented Dec 7, 2018

@Trott
Copy link
Member

Trott commented Dec 7, 2018

@Trott
Copy link
Member

Trott commented Dec 7, 2018

@Trott
Copy link
Member

Trott commented Dec 10, 2018

@Trott
Copy link
Member

Trott commented Dec 10, 2018

@danbev
Copy link
Contributor

danbev commented Dec 11, 2018

Re-run of failing node-test-commit-aix 🛑
Re-run of failing node-test-commit-aix

@Trott
Copy link
Member

Trott commented Dec 11, 2018

"Force a rebuild"? Should we force push that commit out? Or is it valid?

@cclauss
Copy link
Contributor Author

cclauss commented Dec 11, 2018

The code is valid. Ship it!

@Trott
Copy link
Member

Trott commented Dec 11, 2018

New CI since we have a new commit AND we've marked that pesky test-cli-syntax as unreliable: https://ci.nodejs.org/job/node-test-pull-request/19431/

@cclauss cclauss force-pushed the Py3-for-test_testpy___init__.py branch from cc4a722 to dda7ca5 Compare December 12, 2018 21:03
@cclauss
Copy link
Contributor Author

cclauss commented Dec 14, 2018

Duplicate: This change has already landed in #24954

@cclauss cclauss closed this Dec 14, 2018
@cclauss cclauss deleted the Py3-for-test_testpy___init__.py branch December 14, 2018 04:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants