Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test: from functools import reduce in test/testpy/__init__.py #24954

Closed
wants to merge 1 commit into from
Closed

test: from functools import reduce in test/testpy/__init__.py #24954

wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 11, 2018 •
edited
Loading

Fixes #23659 !!!

$ make lint-py # When run on Python 3

PYTHONPATH=tools/pip python -m flake8 . \
		--count --show-source --statistics --select=E901,E999,F821,F822,F823 \
		--exclude=.git,deps,lib,src,tools/*_macros.py,tools/gyp,tools/inspector_protocol,tools/jinja2,tools/markupsafe,tools/pip
./test/testpy/__init__.py:119:37: F821 undefined name 'reduce'
        file_path = join(self.root, reduce(join, test[1:], ""))
                                    ^
./test/testpy/__init__.py:161:37: F821 undefined name 'reduce'
        file_path = join(self.root, reduce(join, test[1:], "") + ".js")
                                    ^
2     F821 undefined name 'reduce'
2
make: *** [lint-py] Error 1
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

test: from functools import reduce in test/testpy/__init__.py
d052483 
$ __make lint-py__  # When run on Python 3
```
PYTHONPATH=tools/pip python -m flake8 . \
		--count --show-source --statistics --select=E901,E999,F821,F822,F823 \
		--exclude=.git,deps,lib,src,tools/*_macros.py,tools/gyp,tools/inspector_protocol,tools/jinja2,tools/markupsafe,tools/pip
./test/testpy/__init__.py:119:37: F821 undefined name 'reduce'
        file_path = join(self.root, reduce(join, test[1:], ""))
                                    ^
./test/testpy/__init__.py:161:37: F821 undefined name 'reduce'
        file_path = join(self.root, reduce(join, test[1:], "") + ".js")
                                    ^
2     F821 undefined name 'reduce'
2
make: *** [lint-py] Error 1
```
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 11, 2018
@cclauss cclauss mentioned this pull request Dec 11, 2018
Closed
@Trott
Copy link
Member

Trott commented Dec 11, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19432/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 11, 2018
@addaleax
Copy link
Member

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19447/

@Trott
Copy link
Member

Trott commented Dec 12, 2018 •
edited
Loading

I think the ARM issue might require q Rebuild instead of a Resume? CI: https://ci.nodejs.org/job/node-test-pull-request/19453/ ✔️

@Trott
Copy link
Member

Trott commented Dec 14, 2018

Landed in 7ee61fb

@Trott Trott closed this Dec 14, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 14, 2018
@Trott
test: from functools import reduce in test/testpy/__init__.py
7ee61fb 
$ __make lint-py__  # When run on Python 3
```
PYTHONPATH=tools/pip python -m flake8 . \
		--count --show-source --statistics --select=E901,E999,F821,F822,F823 \
		--exclude=.git,deps,lib,src,tools/*_macros.py,tools/gyp,tools/inspector_protocol,tools/jinja2,tools/markupsafe,tools/pip
./test/testpy/__init__.py:119:37: F821 undefined name 'reduce'
        file_path = join(self.root, reduce(join, test[1:], ""))
                                    ^
./test/testpy/__init__.py:161:37: F821 undefined name 'reduce'
        file_path = join(self.root, reduce(join, test[1:], "") + ".js")
                                    ^
2     F821 undefined name 'reduce'
2
make: *** [lint-py] Error 1
```

PR-URL: nodejs#24954
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@cclauss cclauss deleted the patch-1 branch December 14, 2018 03:52
This was referenced Dec 14, 2018
Closed
Closed
BethGriggs pushed a commit that referenced this pull request Dec 17, 2018
@BethGriggs
test: from functools import reduce in test/testpy/__init__.py
649a728 
$ __make lint-py__  # When run on Python 3
```
PYTHONPATH=tools/pip python -m flake8 . \
		--count --show-source --statistics --select=E901,E999,F821,F822,F823 \
		--exclude=.git,deps,lib,src,tools/*_macros.py,tools/gyp,tools/inspector_protocol,tools/jinja2,tools/markupsafe,tools/pip
./test/testpy/__init__.py:119:37: F821 undefined name 'reduce'
        file_path = join(self.root, reduce(join, test[1:], ""))
                                    ^
./test/testpy/__init__.py:161:37: F821 undefined name 'reduce'
        file_path = join(self.root, reduce(join, test[1:], "") + ".js")
                                    ^
2     F821 undefined name 'reduce'
2
make: *** [lint-py] Error 1
```

PR-URL: #24954
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
Merged
@beevelop beevelop mentioned this pull request Dec 18, 2018
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@refack
test: from functools import reduce in test/testpy/__init__.py
5a6cc6a 
$ __make lint-py__  # When run on Python 3
```
PYTHONPATH=tools/pip python -m flake8 . \
		--count --show-source --statistics --select=E901,E999,F821,F822,F823 \
		--exclude=.git,deps,lib,src,tools/*_macros.py,tools/gyp,tools/inspector_protocol,tools/jinja2,tools/markupsafe,tools/pip
./test/testpy/__init__.py:119:37: F821 undefined name 'reduce'
        file_path = join(self.root, reduce(join, test[1:], ""))
                                    ^
./test/testpy/__init__.py:161:37: F821 undefined name 'reduce'
        file_path = join(self.root, reduce(join, test[1:], "") + ".js")
                                    ^
2     F821 undefined name 'reduce'
2
make: *** [lint-py] Error 1
```

PR-URL: nodejs#24954
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@BethGriggs
test: from functools import reduce in test/testpy/__init__.py
0658424 
$ __make lint-py__  # When run on Python 3
```
PYTHONPATH=tools/pip python -m flake8 . \
		--count --show-source --statistics --select=E901,E999,F821,F822,F823 \
		--exclude=.git,deps,lib,src,tools/*_macros.py,tools/gyp,tools/inspector_protocol,tools/jinja2,tools/markupsafe,tools/pip
./test/testpy/__init__.py:119:37: F821 undefined name 'reduce'
        file_path = join(self.root, reduce(join, test[1:], ""))
                                    ^
./test/testpy/__init__.py:161:37: F821 undefined name 'reduce'
        file_path = join(self.root, reduce(join, test[1:], "") + ".js")
                                    ^
2     F821 undefined name 'reduce'
2
make: *** [lint-py] Error 1
```

PR-URL: #24954
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@BethGriggs
test: from functools import reduce in test/testpy/__init__.py
17e02de 
$ __make lint-py__  # When run on Python 3
```
PYTHONPATH=tools/pip python -m flake8 . \
		--count --show-source --statistics --select=E901,E999,F821,F822,F823 \
		--exclude=.git,deps,lib,src,tools/*_macros.py,tools/gyp,tools/inspector_protocol,tools/jinja2,tools/markupsafe,tools/pip
./test/testpy/__init__.py:119:37: F821 undefined name 'reduce'
        file_path = join(self.root, reduce(join, test[1:], ""))
                                    ^
./test/testpy/__init__.py:161:37: F821 undefined name 'reduce'
        file_path = join(self.root, reduce(join, test[1:], "") + ".js")
                                    ^
2     F821 undefined name 'reduce'
2
make: *** [lint-py] Error 1
```

PR-URL: #24954
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@rvagg
test: from functools import reduce in test/testpy/__init__.py
f903686 
$ __make lint-py__  # When run on Python 3
```
PYTHONPATH=tools/pip python -m flake8 . \
		--count --show-source --statistics --select=E901,E999,F821,F822,F823 \
		--exclude=.git,deps,lib,src,tools/*_macros.py,tools/gyp,tools/inspector_protocol,tools/jinja2,tools/markupsafe,tools/pip
./test/testpy/__init__.py:119:37: F821 undefined name 'reduce'
        file_path = join(self.root, reduce(join, test[1:], ""))
                                    ^
./test/testpy/__init__.py:161:37: F821 undefined name 'reduce'
        file_path = join(self.root, reduce(join, test[1:], "") + ".js")
                                    ^
2     F821 undefined name 'reduce'
2
make: *** [lint-py] Error 1
```

PR-URL: #24954
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3 compatibility issues
7 participants
@cclauss @Trott @addaleax @richardlau @BridgeAR @BethGriggs @nodejs-github-bot