fs: Use constant kWriteFileMaxChunkSize #32640
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
fs
addaleax
approved these changes
Apr 3, 2020
jasnell
approved these changes
Apr 3, 2020
cjihrig
approved these changes
Apr 3, 2020
awibox
approved these changes
Apr 4, 2020
devnexen
approved these changes
Apr 7, 2020
|
looks like the CI error has nothing to do with PR. What can I do to allow landing ? @puzpuzpuz |
Let me start CI build for this one. Once we get a green build, this PR can be landed. |
OK, It looks like get a green build. |
Thanks for the heads-up (and for the contribution). Going to land this one now. |
puzpuzpuz
pushed a commit
that referenced
this pull request
Apr 20, 2020
PR-URL: #32640 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
|
Landed in 33a5cd5 |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 27, 2020
PR-URL: #32640 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32640 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes