v13.14.0 proposal #33122
Merged
v13.14.0 proposal #33122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original commit message:
[debug] Revert to old line number behavior for new Function()
Reverting https://chromium-review.googlesource.com/c/v8/v8/+/1741660
This fixed one bug but caused a lot of others and on balance I think
reverting it is the lesser evil.
This also fixed generator-relocation.js because
(function*(){}).constructor is the function constructor and we try to
set a breakpoint on line 3.
Bug: chromium:109362, chromium:1028689
Fixes: v8:9721
Change-Id: I1bfe6ec57ce77ea7292df91266311f5c0194947e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940259
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65232}
Refs: v8/v8@dc3a90b
Revert "assert: fix line number calculation after V8 upgrade"
This reverts commit 5981fb7.
Fixes: #32688
PR-URL: #32795
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This reverts commit aeb7084. The solution creates incorrect behaviour on Windows. Re: nodejs/node-addon-api#697 (comment) Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: #32880 Backport-PR-URL: #32948 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
We introduce status `napi_would_deadlock` to be used as a return status by `napi_call_threadsafe_function` if the call is made with `napi_tsfn_blocking` on the main thread and the queue is full. Fixes: #32615 Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: #32860 Backport-PR-URL: #32948 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Use the same type check we use in `MoveToContext()` in `ReceiveMessage()`. Fixes: #32742 PR-URL: #32745 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
PR-URL: #32817 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Git for Windows includes `C:\Program Files\Git\bin\bash.exe`, which spawns ..\usr\bin\bash.exe, so copying that executable won't work. However, if a symlink is used to test paths with spaces, this executable will still work. PR-URL: #32129 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Fixes: nodejs/build#1931 PR-URL: #32129 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
PR-URL: #31950 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
PR-URL: #31950 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
PR-URL: #32749 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #32757 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This removes a footgun in which users could attempt to transfer the pooled ArrayBuffer underlying a regular `Buffer`, which would lead to all `Buffer`s that share the same pool being rendered unusable as well, and potentially break creation of new pooled `Buffer`s. This disables this kind of transfer. Refs: #32752 PR-URL: #32759 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com>
Avoid storing data that depends on command line options on internal bindings. This is generally a cleaner way of accessing CLI options. PR-URL: #32760 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
Add a type check in bidirectionalIndexOf to avoid using something else as Buffer. This may happen if e.g. lastIndexOf is called with invalid this. PR-URL: #32770 Fixes: #32753 Fixes: #32747 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
The example referenced as being potentially unsafe specifies Content-Length correctly. PR-URL: #32700 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Signed-off-by: Matheus Marchini <mmarchini@netflix.com> PR-URL: #32776 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
clang's linker seems to use considerably less memory than gcc, allowing us to run on Actions without running out of memory. Signed-off-by: Matheus Marchini <mmarchini@netflix.com> PR-URL: #32776 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Add js_native_api.h and js_native_api_types.h to the list of files covered by the N-API guidance as these were broken out of the files referenced. Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #32721 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This commit moves the last experimental feature of diagnostic reports to stable status. PR-URL: #32496 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #32788 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Add a configure flag that enables building V8 with `-DDEBUG`, in particular with debug checks enabled and with runtime debugging features, e.g. inspecting JS objects from debuggers, enabled. PR-URL: #32787 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
check for callback function is moved to a separate function. This piece of code is being shared by other entities as well. PR-URL: #32665 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Currently, the following warnings are emitted during compilation:
In file included from ../src/string_bytes.h:29,
from ../src/string_bytes.cc:22:
../deps/v8/include/v8.h:
In instantiation of ‘void v8::PersistentBase<T>::SetWeak(
P*,typename v8::WeakCallbackInfo<P>::Callback, v8::WeakCallbackType)
[with P = node::BaseObject;
T = v8::Object;
typename v8::WeakCallbackInfo<P>::Callback =
void (*)(const v8::WeakCallbackInfo<node::BaseObject>&)]’:
../src/base_object-inl.h:135:42: required from here
../deps/v8/include/v8.h:10732:16: warning:
cast between incompatible function types from
‘v8::WeakCallbackInfo<node::BaseObject>::Callback’ {aka
‘void (*)(const v8::WeakCallbackInfo<node::BaseObject>&)’} to
‘Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<void>&)’}
[-Wcast-function-type]
10732 | reinterpret_cast<Callback>(callback), type);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
And the same from test/cctest/test_aliased_buffer.cc
We have an open pull request against v8 for this:
https://chromium-review.googlesource.com/c/v8/v8/+/2080361
PR-URL: #32679
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #32751 Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Refs: #26401 (comment) PR-URL: #32826 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #32727 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Suggest using `--trace-warnings` or `--trace-deprecation` the first time a warning is emitted without a stack trace, similar to how we suggest `--trace-uncaught` when printing uncaught exceptions without a stack trace. PR-URL: #32797 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
@nodejs/releasers @nodejs/http @nodejs/http2 @nodejs/streams there is a timeout on Windows for a single test and I can't bisect on Windows right now. If anyone is able to pinpoint it to the correct commit that introduced the issue, that would be great. See e.g., https://ci.nodejs.org/job/node-test-binary-windows-js-suites/3543/ |
|
Seems like it is flaky on one machine. It does occur on other release lines as well. I am therefore going ahead with the release. |
BethGriggs
approved these changes
Apr 29, 2020
BridgeAR
added a commit
that referenced
this pull request
Apr 29, 2020
Notable Changes:
* async_hooks**:
* Merge `run` and `exit` methods (Andrey Pechkurov)
#31950
* Prevent sync methods of async storage exiting outer context
(Stephen Belanger)
#31950
* vm:
* Add `importModuleDynamically` option to compileFunction (Gus
Caplan)
#32985
New core collaborators:
With this release, we welcome two new Node.js core collaborators:
* Juan José Arboleda @juanarbol
#32906
* Andrey Pechkurov @puzpuzpuz
#32817
PR-URL: #33122
BethGriggs
added a commit
to BethGriggs/nodejs.org
that referenced
this pull request
Apr 30, 2020
BethGriggs
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Apr 30, 2020
This was referenced Jan 31, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable Changes
runandexitmethods (Andrey Pechkurov) #31950importModuleDynamicallyoption to compileFunction (Gus Caplan) #32985New core collaborators
With this release, we welcome two new Node.js core collaborators:
Commits
52d8afc07e] - (SEMVER-MINOR) async_hooks: merge run and exit methods (Andrey Pechkurov) #31950b304df97ff] - (SEMVER-MINOR) async_hooks: prevent sync methods of async storage exiting outer context (Stephen Belanger) #31950a1178b6c5b] - buffer: add type check in bidirectionalIndexOf (Gerhard Stoebich) #32770d9378747ae] - buffer: mark pool ArrayBuffer as untransferable (Anna Henningsen) #327599bcfc8ed58] - buffer,n-api: fix double ArrayBuffer::Detach() during cleanup (Anna Henningsen) #33039606719fa16] - build: fix vcbuild error for missing Visual Studio (Thomas) #32658832ea520be] - build: remove .git folders when testing V8 (Richard Lau) #32877e1809c8d71] - build: add configure flag to build V8 with DCHECKs (Anna Henningsen) #327875c4d8cd72b] - build: re-enable ASAN Action using clang (Matheus Marchini) #32776c8d43604e7] - build: use same flags as V8 for ASAN (Matheus Marchini) #32776c6078f0ca1] - build: add build from tarball (John Kleinschmidt) #321298fb7852e0b] - cli, report: move --report-on-fatalerror to stable (cjihrig) #3249698a2c67a50] - cluster: removed unused addressType argument from constructor (Yash Ladha) #329637b630aea32] - deps: update archs files for OpenSSL-1.1.1g (Hassaan Pasha) #329717940d2ca86] - deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha) #329713956ab5187] - deps: V8: backport 3f8dc4b2e5ba (Ujjwal Sharma) #329931a82b78bda] - deps: V8: cherry-pick e1eac1b16c96 (Milad Farazmand) #32974afe7f41442] - deps: upgrade to libuv 1.37.0 (cjihrig) #32866771ca7d4ed] - deps: upgrade to libuv 1.36.0 (cjihrig) #32866ea857684e9] - deps: V8: cherry-pick dc3a90be6ca7 (Michaël Zasso) #32795fc9191ad58] - doc: assign missing deprecation code (Richard Lau) #33109ea67a3097d] - doc: improve WHATWG url constructor code example (Liran Tal) #327827085e6f7b8] - doc: make openssl maintenance position independent (Sam Roberts) #32977c489a7e62b] - doc: improve release documentation (Michaël Zasso) #3304216bd3006f1] - doc: document major finished changes in v14 (Robert Nagy) #330657719f525ab] - doc: add documentation for transferList arg at worker threads (Juan José Arboleda) #3288184b12b681a] - doc: avoid tautology in README (Ishaan Jain) #3300550c6aa6dc5] - doc: updated directory entry information (Eileen) #327911b61e56538] - doc: ignore no-literal-urls in README (Nick Schonning) #32676e9b59781c3] - doc: convert bare email addresses to mailto links (Nick Schonning) #326769af2eb3b64] - doc: ignore no-literal-urls in changelogs (Nick Schonning) #326761b325f525c] - doc: add angle brackets around implicit links (Nick Schonning) #3267699f4af4190] - doc: remove repeated word in modules.md (Prosper Opara) #32931287bd8af9b] - doc: elevate diagnostic report to tier1 (Gireesh Punathil) #327328c48d16691] - doc: fix typo in security-release-process.md (Edward Elric) #32926faeb4088fa] - doc: corrected ERR_SOCKET_CANNOT_SEND message (William Armiros) #3284776e960c67f] - doc: fix usage of folder and directory terms in fs.md (karan singh virdi) #32919c5967596c0] - doc: fix typo in zlib.md (雨夜带刀) #329018c1a69c1e7] - doc: synch SECURITY.md with website (Rich Trott) #3290343adbe6bc8] - doc: addtsc-agendato onboarding labels list (Rich Trott) #3283245a125cf3a] - doc: add N-API version 6 to table (Michael Dawson) #32829cc4764579b] - doc: add juanarbol as collaborator (Juan José Arboleda) #329065dba49db7c] - doc: missing brackets (William Bonawentura) #326577980f6f749] - doc: improve consistency in usage of NULL (Michael Dawson) #327263f4bb8d67f] - doc: improve net docs (Robert Nagy) #32811b7da58773c] - doc: note that signatures of binary may be from subkeys (Reşat SABIQ) #32591ae034c4ab2] - doc: add transform stream destroy() return value (cjihrig) #32788a0be60e3ad] - doc: updated guidance for n-api changes (Michael Dawson) #3272195cd771f9b] - doc: remove warning fromresponse.writeHead(Cecchi MacNaughton) #32700c0e4ac495a] - doc: improve AsyncLocalStorage sample (Andrey Pechkurov) #32757ea09c0f111] - doc: documentbuffer.fromreturns internal pool buffer (Harshitha KP) #3270319961988d3] - doc: add puzpuzpuz to collaborators (Andrey Pechkurov) #3281727837fe4f6] - fs: update validateOffsetLengthRead in utils.js (daemon1024) #3289604b1f63b72] - fs: extract kWriteFileMaxChunkSize constant (rickyes) #326400b2cff28b9] - fs: remove unnecessary else statement (Jesus Hernandez) #326628774cb4a86] - fs: use finished over destroy w/ cb (Robert Nagy) #328094d9e69d07d] - http: doc deprecate abort and improve docs (Robert Nagy) #3280785b333b8f8] - http: refactor agent 'free' handler (Robert Nagy) #32801a673c8fe35] - http2: wait for secureConnect before initializing (bcoe) #32958fce8c4e0d9] - inspector: only write coverage in fully bootstrapped Environments (Joyee Cheung) #32960ee3c461a26] - lib: unnecessary const assignment for class (Yash Ladha) #32962944dceb618] - lib: simplify function process.emitWarning (himself65) #329928a85afabba] - lib: remove unnecesary else block (David Daza) #3264483f1e98a8e] - lib: created isValidCallback helper (Yash Ladha) #32665636267045e] - module: refactor condition (Myles Borins) #32989cb93c60e64] - module: exports not exported for null resolutions (Guy Bedford) #32838e540d5cd9b] - module: improve error for invalid package targets (Myles Borins) #320524432bb2415] - module: partial doc removal of --experimental-modules (Myles Borins) #329150c7391c9b8] - module: remove experimental modules warning (Guy Bedford) #31974520347c198] - module: fix memory leak when require error occurs (Qinhui Chen) #3283748a72bf7eb] - n-api: fix false assumption on napi_async_context structures (legendecas) #329287bd51fb8af] - perf_hooks: remove unnecessary assignment when name is undefined (rickyes) #329103b590d4f17] - process: suggest --trace-warnings when printing warning (Anna Henningsen) #32797c318a52e95] - src: add AsyncWrapObject constructor template factory (Stephen Belanger) #3305144a5b73421] - src: do not compare against wide characters (Christopher Beeson) #3292102653b8310] - src: fix empty-named env var assertion failure (Christopher Beeson) #329212264b564dc] - src: assignment to valid type (Yash Ladha) #32879d3f65e8e15] - src: delete MicroTaskPolicy namespace (Juan José Arboleda) #32853015f33cf55] - src: use using NewStringType (rickyes) #328430fdc55f51b] - src: fix null deref in AllocatedBuffer::clear (Matt Kulukundis) #32892c1f54c7313] - src: remove validation of unreachable code (Juan José Arboleda) #32818e529a32f07] - src: elevate v8 namespaces (Nimit) #328729fd0c3528a] - src: remove redundant v8::HeapSnapshot namespace (Juan José Arboleda) #32854a72d1d3ad6] - src: remove unused using in node_worker.cc (Daniel Bevenius) #328405b01772282] - src: use basename(argv0) for --trace-uncaught suggestion (Anna Henningsen) #327982f7e372077] - src: ignore GCC -Wcast-function-type for v8.h (Daniel Bevenius) #32679bff11a9cd0] - src: remove unused v8 Array namespace (Juan José Arboleda) #32749507240cec7] - stream: close iterator in Readable.from (Vadzim Zieńka) #32844b36eb756e7] - stream: inline unbuffered _write (Robert Nagy) #32886780c0efc70] - test: refactor test-async-hooks-constructor (himself65) #330635bdb401801] - test: remove timers-blocking-callback (Jeremiah Senkpiel) #32870f658cb8dc4] - test: better error validations for event-capture (Adrian Estrada) #327712c943358b2] - test: refactor events tests for invalid listeners (Adrian Estrada) #32769e6e0647709] - test: test-async-wrap-constructor prefer forEach (Daniel Estiven Rico Posada) #32631944e010324] - test: mark test-child-process-fork-args as flaky on Windows (Andrey Pechkurov) #3295087149c4b22] - test: changed function to arrow function (Nimit) #328754baf41f15e] - test: replace console.log/error() with debuglog (daemon1024) #32692740f86409d] - test: only detect uname on supported os (Xu Meng) #3283323a4d60448] - test: mark cpu-prof-dir-worker flaky on all (Sam Roberts) #3282846cafadeac] - test: replace equal with strictEqual (Jesus Hernandez) #32727edc10d4fa6] - test: mark test-worker-prof flaky on arm (Sam Roberts) #3282698db564f4b] - test: mark test-http2-reset-flood flaky on all (Sam Roberts) #32825f1273e8e87] - test: cover node entry type in perf_hooks (Julian Duque) #32751f4e9bd6d36] - test: use symlinks to copy shells (John Kleinschmidt) #32129efb3c71fea] - tls: add highWaterMark option for connect (rickyes) #32786bfa19c47a4] - tls: move getAllowUnauthorized to internal/options (James M Snell) #329171436f5359c] - tls: provide default cipher list from command line (Anna Henningsen) #32760c402edd60f] - tools: remove unused code in doc generation tool (Rich Trott) #32913f7b25c0069] - tools: decrease timeout in test.py (Anna Henningsen) #32868a3aa71a79e] - util,readline: NFC-normalize strings before getStringWidth (Anna Henningsen) #3305284fd829b45] - (SEMVER-MINOR) vm: add importModuleDynamically option to compileFunction (Gus Caplan) #32985f14916ffc9] - worker: fix process.env var empty key access (Christopher Beeson) #32921b80b08fe35] - worker: fix type check in receiveMessageOnPort (Anna Henningsen) #32745