lib: remove unnecesary else block #32644
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The if statement inside the _writeHostObject function returns an expression which makes the else block unnecessary
nodejs-github-bot
added
the
child_process
jasnell
approved these changes
Apr 3, 2020
addaleax
approved these changes
Apr 3, 2020
awibox
approved these changes
Apr 3, 2020
lpinca
approved these changes
Apr 4, 2020
2 tasks
BridgeAR
approved these changes
Apr 17, 2020
jasnell
approved these changes
Apr 18, 2020
juanarbol
approved these changes
Apr 18, 2020
juanarbol
added
the
author ready
juanarbol
pushed a commit
that referenced
this pull request
Apr 18, 2020
The if statement inside the _writeHostObject function returns an expression which makes the else block unnecessary. PR-URL: #32644 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
|
Nice catch, hope to see more of your contributions 💚 Landed in 83f7bb4 🎉 |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 27, 2020
The if statement inside the _writeHostObject function returns an expression which makes the else block unnecessary. PR-URL: #32644 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
The if statement inside the _writeHostObject function returns an expression which makes the else block unnecessary. PR-URL: #32644 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Apr 30, 2020
The if statement inside the _writeHostObject function returns an expression which makes the else block unnecessary. PR-URL: #32644 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
lpinca
added a commit
to lpinca/node
that referenced
this pull request
May 15, 2020
4 tasks
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Jul 9, 2020
Refs: nodejs#32644 Refs: nodejs#32662 PR-URL: nodejs#32667 Backport-PR-URL: nodejs#34275 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 13, 2020
codebytere
pushed a commit
that referenced
this pull request
Jul 14, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The if statement inside the _writeHostObject function returns an expression which makes the else block unnecessary
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes