Skip to content

url: handle URL.canParse without base parameter #47547

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2023
Merged

url: handle URL.canParse without base parameter #47547

merged 1 commit into from
Apr 14, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Apr 13, 2023

Fixes the bug caught by this pull request: #47541

Requesting fast-track to unblock the parent pull request.

cc @nodejs/url

@anonrig anonrig added whatwg-url Issues and PRs related to the WHATWG URL implementation. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 13, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/url

@github-actions
Copy link
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. string_decoder Issues and PRs related to the string_decoder subsystem. labels Apr 13, 2023
@anonrig anonrig force-pushed the fix-url-can-parse branch from d59277a to 8e98878 Compare April 13, 2023 16:50
@anonrig anonrig removed the string_decoder Issues and PRs related to the string_decoder subsystem. label Apr 13, 2023
@debadree25 debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 13, 2023
KhafraDev
KhafraDev approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@KhafraDev KhafraDev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anonrig anonrig removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2023
@anonrig
Copy link
Member Author

anonrig commented Apr 13, 2023

I'm updating the test to also include internalBinding call.

@anonrig anonrig force-pushed the fix-url-can-parse branch from 8e98878 to 730bb2a Compare April 13, 2023 17:04
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51206/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51213/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51223/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51233/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2023
@nodejs-github-bot nodejs-github-bot merged commit 3d17735 into nodejs:main Apr 14, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 3d17735

@github-actions github-actions bot mentioned this pull request Apr 15, 2023
Open
33 tasks
targos pushed a commit that referenced this pull request May 2, 2023
@anonrig @targos
url: handle URL.canParse without base parameter
9aae767 
PR-URL: #47547
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request May 2, 2023
Merged
@anonrig anonrig mentioned this pull request Jun 17, 2023
Closed
19 tasks
anonrig added a commit to anonrig/node that referenced this pull request Jun 17, 2023
@anonrig
url: handle URL.canParse without base parameter
e51bc6c 
PR-URL: nodejs#47547
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
anonrig added a commit to anonrig/node that referenced this pull request Jun 17, 2023
@anonrig
url: handle URL.canParse without base parameter
c335b74 
PR-URL: nodejs#47547
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
anonrig added a commit to anonrig/node that referenced this pull request Jun 23, 2023
@anonrig
url: handle URL.canParse without base parameter
0f267b0 
PR-URL: nodejs#47547
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
anonrig added a commit to anonrig/node that referenced this pull request Jun 24, 2023
@anonrig
url: handle URL.canParse without base parameter
4a8ae50 
PR-URL: nodejs#47547
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
anonrig added a commit to anonrig/node that referenced this pull request Jun 24, 2023
@anonrig
url: handle URL.canParse without base parameter
0c10186 
PR-URL: nodejs#47547
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
anonrig added a commit to anonrig/node that referenced this pull request Jun 26, 2023
@anonrig
url: handle URL.canParse without base parameter
a24884c 
PR-URL: nodejs#47547
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
anonrig added a commit to anonrig/node that referenced this pull request Jun 26, 2023
@anonrig
url: handle URL.canParse without base parameter
de6d1d7 
PR-URL: nodejs#47547
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
anonrig added a commit to anonrig/node that referenced this pull request Jul 6, 2023
@anonrig
url: handle URL.canParse without base parameter
830c92e 
PR-URL: nodejs#47547
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
anonrig added a commit to anonrig/node that referenced this pull request Jul 9, 2023
@anonrig
url: handle URL.canParse without base parameter
f93ebf9 
PR-URL: nodejs#47547
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
anonrig added a commit to anonrig/node that referenced this pull request Jul 9, 2023
@anonrig
url: handle URL.canParse without base parameter
5824a9e 
PR-URL: nodejs#47547
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@anonrig @danielleadams
url: handle URL.canParse without base parameter
8897305 
PR-URL: #47547
Backport-PR-URL: #48345
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 12, 2023
Merged
@merceyz merceyz mentioned this pull request Feb 14, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@ronag ronag ronag approved these changes

@debadree25 debadree25 debadree25 approved these changes

@KhafraDev KhafraDev KhafraDev approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@anonrig @nodejs-github-bot @lpinca @ronag @debadree25 @KhafraDev @danielleadams