Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[v18.x] backport Ada v2.x to Node.js v18 #48345

Closed
wants to merge 20 commits into from
Closed

[v18.x] backport Ada v2.x to Node.js v18 #48345

wants to merge 20 commits into from

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Jun 5, 2023 •
edited
Loading

All of the backports below are somehow related to each other and that's why it resulted into a huge back port

Fixes #48343
Fixes #48117
Fixes #48621

Backports

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Jun 5, 2023
@anonrig anonrig marked this pull request as ready for review June 5, 2023 14:43
@anonrig

This comment was marked as outdated.

# to view
@anonrig anonrig force-pushed the backport-ada-v2-to-v18.x branch 2 times, most recently from 0015d46 to 8e1fe70 Compare June 5, 2023 14:55
@richardlau
Copy link
Member

@nodejs/build Appreciate it if you could review & merge this since it is a really big backport.

Wrong team. Releases are managed by the release WG and LTS in particular by @nodejs/lts.
FWIW #48036, #48092 and #48223 have yet to go out in a current release. We usually do not consider things being backported to a LTS release line until it has been in a current release for two weeks.

@anonrig
Copy link
Member Author

anonrig commented Jun 5, 2023

Wrong team.

Sorry!

ping @nodejs/releasers

@anonrig anonrig force-pushed the backport-ada-v2-to-v18.x branch from 8e1fe70 to 82221be Compare June 5, 2023 15:48
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52105/

@github-actions github-actions bot mentioned this pull request Jun 6, 2023
Open
20 tasks
@richardlau
Copy link
Member

@anonrig Could you take a look at the test failures?

This was referenced Jun 9, 2023
Open
Open
Open
@anonrig anonrig force-pushed the backport-ada-v2-to-v18.x branch 2 times, most recently from e51bc6c to c335b74 Compare June 17, 2023 02:35
@anonrig anonrig force-pushed the backport-ada-v2-to-v18.x branch 2 times, most recently from 0f267b0 to 2c34b15 Compare June 23, 2023 23:33
@anonrig
Copy link
Member Author

anonrig commented Jun 24, 2023

node-test-pull-request ci: https://ci.nodejs.org/job/node-test-pull-request/52413/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52688/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52689/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52694/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52722/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52728/

danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@anonrig @danielleadams
url: remove unused kFormat from url
3db235b 
PR-URL: #46867
Backport-PR-URL: #48345
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@anonrig @danielleadams
url: offload URLSearchParams initialization
c79e1b7 
PR-URL: #46867
Backport-PR-URL: #48345
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@anonrig @danielleadams
url: set formatUrl method as no side effect
aa4f485 
PR-URL: #46884
Backport-PR-URL: #48345
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@anonrig @danielleadams
url: backport non-major changes from #46904
f495cb6 
PR-URL: #46904
Backport-PR-URL: #48345
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@aduh95 @danielleadams
url: allow extension of user provided URL objects
4784e64 
PR-URL: #46989
Backport-PR-URL: #48345
Fixes: #46981
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@anonrig @danielleadams
url: fix array overrun in node:url::SetArgs()
977a8ba 
PR-URL: #47001
Backport-PR-URL: #48345
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@addaleax @danielleadams
src: use std::array for passing argv in node::url
1f2c91f 
Implements a review suggestion from 72e971e.

Refs: #47001 (comment)
PR-URL: #47035
Backport-PR-URL: #48345
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@KhafraDev @danielleadams
url: implement URL.canParse
11f48e0 
PR-URL: #47179
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@nodejs-github-bot @danielleadams
deps: update ada to 2.0.0
96c50ba 
PR-URL: #47339
Backport-PR-URL: #48345
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@anonrig @danielleadams
url: use ada::url_aggregator for parsing urls
b395b16 
PR-URL: #47339
Backport-PR-URL: #48345
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@anonrig @danielleadams
url: drop ICU requirement for parsing hostnames
0dc485e 
PR-URL: #47339
Backport-PR-URL: #48345
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@anonrig @danielleadams
url: handle URL.canParse without base parameter
8897305 
PR-URL: #47547
Backport-PR-URL: #48345
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@nodejs-github-bot @danielleadams
deps: update ada to 2.1.0
08dd271 
PR-URL: #47598
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@nodejs-github-bot @danielleadams
deps: update ada to 2.2.0
42e690f 
PR-URL: #47678
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@nodejs-github-bot @danielleadams
deps: update ada to 2.3.0
2d03d5f 
PR-URL: #47737
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@nodejs-github-bot @danielleadams
deps: update ada to 2.3.1
575ddf6 
PR-URL: #47893
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@nodejs-github-bot @danielleadams
deps: update ada to 2.4.0
81b514d 
PR-URL: #47922
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@nodejs-github-bot @danielleadams
deps: update ada to 2.4.1
a4ee1f6 
PR-URL: #48036
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@nodejs-github-bot @danielleadams
deps: update ada to 2.4.2
075b6db 
PR-URL: #48092
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@nodejs-github-bot @danielleadams
deps: update ada to 2.5.0
6f3a8b4 
PR-URL: #48223
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams
Copy link
Contributor

Landed in 5d910ca...6f3a8b4

@github-actions github-actions bot mentioned this pull request Jul 16, 2023
Open
23 tasks
@ckerr ckerr mentioned this pull request Jul 20, 2023
Merged
@MattIPv4 MattIPv4 mentioned this pull request Aug 25, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@danielleadams danielleadams danielleadams approved these changes

@RafaelGSS RafaelGSS Awaiting requested review from RafaelGSS

@targos targos Awaiting requested review from targos

@ruyadorno ruyadorno Awaiting requested review from ruyadorno

@juanarbol juanarbol Awaiting requested review from juanarbol

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@anonrig @nodejs-github-bot @richardlau @juanarbol @targos @StefanStojanovic @danielleadams @aduh95 @addaleax @KhafraDev