Skip to content

Conversation

matthieusieben
Copy link
Contributor

Fixes #52721

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 27, 2024
@matthieusieben
Copy link
Contributor Author

Capture d’écran 2024-04-27 à 14 41 06

@jasnell
Copy link
Member

jasnell commented Apr 27, 2024

Is it possible to add a test for this change?

@matthieusieben
Copy link
Contributor Author

@jasnell done

@matthieusieben matthieusieben force-pushed the fix-52721 branch 3 times, most recently from 5d423c6 to 7df71f8 Compare April 29, 2024 08:17
@matthieusieben
Copy link
Contributor Author

@jasnell Is there anything else you need ?

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 11, 2024
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 12, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 12, 2024
@nodejs-github-bot nodejs-github-bot merged commit c75675c into nodejs:main May 12, 2024
@nodejs-github-bot
Copy link
Collaborator

Landed in c75675c

targos pushed a commit that referenced this pull request May 12, 2024
PR-URL: #52722
Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
PR-URL: #52722
Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
PR-URL: #52722
Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
PR-URL: #52722
Reviewed-By: James M Snell <jasnell@gmail.com>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
PR-URL: nodejs#52722
Reviewed-By: James M Snell <jasnell@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
PR-URL: nodejs#52722
Reviewed-By: James M Snell <jasnell@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watch does not debounce restart when different files are updated within the debounce period
4 participants