Skip to content

v22.2.0 release proposal #52971

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 147 commits into from
May 15, 2024
Merged

v22.2.0 release proposal #52971

merged 147 commits into from
May 15, 2024

Conversation

targos
Copy link
Member

@targos targos commented May 13, 2024

2024-05-15, Version 22.2.0 (Current), @targos

Notable Changes

  • [fb85d38e80] - (SEMVER-MINOR) cli: allow running wasm in limited vmem with --disable-wasm-trap-handler (Joyee Cheung) #52766
  • [23a0d3339f] - doc: add pimterry to collaborators (Tim Perry) #52874
  • [7d7a762156] - (SEMVER-MINOR) fs: allow 'withFileTypes' to be used with globs (Aviv Keller) #52837
  • [8748dd6477] - (SEMVER-MINOR) inspector: introduce the --inspect-wait flag (Kohei Ueno) #52734
  • [9a7ae9b6c4] - lib,src: remove --experimental-policy (Rafael Gonzaga) #52583
  • [1f7c2a93fc] - (SEMVER-MINOR) perf_hooks: add deliveryType and responseStatus fields (Matthew Aitken) #51589
  • [2f59529dc5] - (SEMVER-MINOR) test_runner: support test plans (Colin Ihrig) #52860
  • [6b4dac3eb5] - (SEMVER-MINOR) zlib: expose zlib.crc32() (Joyee Cheung) #52692

Commits

  • [0f5716c364] - assert: add deep equal check for more Error type (Zhenwei Jin) #51805
  • [2c7d7caa8a] - benchmark: filter non-present deps from start-cli-version (Adam Majer) #51746
  • [5db4c54bd6] - bootstrap: print --help message using console.log (Jacob Hummer) #51463
  • [67fcb6b85e] - buffer: even faster atob (Daniel Lemire) #52443
  • [a5d63f9052] - buffer: use size_t instead of uint32_t to avoid segmentation fault (Xavier Stouder) #48033
  • [f1bc994826] - buffer: remove lines setting indexes to integer value (Zhenwei Jin) #52588
  • [a97ff753ab] - build: add option to enable clang-cl on Windows (Michaël Zasso) #52870
  • [f96466a92c] - build: enable building with shared uvwasi lib (Pooja D P) #43987
  • [b463385aa8] - build: remove deprecated calls for argument groups (Mohammed Keyvanzadeh) #52913
  • [daeb7dbb3e] - build: sync V8 warning cflags with BUILD.gn (Michaël Zasso) #52873
  • [eed967430d] - build: harmonize Clang checks (Michaël Zasso) #52873
  • [e4b187433d] - build: compile with C++20 support (Michaël Zasso) #52838
  • [aea6ca25ba] - build: drop base64 dep in GN build (Cheng) #52856
  • [7f866a8225] - build: make simdjson a public dep in GN build (Cheng) #52755
  • [e1bd53c098] - build: define NOMINMAX in common.gypi (Chengzhong Wu) #52794
  • [18c530f8f7] - build, tools: copy release assets to staging R2 bucket once built (flakey5) #51394
  • [fb85d38e80] - (SEMVER-MINOR) cli: allow running wasm in limited vmem with --disable-wasm-trap-handler (Joyee Cheung) #52766
  • [11e978916f] - cluster: replace forEach with for-of loop (Jérôme Benoit) #50317
  • [db76c58d68] - console: colorize console error and warn (Jithil P Ponnan) #51629
  • [0d040a3035] - crypto: fix duplicated switch-case return values (Mustafa Ateş UZUN) #49030
  • [ab7219f0b2] - deps: update googletest to fa6de7f (Node.js GitHub Bot) #52949
  • [4ab096eccc] - deps: update simdjson to 3.9.2 (Node.js GitHub Bot) #52947
  • [89f275b1df] - deps: update corepack to 0.28.1 (Node.js GitHub Bot) #52946
  • [fc568b4b42] - deps: update simdutf to 5.2.8 (Node.js GitHub Bot) #52727
  • [e399360182] - deps: update simdutf to 5.2.6 (Node.js GitHub Bot) #52727
  • [232831f013] - deps: enable unbundling of simdjson, simdutf, ada (Daniel Lemire) #52924
  • [7ca83a5abc] - deps: update googletest to 2d16ed0 (Node.js GitHub Bot) #51657
  • [3b15eb5911] - deps: update googletest to d83fee1 (Node.js GitHub Bot) #51657
  • [4190d70035] - deps: update googletest to 5a37b51 (Node.js GitHub Bot) #51657
  • [7a166a2871] - deps: update googletest to 5197b1a (Node.js GitHub Bot) #51657
  • [812dbd749f] - deps: update googletest to eff443c (Node.js GitHub Bot) #51657
  • [cb3ae4b9ef] - deps: update googletest to c231e6f (Node.js GitHub Bot) #51657
  • [d97317aaa1] - deps: update googletest to e4fdb87 (Node.js GitHub Bot) #51657
  • [ad8ca1259f] - deps: update googletest to 5df0241 (Node.js GitHub Bot) #51657
  • [828f0d7096] - deps: update googletest to b75ecf1 (Node.js GitHub Bot) #51657
  • [3b60dbcf7b] - deps: update googletest to 4565741 (Node.js GitHub Bot) #51657
  • [37098eb880] - deps: update simdjson to 3.9.1 (Node.js GitHub Bot) #52397
  • [a13cf1c049] - deps: update uvwasi to 0.0.21 (Node.js GitHub Bot) #52863
  • [faf8ada719] - deps: V8: cherry-pick f6bef09b3b0a (Richard Lau) #52802
  • [8e5844c2a4] - doc: remove reference to AUTHORS file (Marco Ippolito) #52960
  • [1f3634e30f] - doc: update hljs with the latest styles (Aviv Keller) #52911
  • [9102255749] - doc: mention quicker way to build docs (Alex Crawford) #52937
  • [15db3ef5fb] - doc: mention push.followTags config (Rafael Gonzaga) #52906
  • [80fa675af2] - doc: document pipeline with end option (Alois Klink) #48970
  • [c0000f4118] - doc: add example for execFileSync method and ref to stdio (Evan Shortiss) #39412
  • [e0148e2653] - doc: add examples and notes to http server.close et al (mary marchini) #49091
  • [030f56ee6d] - doc: fix dns.lookup family 0 and all descriptions (Adam Jones) #51653
  • [a6d624cd5a] - doc: update fs.realpath documentation (sinkhaha) #48170
  • [5dab187ca8] - doc: update fs read documentation for clarity (Mert Can Altin) #52453
  • [5d3ee7205d] - doc: watermark string behavior (Benjamin Gruenbaum) #52842
  • [2dd8f092a8] - doc: exclude commits with baking-for-lts (Marco Ippolito) #52896
  • [0c2539b913] - doc: add names next to release key bash commands (Aviv Keller) #52878
  • [23a0d3339f] - doc: add pimterry to collaborators (Tim Perry) #52874
  • [15aad62e0c] - doc: update BUILDING.md previous versions links (Michaël Zasso) #52852
  • [f770a993d4] - doc: add more definitions to GLOSSARY.md (Aviv Keller) #52798
  • [f35b838a65] - doc: make docs more welcoming and descriptive for newcomers (Serkan Özel) #38056
  • [562a019a14] - doc: add OpenSSL errors to API docs (John Lamp) #34213
  • [0cb7cf7aa9] - doc: fix grammatical mistake (codershiba) #52808
  • [a0147ff8d0] - doc: simplify copy-pasting of branch-diff commands (Antoine du Hamel) #52757
  • [fce31fc829] - doc: add test_runner to subsystem (Raz Luvaton) #52774
  • [ca5607bbc8] - events: update MaxListenersExceededWarning message log (sinkhaha) #51921
  • [96566fc696] - events: add stop propagation flag to Event.stopImmediatePropagation (Mickael Meausoone) #39463
  • [5ee69243ed] - events: replace NodeCustomEvent with CustomEvent (Feng Yu) #43876
  • [f076e721cb] - fs: keep fs.promises.readFile read until EOF is reached (Zhenwei Jin) #52178
  • [7d7a762156] - (SEMVER-MINOR) fs: allow 'withFileTypes' to be used with globs (Aviv Keller) #52837
  • [ad9c4bddb1] - http: correctly translate HTTP method (Paolo Insogna) #52701
  • [8748dd6477] - (SEMVER-MINOR) inspector: introduce the --inspect-wait flag (Kohei Ueno) #52734
  • [9a7ae9b6c4] - lib,src: remove --experimental-policy (Rafael Gonzaga) #52583
  • [a850219600] - meta: move @anonrig to TSC regular member (Yagiz Nizipli) #52932
  • [4dc8a387b3] - meta: add mailmap entry for legendecas (Chengzhong Wu) #52795
  • [d10182d81d] - meta: bump actions/checkout from 4.1.1 to 4.1.4 (dependabot[bot]) #52787
  • [48d0ac0665] - meta: bump github/codeql-action from 3.24.9 to 3.25.3 (dependabot[bot]) #52786
  • [7c7a25150e] - meta: bump actions/upload-artifact from 4.3.1 to 4.3.3 (dependabot[bot]) #52785
  • [d9abf18342] - meta: bump actions/download-artifact from 4.1.4 to 4.1.7 (dependabot[bot]) #52784
  • [590e5c6c45] - meta: bump codecov/codecov-action from 4.1.1 to 4.3.1 (dependabot[bot]) #52783
  • [b3d1720515] - meta: bump step-security/harden-runner from 2.7.0 to 2.7.1 (dependabot[bot]) #52782
  • [f74beb53de] - module: cache synchronous module jobs before linking (Joyee Cheung) #52868
  • [8fbf6628d6] - module: have a single hooks thread for all workers (Gabriel Bota) #52706
  • [609d90bb4b] - path: fix toNamespacedPath on Windows (Hüseyin Açacak) #52915
  • [1f7c2a93fc] - (SEMVER-MINOR) perf_hooks: add deliveryType and responseStatus fields (Matthew Aitken) #51589
  • [0bbc62c42a] - process: improve event-loop (Aras Abbasi) #52108
  • [619ac79abb] - quic: address coverity warning (Michael Dawson) #52824
  • [04de5766ee] - repl: fix disruptive autocomplete without inspector (Nitzan Uziely) #40661
  • [663bb973ab] - src: fix Worker termination in inspector.waitForDebugger (Daeyeon Jeong) #52527
  • [fca38b2d6e] - src: use S_ISDIR to check if the file is a directory (theanarkh) #52164
  • [b228db579f] - src: allow preventing debug signal handler start (Shelley Vohr) #46681
  • [ace65a9aac] - src: make sure pass the argv to worker threads (theanarkh) #52827
  • [75004d32ab] - src: fix typo Unabled -> Unable (Simon Siefke) #52820
  • [c40a8273ef] - src: avoid unused variable 'error' warning (Michaël Zasso) #52886
  • [d169d0f181] - src: fix positional args in task runner (Yagiz Nizipli) #52810
  • [9c76c95c10] - src: only apply fix in main thread (Paolo Insogna) #52702
  • [e1cba97df3] - src: fix test local edge case (Paolo Insogna) #52702
  • [dc41c135d7] - src: reduce unnecessary serialization of CLI options in C++ (Joyee Cheung) #52451
  • [fb24c4475c] - src: rewrite task runner in c++ (Yagiz Nizipli) #52609
  • [323f95de9e] - src: migrate to new V8 interceptors API (Michaël Zasso) #52745
  • [850ff02931] - src,permission: resolve path on fs_permission (Rafael Gonzaga) #52761
  • [8d3b0b7ade] - stream: use ByteLengthQueuingStrategy when not in objectMode (Jason) #48847
  • [fa715437b0] - stream: fix util.inspect for compression/decompressionStream (Mert Can Altin) #52283
  • [b0e6a6b3d5] - string_decoder: throw an error when writing a too long buffer (zhenweijin) #52215
  • [e016e952e6] - test: add Debugger.setInstrumentationBreakpoint known issue (Konstantin Ulitin) #31137
  • [a589de0886] - test: use for-of instead of forEach (Gibby Free) #49790
  • [578868ddf8] - test: verify request payload is uploaded consistently (Austin Wright) #34066
  • [c676e522e6] - test: add fuzzer for native/js string conversion (Adam Korczynski) #51120
  • [5f6415b41d] - test: add fuzzer for ClientHelloParser (AdamKorcz) #51088
  • [4d50d51a5e] - test: fix broken env fuzzer by initializing process (AdamKorcz) #51080
  • [cd00cdcbc8] - test: replace forEach() in test-stream-pipe-unpipe-stream (Dario) #50786
  • [5469adf458] - test: test pipeline end on transform streams (Alois Klink) #48970
  • [ea6070b0e8] - test: improve coverage of lib/readline.js (Rongjian Zhang) #38646
  • [4f96b00307] - test: updated for each to for of in test file (lyannel) #50308
  • [5d91cf1976] - test: move test-http-server-request-timeouts-mixed to sequential (Madhuri) #45722
  • [f47e8fccbb] - test: fix DNS cancel tests (Szymon Marczak) #44432
  • [0b073f885a] - test: add http agent to executionAsyncResource (psj-tar-gz) #34966
  • [fbce3178ba] - test: reduce memory usage of test-worker-stdio (Adam Majer) #37769
  • [1f8eaec454] - test: add common.expectRequiredModule() (Joyee Cheung) #52868
  • [5e731da572] - test: skip unstable shadow realm gc tests (Chengzhong Wu) #52855
  • [30a35ae522] - test: crypto-rsa-dsa testing for dynamic openssl (Michael Dawson) #52781
  • [968fe6a8b1] - test: skip some console tests on dumb terminal (Adam Majer) #37770
  • [1448959e0d] - test: skip v8-updates/test-linux-perf-logger (Michaël Zasso) #52821
  • [30a4248b48] - test: add env variable test for --run (Yagiz Nizipli) #52811
  • [edb4ed3bc9] - test: drop test-crypto-timing-safe-equal-benchmarks (Rafael Gonzaga) #52751
  • [944ae598b5] - test, crypto: use correct object on assert (响马) #51820
  • [a814e720fa] - test_runner: fix watch mode race condition (Moshe Atlow) #52954
  • [2f59529dc5] - (SEMVER-MINOR) test_runner: support test plans (Colin Ihrig) #52860
  • [3267b3c063] - test_runner: display failed test stack trace with dot reporter (Mihir Bhansali) #52655
  • [b96868b4e7] - test_runner: preserve hook promise when executed twice (Moshe Atlow) #52791
  • [74341ba3c9] - tools: fix v8-update workflow (Michaël Zasso) #52957
  • [afe39ed0df] - tools: add --certify-safe to nci-ci (Matteo Collina) #52940
  • [bb97e1ccdd] - tools: fix doc update action (Marco Ippolito) #52890
  • [c6043fe6c8] - tools: fix get_asan_state() in tools/test.py (Joyee Cheung) #52766
  • [6e71accc5f] - tools: support max_virtual_memory test configuration (Joyee Cheung) #52766
  • [1600bdac60] - tools: support != in test status files (Joyee Cheung) #52766
  • [8ce23dc9f3] - tools: update gyp-next to 0.18.0 (Node.js GitHub Bot) #52835
  • [c5f832adc0] - tools: update gyp-next to 0.17.0 (Node.js GitHub Bot) #52835
  • [646a094782] - tools: prepare custom rules for ESLint v9 (Michaël Zasso) #52889
  • [505566347d] - tools: update lint-md-dependencies to rollup@4.17.2 (Node.js GitHub Bot) #52836
  • [466e0c1321] - tools: update gr2m/create-or-update-pull-request-action (Antoine du Hamel) #52843
  • [ce7a751ad1] - tools: use sccache GitHub action (Michaël Zasso) #52839
  • [1ee38a5ec1] - tools: specify a commit-message for V8 update workflow (Antoine du Hamel) #52844
  • [317998a1e8] - tools: fix V8 update workflow (Antoine du Hamel) #52822
  • [ef6a2101e2] - url,tools,benchmark: replace deprecated substr() (Jungku Lee) #51546
  • [0deef2d2b1] - util: fix %s format behavior with Symbol.toPrimitive (Chenyu Yang) #50992
  • [a42b93b9aa] - util: improve isInsideNodeModules (uzlopak) #52147
  • [d71e16154a] - watch: allow listening for grouped changes (Matthieu Sieben) #52722
  • [e895f7cf32] - watch: enable passthrough ipc in watch mode (Zack) #50890
  • [f5d925706a] - watch: fix arguments parsing (Moshe Atlow) #52760
  • [6b4dac3eb5] - (SEMVER-MINOR) zlib: expose zlib.crc32() (Joyee Cheung) #52692

rluvaton and others added 30 commits May 8, 2024 07:12
PR-URL: #52774
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Refs: v8#180
PR-URL: #52745
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
PR-URL: #52751
Refs: #38226
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #52757
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This patch exposes the crc32() function from zlib to user-land.

It computes a 32-bit Cyclic Redundancy Check checksum of `data`. If
`value` is specified, it is used as the starting value of the checksum,
otherwise, 0 is used as the starting value.

```js
const zlib = require('node:zlib');
const { Buffer } = require('node:buffer');

let crc = zlib.crc32('hello');  // 907060870
crc = zlib.crc32('world', crc);  // 4192936109

crc = zlib.crc32(Buffer.from('hello'));  // 907060870
crc = zlib.crc32(Buffer.from('world'), crc);  // 4192936109
```

PR-URL: #52692
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #52760
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
PR-URL: #52609
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
In this patch we split the serialization routine into two different
routines: `getCLIOptionsValues()` for only serializing the key-value
pairs and `getCLIOptionsInfo()` for getting additional information such
as help text etc. The former is used a lot more frequently than the
latter, which is only used for generating `--help` and building
`process.allowedNodeEnvironmentFlags`.

`getCLIOptionsValues()` also adds `--no-` entries for boolean options so
there is no need to special case in the JS land.
This patch also refactors the option serialization routines to
use v8::Object constructor that takes key-value pairs in one go
to avoid calling Map::Set or Object::Set repeatedly which can go
up to a patched prototype.

PR-URL: #52451
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: #52761
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Original commit message:

    [turboshaft] initialize constant_value_ to an empty value

    gcc-10 seems to have a bug were not initializing this value
    throws this compilation error:
    ```
    src/compiler/turboshaft/assembler.h:680:16: error: ‘<anonymous>’ is used uninitialized in this function [-Werror=uninitialized]
      680 |     return Get();
    ```
    https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86465

    Bug: v8:12783
    Change-Id: I7a5fee5009b866a801326fba734c156c3cfdb1b0
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5503350
    Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
    Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
    Cr-Commit-Position: refs/heads/main@{#93675}

Refs: v8/v8@f6bef09
PR-URL: #52802
Fixes: #52661
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
PR-URL: #52808
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.7.0 to 2.7.1.
- [Release notes](https://github.com/step-security/harden-runner/releases)
- [Commits](step-security/harden-runner@63c24ba...a4aa98b)

---
updated-dependencies:
- dependency-name: step-security/harden-runner
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: #52782
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.1.1 to 4.3.1.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@c16abc2...5ecb98a)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: #52783
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4.1.4 to 4.1.7.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@c850b93...65a9edc)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: #52784
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.1 to 4.3.3.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@5d5d22a...6546280)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: #52785
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.9 to 3.25.3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@1b1aada...d39d31e)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: #52786
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.1 to 4.1.4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@b4ffde6...0ad4b8f)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: #52787
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #52795
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
V8 and Node.js had defined `NOMINMAX` on Windows for a long time.  In
recent changes, V8 added `std::numeric_limits::min` usages in its
header files which caused addons without `NOMINMAX` defines failed
to compile.

Define `NOMINMAX` in common.gypi so that addons can be compiled with
the latest V8 header files.

PR-URL: #52794
Fixes: nodejs/nan#968
Refs: nodejs/gyp-next#244
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
PR-URL: #52215
Fixes: #52214
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #52701
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #52811
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #52791
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #52755
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #52147
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #52702
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #52702
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Fixes: #33705
PR-URL: #34213
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Refs: #51308
PR-URL: #52821
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #52822
Fixes: #50497
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95
Copy link
Contributor

aduh95 commented May 14, 2024

Any chance we can add the recent deps update PRs that have landed?

@targos
Copy link
Member Author

targos commented May 14, 2024

Sure, which ones? I didn't add Undici because it's blocked on #52370

I won't be able to do the release today. There are too many CI issues.

@aduh95
Copy link
Contributor

aduh95 commented May 14, 2024

Excluding Undici, here’s the list:

  • does: update googletest to fa6de7f
  • deps: update simdjson to 3.9.2
  • deps: update corepack to 0.28.1

avivkeller and others added 10 commits May 15, 2024 08:41
PR-URL: #52911
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
PR-URL: #52915
Fixes: #30224
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Most changes are gated by the `clang==1` condition to avoid breaking
MSVC builds.

Select C/C++ language standard with ClCompile options.
This avoids passing the `-std:c++20` flag while compiling C code.
Do it only under clang option to avoid breaking addons until node-gyp
supports the new LanguageStandard options.

Disable precompiled header configuration for now as it doesn't seem to
work with clang-cl.

Disable C++20 warnings emitted by the Visual Studio C++ STL.
They're very noisy and not our responsibility to fix.

Co-authored-by: Daniel Lemire <daniel@lemire.me>
Co-authored-by: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
PR-URL: #52870
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #52946
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #52947
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #52949
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #52954
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
- Add a step that configures Git so the update script can create
  commits.
- Use `peter-evans/create-pull-request` as it's more maintained and
  correctly handles commits that are created before it runs.

Refs: https://github.com/peter-evans/create-pull-request
PR-URL: #52957
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #52960
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Notable changes:

cli:
  * (SEMVER-MINOR) allow running wasm in limited vmem with
    --disable-wasm-trap-handler (Joyee Cheung)
    #52766
doc:
  * add pimterry to collaborators (Tim Perry)
    #52874
fs:
  * (SEMVER-MINOR) allow 'withFileTypes' to be used with globs
    (Aviv Keller) #52837
inspector:
  * (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno)
    #52734
lib,src:
  * remove --experimental-policy (Rafael Gonzaga)
    #52583
perf_hooks:
  * (SEMVER-MINOR) add `deliveryType` and `responseStatus` fields
    (Matthew Aitken) #51589
test_runner:
  * (SEMVER-MINOR) support test plans (Colin Ihrig)
    #52860
zlib:
  * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung)
    #52692

PR-URL: #52971
@targos targos force-pushed the v22.2.0-proposal branch from 7d92816 to d57af10 Compare May 15, 2024 06:45
@targos
Copy link
Member Author

targos commented May 15, 2024

Updated!

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2024
@targos targos merged commit d57af10 into v22.x May 15, 2024
25 checks passed
@targos targos deleted the v22.2.0-proposal branch May 15, 2024 19:19
targos added a commit that referenced this pull request May 15, 2024
targos added a commit that referenced this pull request May 15, 2024
Notable changes:

cli:
  * (SEMVER-MINOR) allow running wasm in limited vmem with
    --disable-wasm-trap-handler (Joyee Cheung)
    #52766
doc:
  * add pimterry to collaborators (Tim Perry)
    #52874
fs:
  * (SEMVER-MINOR) allow 'withFileTypes' to be used with globs
    (Aviv Keller) #52837
inspector:
  * (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno)
    #52734
lib,src:
  * remove --experimental-policy (Rafael Gonzaga)
    #52583
perf_hooks:
  * (SEMVER-MINOR) add `deliveryType` and `responseStatus` fields
    (Matthew Aitken) #51589
test_runner:
  * (SEMVER-MINOR) support test plans (Colin Ihrig)
    #52860
zlib:
  * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung)
    #52692

PR-URL: #52971
targos added a commit to targos/nodejs.org that referenced this pull request May 15, 2024
github-merge-queue bot pushed a commit to nodejs/nodejs.org that referenced this pull request May 15, 2024
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
Notable changes:

cli:
  * (SEMVER-MINOR) allow running wasm in limited vmem with
    --disable-wasm-trap-handler (Joyee Cheung)
    nodejs#52766
doc:
  * add pimterry to collaborators (Tim Perry)
    nodejs#52874
fs:
  * (SEMVER-MINOR) allow 'withFileTypes' to be used with globs
    (Aviv Keller) nodejs#52837
inspector:
  * (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno)
    nodejs#52734
lib,src:
  * remove --experimental-policy (Rafael Gonzaga)
    nodejs#52583
perf_hooks:
  * (SEMVER-MINOR) add `deliveryType` and `responseStatus` fields
    (Matthew Aitken) nodejs#51589
test_runner:
  * (SEMVER-MINOR) support test plans (Colin Ihrig)
    nodejs#52860
zlib:
  * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung)
    nodejs#52692

PR-URL: nodejs#52971
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
Notable changes:

cli:
  * (SEMVER-MINOR) allow running wasm in limited vmem with
    --disable-wasm-trap-handler (Joyee Cheung)
    nodejs#52766
doc:
  * add pimterry to collaborators (Tim Perry)
    nodejs#52874
fs:
  * (SEMVER-MINOR) allow 'withFileTypes' to be used with globs
    (Aviv Keller) nodejs#52837
inspector:
  * (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno)
    nodejs#52734
lib,src:
  * remove --experimental-policy (Rafael Gonzaga)
    nodejs#52583
perf_hooks:
  * (SEMVER-MINOR) add `deliveryType` and `responseStatus` fields
    (Matthew Aitken) nodejs#51589
test_runner:
  * (SEMVER-MINOR) support test plans (Colin Ihrig)
    nodejs#52860
zlib:
  * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung)
    nodejs#52692

PR-URL: nodejs#52971
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release Issues and PRs related to Node.js releases. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.