module: fix discrepancy between .ts and .js #54461

marco-ippolito · 2024-08-20T08:40:09Z

Fixes: #54457

This fixes the discrepancy with the .js behavior

nodejs-github-bot · 2024-08-20T08:40:14Z

Review requested:

@nodejs/loaders
@nodejs/typescript

ShogunPanda

LGTM!

lib/internal/modules/esm/get_format.js

codecov · 2024-08-20T10:05:21Z

Codecov Report

Attention: Patch coverage is 98.38710% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.31%. Comparing base (ef4bdbf) to head (af4f6c9).
Report is 779 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/modules/helpers.js	98.11%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54461      +/-   ##
==========================================
- Coverage   87.32%   87.31%   -0.01%     
==========================================
  Files         648      648              
  Lines      182383   182389       +6     
  Branches    34991    34987       -4     
==========================================
+ Hits       159260   159262       +2     
- Misses      16384    16390       +6     
+ Partials     6739     6737       -2

Files with missing lines	Coverage Δ
lib/internal/modules/esm/get_format.js	`88.88% <100.00%> (-1.59%)`	⬇️
lib/internal/modules/esm/translators.js	`91.49% <100.00%> (-0.56%)`	⬇️
lib/internal/modules/helpers.js	`97.61% <98.11%> (+0.06%)`	⬆️

... and 29 files with indirect coverage changes

nodejs-github-bot · 2024-08-20T10:11:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61271/

nodejs-github-bot · 2024-08-20T14:00:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61283/

mcollina

lgtm

cjihrig · 2024-08-20T22:05:55Z

I can confirm this fixes the issue I was seeing. Thank you for the quick fix.

nodejs-github-bot · 2024-08-21T06:36:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61310/

nodejs-github-bot · 2024-08-21T07:23:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61311/

lib/internal/modules/esm/get_format.js

nodejs-github-bot · 2024-08-22T08:48:34Z

Landed in e35902c

RafaelGSS · 2024-08-25T21:20:33Z

This commit didn't land cleanly on v22.x-staging. Can you create a manual backport?

PR-URL: nodejs#54461 Fixes: nodejs#54457 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>

PR-URL: #54461 Backport-PR-URL: #54566 Fixes: #54457 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>

nodejs/node#54461

* chore: bump node in DEPS to v22.11.0 * src: move evp stuff to ncrypto nodejs/node#54911 * crypto: add Date fields for validTo and validFrom nodejs/node#54159 * module: fix discrepancy between .ts and .js nodejs/node#54461 * esm: do not interpret "main" as a URL nodejs/node#55003 * src: modernize likely/unlikely hints nodejs/node#55155 * chore: update patch indices * crypto: add validFromDate and validToDate fields to X509Certificate nodejs/node#54159 * chore: fixup perfetto patch * fix: clang warning in simdjson * src: add receiver to fast api callback methods nodejs/node#54408 * chore: fixup revert patch * fixup! esm: do not interpret "main" as a URL * fixup! crypto: add Date fields for validTo and validFrom * fix: move ArrayBuffer test patch * src: fixup Error.stackTraceLimit during snapshot building nodejs/node#55121 * fix: bad rebase * chore: fixup amaro * chore: address feedback from review * src: revert filesystem::path changes nodejs/node#55015 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs/node#54461

* chore: bump node in DEPS to v22.13.0 * chore: bump node in DEPS to v22.13.1 * src: move evp stuff to ncrypto nodejs/node#54911 * crypto: add Date fields for validTo and validFrom nodejs/node#54159 * module: fix discrepancy between .ts and .js nodejs/node#54461 * esm: do not interpret "main" as a URL nodejs/node#55003 * src: modernize likely/unlikely hints nodejs/node#55155 * chore: update patch indices * crypto: add validFromDate and validToDate fields to X509Certificate nodejs/node#54159 * chore: fixup perfetto patch * fix: clang warning in simdjson * src: add receiver to fast api callback methods nodejs/node#54408 * chore: fixup revert patch * fixup! esm: do not interpret "main" as a URL * fixup! crypto: add Date fields for validTo and validFrom * fix: move ArrayBuffer test patch * src: fixup Error.stackTraceLimit during snapshot building nodejs/node#55121 * fix: bad rebase * chore: fixup amaro * chore: address feedback from review * src: revert filesystem::path changes nodejs/node#55015 * chore: fixup GN build file * nodejs/node#55529 * nodejs/node#55798 * nodejs/node#55530 * module: simplify --inspect-brk handling nodejs/node#55679 * src: fix outdated js2c.cc references nodejs/node#56133 * crypto: include openssl/rand.h explicitly nodejs/node#55425 * build: use variable for crypto dep path nodejs/node#55928 * crypto: fix RSA_PKCS1_PADDING error message nodejs/node#55629 * build: use variable for simdutf path nodejs/node#56196 * test,crypto: make crypto tests work with BoringSSL nodejs/node#55491 * fix: suppress clang -Wdeprecated-declarations in libuv libuv/libuv#4486 * deps: update libuv to 1.49.1 nodejs/node#55114 * test: make test-node-output-v8-warning more flexible nodejs/node#55401 * [v22.x] Revert "v8: enable maglev on supported architectures" nodejs/node#54384 * fix: potential WIN32_LEAN_AND_MEAN redefinition c-ares/c-ares#869 * deps: update nghttp2 to 1.64.0 nodejs/node#55559 * src: provide workaround for container-overflow nodejs/node#55591 * build: use variable for simdutf path nodejs/node#56196 * chore: fixup patch indices * fixup! module: simplify --inspect-brk handling * lib: fix fs.readdir recursive async nodejs/node#56041 * lib: avoid excluding symlinks in recursive fs.readdir with filetypes nodejs/node#55714 This doesn't currently play well with ASAR - this should be fixed in a follow up * test: disable CJS permission test for config.main This has diverged as a result of our revert of src,lb: reducing C++ calls of esm legacy main resolve * fixup! lib: fix fs.readdir recursive async * deps: update libuv to 1.49.1 nodejs/node#55114 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

module: fix discrepancy between .ts and .js

af4f6c9

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. labels Aug 20, 2024

ShogunPanda approved these changes Aug 20, 2024

View reviewed changes

aduh95 reviewed Aug 20, 2024

View reviewed changes

lib/internal/modules/esm/get_format.js Show resolved Hide resolved

marco-ippolito mentioned this pull request Aug 20, 2024

feat: add transform loader nodejs/amaro#70

Merged

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2024

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2024

mcollina approved these changes Aug 20, 2024

View reviewed changes

legendecas approved these changes Aug 21, 2024

View reviewed changes

lib/internal/modules/esm/get_format.js Show resolved Hide resolved

marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. strip-types Issues or PRs related to strip-types support labels Aug 21, 2024

himself65 approved these changes Aug 21, 2024

View reviewed changes

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 22, 2024

nodejs-github-bot merged commit e35902c into nodejs:main Aug 22, 2024
74 checks passed

RafaelGSS added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label Aug 25, 2024

marco-ippolito mentioned this pull request Aug 26, 2024

[v22.x] Backport: "module: fix discrepancy between .ts and .js" #54566

Closed

avivkeller added backport-open-v22.x Indicate that the PR has an open backport and removed backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. labels Aug 26, 2024

targos added backported-to-v22.x PRs backported to the v22.x-staging branch. and removed backport-open-v22.x Indicate that the PR has an open backport labels Oct 5, 2024

aduh95 mentioned this pull request Oct 9, 2024

V22.10.0 proposal #55343

Merged

marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Nov 16, 2024

codebytere added a commit to electron/electron that referenced this pull request Nov 20, 2024

module: fix discrepancy between .ts and .js

67c3cd9

nodejs/node#54461

codebytere added a commit to electron/electron that referenced this pull request Nov 20, 2024

module: fix discrepancy between .ts and .js

2f39fa9

nodejs/node#54461

codebytere added a commit to electron/electron that referenced this pull request Nov 21, 2024

module: fix discrepancy between .ts and .js

31257e5

nodejs/node#54461

codebytere added a commit to electron/electron that referenced this pull request Dec 3, 2024

module: fix discrepancy between .ts and .js

02bfa10

nodejs/node#54461

codebytere added a commit to electron/electron that referenced this pull request Dec 4, 2024

module: fix discrepancy between .ts and .js

c80c30e

nodejs/node#54461

codebytere added a commit to electron/electron that referenced this pull request Jan 22, 2025

module: fix discrepancy between .ts and .js

3212e86

nodejs/node#54461

codebytere added a commit to electron/electron that referenced this pull request Feb 3, 2025

module: fix discrepancy between .ts and .js

e1180d0

nodejs/node#54461

codebytere added a commit to electron/electron that referenced this pull request Feb 10, 2025

module: fix discrepancy between .ts and .js

0a36d19

nodejs/node#54461

codebytere added a commit to electron/electron that referenced this pull request Feb 10, 2025

module: fix discrepancy between .ts and .js

22895a5

nodejs/node#54461

codebytere added a commit to electron/electron that referenced this pull request Feb 14, 2025

module: fix discrepancy between .ts and .js

e329434

nodejs/node#54461

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

module: fix discrepancy between .ts and .js #54461

module: fix discrepancy between .ts and .js #54461

marco-ippolito commented Aug 20, 2024

nodejs-github-bot commented Aug 20, 2024

ShogunPanda left a comment

codecov bot commented Aug 20, 2024 •

edited

Loading

nodejs-github-bot commented Aug 20, 2024

nodejs-github-bot commented Aug 20, 2024

mcollina left a comment

cjihrig commented Aug 20, 2024

nodejs-github-bot commented Aug 21, 2024

nodejs-github-bot commented Aug 21, 2024

nodejs-github-bot commented Aug 22, 2024

RafaelGSS commented Aug 25, 2024

module: fix discrepancy between .ts and .js #54461

module: fix discrepancy between .ts and .js #54461

Conversation

marco-ippolito commented Aug 20, 2024

nodejs-github-bot commented Aug 20, 2024

ShogunPanda left a comment

Choose a reason for hiding this comment

codecov bot commented Aug 20, 2024 • edited Loading

Codecov Report

nodejs-github-bot commented Aug 20, 2024

nodejs-github-bot commented Aug 20, 2024

mcollina left a comment

Choose a reason for hiding this comment

cjihrig commented Aug 20, 2024

nodejs-github-bot commented Aug 21, 2024

nodejs-github-bot commented Aug 21, 2024

nodejs-github-bot commented Aug 22, 2024

RafaelGSS commented Aug 25, 2024

codecov bot commented Aug 20, 2024 •

edited

Loading