lib: avoid excluding symlinks in recursive fs.readdir with filetypes #55714

juanarbol · 2024-11-04T07:35:09Z

Fixes: #52663

nodejs-github-bot · 2024-11-04T07:38:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63415/

codecov · 2024-11-04T08:52:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.42%. Comparing base (6af5c4e) to head (a8a6aa0).
Report is 827 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #55714      +/-   ##
==========================================
+ Coverage   88.41%   88.42%   +0.01%     
==========================================
  Files         654      654              
  Lines      187757   187863     +106     
  Branches    36129    36148      +19     
==========================================
+ Hits       166003   166119     +116     
+ Misses      14997    14982      -15     
- Partials     6757     6762       +5

Files with missing lines	Coverage Δ
lib/fs.js	`98.26% <100.00%> (+0.11%)`	⬆️

... and 54 files with indirect coverage changes

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Ethan-Arrowood · 2024-11-06T12:19:16Z

Please add a test; otherwise lgtm

juanarbol · 2024-11-07T17:49:41Z

Please add a test; otherwise lgtm

Will do

juanarbol · 2024-11-14T01:38:31Z

@Ethan-Arrowood there we go!

test/parallel/test-fs-readdir-types-symlinks.js

Fixes: nodejs#52663 Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>

juanarbol · 2024-11-17T18:57:26Z

@Ethan-Arrowood you were right, I've addressed your suggestions and tested the thing w/ main branch build.

nodejs-github-bot · 2024-11-17T18:58:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63608/

juanarbol · 2024-11-21T17:39:19Z

ping @Ethan-Arrowood

Ethan-Arrowood

lgtm!

nodejs-github-bot · 2024-11-21T21:12:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63651/

nodejs-github-bot · 2024-11-22T21:01:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63656/

nodejs-github-bot · 2024-11-24T11:53:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63683/

nodejs-github-bot · 2024-11-24T23:31:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63690/ 💛

Fixes: #52663 Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #55714 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs/node#55714 This doesn't currently play well with ASAR - this should be fixed in a follow up

* chore: bump node in DEPS to v22.13.1 * chore: fixup GN build file * nodejs/node#55529 * nodejs/node#55798 * nodejs/node#55530 * module: simplify --inspect-brk handling nodejs/node#55679 * src: fix outdated js2c.cc references nodejs/node#56133 * crypto: include openssl/rand.h explicitly nodejs/node#55425 * build: use variable for crypto dep path nodejs/node#55928 * crypto: fix RSA_PKCS1_PADDING error message nodejs/node#55629 * build: use variable for simdutf path nodejs/node#56196 * test,crypto: make crypto tests work with BoringSSL nodejs/node#55491 * fix: suppress clang -Wdeprecated-declarations in libuv libuv/libuv#4486 * deps: update libuv to 1.49.1 nodejs/node#55114 * test: make test-node-output-v8-warning more flexible nodejs/node#55401 * [v22.x] Revert "v8: enable maglev on supported architectures" nodejs/node#54384 * fix: potential WIN32_LEAN_AND_MEAN redefinition c-ares/c-ares#869 * deps: update nghttp2 to 1.64.0 nodejs/node#55559 * src: provide workaround for container-overflow nodejs/node#55591 * build: use variable for simdutf path nodejs/node#56196 * chore: fixup patch indices * fixup! module: simplify --inspect-brk handling * lib: fix fs.readdir recursive async nodejs/node#56041 * lib: avoid excluding symlinks in recursive fs.readdir with filetypes nodejs/node#55714 This doesn't currently play well with ASAR - this should be fixed in a follow up * test: disable CJS permission test for config.main This has diverged as a result of our revert of src,lb: reducing C++ calls of esm legacy main resolve * fixup! lib: fix fs.readdir recursive async * deps: update libuv to 1.49.1 nodejs/node#55114 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs/node#55714 This doesn't currently play well with ASAR - this should be fixed in a follow up

* chore: bump node in DEPS to v22.13.0 * chore: bump node in DEPS to v22.13.1 * src: move evp stuff to ncrypto nodejs/node#54911 * crypto: add Date fields for validTo and validFrom nodejs/node#54159 * module: fix discrepancy between .ts and .js nodejs/node#54461 * esm: do not interpret "main" as a URL nodejs/node#55003 * src: modernize likely/unlikely hints nodejs/node#55155 * chore: update patch indices * crypto: add validFromDate and validToDate fields to X509Certificate nodejs/node#54159 * chore: fixup perfetto patch * fix: clang warning in simdjson * src: add receiver to fast api callback methods nodejs/node#54408 * chore: fixup revert patch * fixup! esm: do not interpret "main" as a URL * fixup! crypto: add Date fields for validTo and validFrom * fix: move ArrayBuffer test patch * src: fixup Error.stackTraceLimit during snapshot building nodejs/node#55121 * fix: bad rebase * chore: fixup amaro * chore: address feedback from review * src: revert filesystem::path changes nodejs/node#55015 * chore: fixup GN build file * nodejs/node#55529 * nodejs/node#55798 * nodejs/node#55530 * module: simplify --inspect-brk handling nodejs/node#55679 * src: fix outdated js2c.cc references nodejs/node#56133 * crypto: include openssl/rand.h explicitly nodejs/node#55425 * build: use variable for crypto dep path nodejs/node#55928 * crypto: fix RSA_PKCS1_PADDING error message nodejs/node#55629 * build: use variable for simdutf path nodejs/node#56196 * test,crypto: make crypto tests work with BoringSSL nodejs/node#55491 * fix: suppress clang -Wdeprecated-declarations in libuv libuv/libuv#4486 * deps: update libuv to 1.49.1 nodejs/node#55114 * test: make test-node-output-v8-warning more flexible nodejs/node#55401 * [v22.x] Revert "v8: enable maglev on supported architectures" nodejs/node#54384 * fix: potential WIN32_LEAN_AND_MEAN redefinition c-ares/c-ares#869 * deps: update nghttp2 to 1.64.0 nodejs/node#55559 * src: provide workaround for container-overflow nodejs/node#55591 * build: use variable for simdutf path nodejs/node#56196 * chore: fixup patch indices * fixup! module: simplify --inspect-brk handling * lib: fix fs.readdir recursive async nodejs/node#56041 * lib: avoid excluding symlinks in recursive fs.readdir with filetypes nodejs/node#55714 This doesn't currently play well with ASAR - this should be fixed in a follow up * test: disable CJS permission test for config.main This has diverged as a result of our revert of src,lb: reducing C++ calls of esm legacy main resolve * fixup! lib: fix fs.readdir recursive async * deps: update libuv to 1.49.1 nodejs/node#55114 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Nov 4, 2024

juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2024

Ethan-Arrowood self-assigned this Nov 6, 2024

juanarbol force-pushed the juan/fs-readdir branch 2 times, most recently from 0330a1d to 10a71b9 Compare November 14, 2024 01:36

Ethan-Arrowood requested changes Nov 14, 2024

View reviewed changes

test/parallel/test-fs-readdir-types-symlinks.js Outdated Show resolved Hide resolved

test/parallel/test-fs-readdir-types-symlinks.js Show resolved Hide resolved

lib: avoid excluding symlinks in recursive fs.readdir with filetypes

a8a6aa0

Fixes: nodejs#52663 Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>

juanarbol force-pushed the juan/fs-readdir branch from 10a71b9 to a8a6aa0 Compare November 17, 2024 18:52

Ethan-Arrowood approved these changes Nov 21, 2024

View reviewed changes

Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 21, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 21, 2024

jasnell approved these changes Nov 23, 2024

View reviewed changes

juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2024

juanarbol added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 25, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 25, 2024

nodejs-github-bot mentioned this pull request Dec 3, 2024

2024-12-10, Version 23.4.0 (Current), @targos #56119

Merged

This was referenced Dec 6, 2024

2024-12-11, Version 23.4.0 (Current), @aduh95 aduh95/node#31

Closed

2024-12-12, Version 23.4.0 (Current) aduh95/node#32

Closed

2024-12-12, Version 23.4.0 (Current) aduh95/node#33

Closed

ruyadorno mentioned this pull request Dec 20, 2024

2025-01-07, Version 22.13.0 'Jod' (LTS) #56329

Merged

codebytere added a commit to electron/electron that referenced this pull request Jan 28, 2025

lib: avoid excluding symlinks in recursive fs.readdir with filetypes

b7e4625

nodejs/node#55714 This doesn't currently play well with ASAR - this should be fixed in a follow up

codebytere added a commit to electron/electron that referenced this pull request Jan 28, 2025

lib: avoid excluding symlinks in recursive fs.readdir with filetypes

cc28b9d

nodejs/node#55714 This doesn't currently play well with ASAR - this should be fixed in a follow up

codebytere added a commit to electron/electron that referenced this pull request Jan 28, 2025

lib: avoid excluding symlinks in recursive fs.readdir with filetypes

81b2483

nodejs/node#55714 This doesn't currently play well with ASAR - this should be fixed in a follow up

codebytere added a commit to electron/electron that referenced this pull request Feb 3, 2025

lib: avoid excluding symlinks in recursive fs.readdir with filetypes

068a388

nodejs/node#55714 This doesn't currently play well with ASAR - this should be fixed in a follow up

codebytere added a commit to electron/electron that referenced this pull request Feb 10, 2025

lib: avoid excluding symlinks in recursive fs.readdir with filetypes

3090bd0

nodejs/node#55714 This doesn't currently play well with ASAR - this should be fixed in a follow up

codebytere added a commit to electron/electron that referenced this pull request Feb 10, 2025

lib: avoid excluding symlinks in recursive fs.readdir with filetypes

bf91cd7

nodejs/node#55714 This doesn't currently play well with ASAR - this should be fixed in a follow up

codebytere added a commit to electron/electron that referenced this pull request Feb 14, 2025

lib: avoid excluding symlinks in recursive fs.readdir with filetypes

3835844

nodejs/node#55714 This doesn't currently play well with ASAR - this should be fixed in a follow up

marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Mar 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib: avoid excluding symlinks in recursive fs.readdir with filetypes #55714

lib: avoid excluding symlinks in recursive fs.readdir with filetypes #55714

juanarbol commented Nov 4, 2024

nodejs-github-bot commented Nov 4, 2024

codecov bot commented Nov 4, 2024 •

edited

Loading

Ethan-Arrowood commented Nov 6, 2024

juanarbol commented Nov 7, 2024

juanarbol commented Nov 14, 2024

juanarbol commented Nov 17, 2024

nodejs-github-bot commented Nov 17, 2024

juanarbol commented Nov 21, 2024

Ethan-Arrowood left a comment

nodejs-github-bot commented Nov 21, 2024

nodejs-github-bot commented Nov 22, 2024

nodejs-github-bot commented Nov 24, 2024

nodejs-github-bot commented Nov 24, 2024 •

edited by jazelly

Loading

lib: avoid excluding symlinks in recursive fs.readdir with filetypes #55714

lib: avoid excluding symlinks in recursive fs.readdir with filetypes #55714

Conversation

juanarbol commented Nov 4, 2024

nodejs-github-bot commented Nov 4, 2024

codecov bot commented Nov 4, 2024 • edited Loading

Codecov Report

Ethan-Arrowood commented Nov 6, 2024

juanarbol commented Nov 7, 2024

juanarbol commented Nov 14, 2024

juanarbol commented Nov 17, 2024

nodejs-github-bot commented Nov 17, 2024

juanarbol commented Nov 21, 2024

Ethan-Arrowood left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Nov 21, 2024

nodejs-github-bot commented Nov 22, 2024

nodejs-github-bot commented Nov 24, 2024

nodejs-github-bot commented Nov 24, 2024 • edited by jazelly Loading

codecov bot commented Nov 4, 2024 •

edited

Loading

nodejs-github-bot commented Nov 24, 2024 •

edited by jazelly

Loading