src: fix ARRAY_SIZE() logic error #5969

bnoordhuis · 2016-03-31T11:04:24Z

Pull Request check-list

Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
this change (including linting)?
Is the commit message formatted according to [CONTRIBUTING.md][0]?
If this change fixes a bug (or a performance problem), is a regression
test (or a benchmark) included?
Is a documentation update included (if this change modifies
existing APIs, or introduces new ones)?

Affected core subsystem(s)

src

Description of change

src: fix ARRAY_SIZE() logic error
src: replace ARRAY_SIZE with typesafe arraysize
src: use size_t for http parser array size fields

CI: https://ci.nodejs.org/job/node-test-pull-request/2106/

bnoordhuis · 2016-03-31T11:05:18Z

/cc @Fishrock123

r-52 · 2016-03-31T12:10:21Z

src/node_lttng.cc

@@ -248,7 +248,7 @@ void InitLTTNG(Environment* env, Local<Object> target) {
 #undef NODE_PROBE
  };

-  for (unsigned int i = 0; i < ARRAY_SIZE(tab); i++) {
+  for (unsigned int i = 0; i < arraysize(tab); i++) {


Small question: Does it make sense to switch from unsigned to size_t, too?

I thought I caught them all (I updated them in other files) but I must've overlooked this file. I'll fix that before landing.

cjihrig · 2016-03-31T13:09:07Z

LGTM

Fishrock123 · 2016-03-31T14:41:14Z

@bnoordhuis What issue did this cause?

seems fine if it works, I guess? I really don't understand how it works lol

jasnell · 2016-04-01T16:40:55Z

Build failed on Windows: https://ci.nodejs.org/job/node-compile-windows/1897/label=win-vcbt2015/console

bnoordhuis · 2016-04-01T16:50:32Z

Let's see if VS takes the hint when it's marked constexpr: https://ci.nodejs.org/job/node-test-pull-request/2122/

bnoordhuis · 2016-04-01T16:53:32Z

What issue did this cause? seems fine if it works, I guess?

No issue but that's because it works by accident (because sizeof(Local<Value>) == sizeof(void*).)

bnoordhuis · 2016-04-01T17:54:03Z

Once more with VS 2013 workaround... https://ci.nodejs.org/job/node-test-pull-request/2124/

bnoordhuis · 2016-04-01T19:11:47Z

CI is green except for a post-test service outage on one of the ARM buildbots. I'll land this tomorrow.

jasnell · 2016-04-01T20:12:02Z

LGTM

Bug introduced in commit 21d66d6 ("lib: remove bootstrap global context indirection"). PR-URL: nodejs#5969 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

To prevent `ARRAY_SIZE(&arg)` (i.e., taking the array size of a pointer) from happening again. PR-URL: nodejs#5969 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Make the `num_values_` and `num_fields_` unsigned and remove an erroneous comment. PR-URL: nodejs#5969 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins · 2016-04-05T18:04:20Z

@bnoordhuis these changes are not landing cleanly on v5.x. Would you be able to backport or handle landing it?

To prevent `ARRAY_SIZE(&arg)` (i.e., taking the array size of a pointer) from happening again. PR-URL: nodejs#5969 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Make the `num_values_` and `num_fields_` unsigned and remove an erroneous comment. PR-URL: nodejs#5969 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

bnoordhuis · 2016-04-14T17:39:59Z

Sorry for the delay. Back-port: #6199

MylesBorins · 2016-04-14T21:57:42Z

@bnoordhuis it looks like this isn't landing cleanly on v4 (the v5 back port isn't either). We'll need to do a manual backport when the time comes)

To prevent `ARRAY_SIZE(&arg)` (i.e., taking the array size of a pointer) from happening again. PR-URL: #5969 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Make the `num_values_` and `num_fields_` unsigned and remove an erroneous comment. PR-URL: #5969 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

bnoordhuis · 2016-04-15T16:26:51Z

@thealphanerd #6221