Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

src: replace ARRAY_SIZE with typesafe arraysize #6199

Closed
wants to merge 2 commits into from
Closed

src: replace ARRAY_SIZE with typesafe arraysize #6199

wants to merge 2 commits into from

Conversation

bnoordhuis
Copy link
Member

@bnoordhuis
src: replace ARRAY_SIZE with typesafe arraysize
83c4173 
To prevent `ARRAY_SIZE(&arg)` (i.e., taking the array size of a pointer)
from happening again.

PR-URL: nodejs#5969
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@bnoordhuis
src: use size_t for http parser array size fields
1e2b7e4 
Make the `num_values_` and `num_fields_` unsigned and remove an
erroneous comment.

PR-URL: nodejs#5969
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@bnoordhuis bnoordhuis mentioned this pull request Apr 14, 2016
Merged
4 tasks
@mscdex mscdex added the lib / src Issues and PRs related to general changes in the lib or src directory. label Apr 14, 2016
@bnoordhuis
Copy link
Member Author

CI is green.

@MylesBorins
Copy link
Contributor

landed in 60a73a2...20bb92f

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bnoordhuis @MylesBorins @mscdex