-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add shasums to download page #742
Comments
"for current releases" doesn't make much sense, so probably something like "Signed SHASUMS for vx.y.z release files" and link to the .txt.asc file. Would you mind sending a pull request to this repo with a change like this along with a screenshot so it can be reviewed? |
@rvagg Yeah, sorry, I didn't look into the wording that much – was more about the UX to have the functionality straight there. I think
I will give it a bash tonight. Cheers. |
Can we use "Signed SHASUMS for release files" without specifying the version? |
The link points to the SHASUMS256.txt.asc file of the Node.js version the page refers to. Closes: #742
I think it's fine to omit the version number, as you said, download pages always refer to a Node.js version anyway. |
Oh. Damn … I forgot to push my code. I had the change locally since May 16th and forgot to create the PR for it since then … :( |
oops sorry @raphaelokon I should have pinged you before creating a new pr. If yours is better I'm fine with closing mine. |
@raphaelokon competing PR is always encouraged :) |
Closed by #819. |
I think it would be really helpful to have a direct link to SHASUMS (eg. SHASUMS256.txt right on the nodejs.org download page. This would save some users searching for it and extra clicks on All download options to find it there.
A naive implementation may look like …
The text was updated successfully, but these errors were encountered: