Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add shasums to download page #742

Closed
raphaelokon opened this issue May 14, 2016 · 9 comments
Closed

Add shasums to download page #742

raphaelokon opened this issue May 14, 2016 · 9 comments
Labels

Comments

@raphaelokon
Copy link
Contributor

raphaelokon commented May 14, 2016

I think it would be really helpful to have a direct link to SHASUMS (eg. SHASUMS256.txt right on the nodejs.org download page. This would save some users searching for it and extra clicks on All download options to find it there.

A naive implementation may look like …

shasums

@rvagg
Copy link
Member

rvagg commented May 15, 2016

"for current releases" doesn't make much sense, so probably something like "Signed SHASUMS for vx.y.z release files" and link to the .txt.asc file.

Would you mind sending a pull request to this repo with a change like this along with a screenshot so it can be reviewed?

@raphaelokon
Copy link
Contributor Author

@rvagg Yeah, sorry, I didn't look into the wording that much – was more about the UX to have the functionality straight there. I think Signed SHASUMS for vx.y.z release files makes much more sense.

Would you mind sending a pull request to this repo with a change like this along with a screenshot so it can be reviewed?

I will give it a bash tonight. Cheers.

@lpinca
Copy link
Member

lpinca commented Jul 7, 2016

Can we use "Signed SHASUMS for release files" without specifying the version?
This will simplify the translation as the version position in the sentence depends on the language. Otherwise we have to split the sentence in 3 parts (prefix, version, suffix).
An alternative is to put the version always at the end using something like "Signed SHASUMS for release files (vx.y.z)" but I think it can be omitted as the page already refers to a specifc version.

lpinca added a commit that referenced this issue Jul 7, 2016
The link points to the SHASUMS256.txt.asc file of the Node.js
version the page refers to.

Closes: #742
@fhemberger
Copy link
Contributor

I think it's fine to omit the version number, as you said, download pages always refer to a Node.js version anyway.

@raphaelokon
Copy link
Contributor Author

Oh. Damn … I forgot to push my code. I had the change locally since May 16th and forgot to create the PR for it since then … :(

@lpinca
Copy link
Member

lpinca commented Jul 7, 2016

oops sorry @raphaelokon I should have pinged you before creating a new pr. If yours is better I'm fine with closing mine.

@stevemao
Copy link
Contributor

stevemao commented Jul 7, 2016

@raphaelokon competing PR is always encouraged :)

@raphaelokon
Copy link
Contributor Author

raphaelokon commented Jul 8, 2016

@lpinca Hey no worries :-) I just forgot to push mine. The only difference between yours and mine:
I included the shasum text in the download section of locale/en/site.json

@stevemao True :-)

@fhemberger
Copy link
Contributor

Closed by #819.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants