Adding shasum links for release files to download page (#742) #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,6 +71,9 @@ | |||
| "package-manager": { | |||
| "link": "download/package-manager", | |||
| "text": "Installing Node.js via package manager" | |||
| }, | |||
| "shasums":{ | |||
| "text": "Signed SHASUMS for release files" | |||
There was a problem hiding this comment.
In this case I would also add the "link" property for consistency and use {{site.download.shasums.link}} in the href attribute.
|
I was just about to ask this … Good call @lpinca. Will do that. |
|
Done. Added the |
|
LGTM! |
|
Great, thank you! |
|
Thank you! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opened #742 to improve the usability regarding retrieving SHASUM for the releases (something I do quite frequently). As discussed there this adds the link to the SHASUMs on the /download page. There is already another PR. The main difference is: I included the shamus text in the
downloadsection oflocale/en/site.json(and this one is from 20 May but I forgot to push it :-) )