Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix: broken pipeline permissions #913

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Fix: broken pipeline permissions #913

merged 2 commits into from
Mar 17, 2023

Conversation

UlisesGascon
Copy link
Member

Main changes

Solves the permission definition in the pipelines as the syntax is currently wrong. See

Side note: these workflow might not work as they need to write in a protected brach, related to #908

RafaelGSS
RafaelGSS reviewed Mar 17, 2023
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I think we can just drop these workflows

RafaelGSS
RafaelGSS approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do it in another PR

@RafaelGSS RafaelGSS merged commit 9682b28 into nodejs:main Mar 17, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UlisesGascon @RafaelGSS