Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Workflows failing due repo config #908

Closed
UlisesGascon opened this issue Mar 16, 2023 · 5 comments
Closed

Workflows failing due repo config #908

UlisesGascon opened this issue Mar 16, 2023 · 5 comments
Assignees

Comments

@UlisesGascon
Copy link
Member

The OpenSSF Scoring workflow is failing has we had changed the rules in the repo to make main a protected branch:

Pushing changes to database and report
/usr/bin/git push origin --force --no-verify --repo ***github.com/undefined.git
remote: error: GH006: Protected branch update failed for refs/heads/main.        
remote: error: At least 1 approving review is required by reviewers with write access.        
To https://github.com/nodejs/security-wg
 ! [remote rejected] main -> main (protected branch hook declined)

You can check the settings here. I believe that we might make it work by disable the Do not allow bypassing the above settings option. But this might impact the scorecard for nodejs/security-wg

@RafaelGSS
Copy link
Member

Sending a PR should be the best choice

@UlisesGascon UlisesGascon changed the title OSSF Scorecard Monitor failing due repo config Workflows failing due repo config Mar 18, 2023
@UlisesGascon
Copy link
Member Author

Also the update core index.js is failing:

Captura de pantalla 2023-03-18 a las 15 55 08

I assume the same will happen with Update Npm Index as it will require write permissions.

@UlisesGascon
Copy link
Member Author

Maybe the best option for now is disable the protection to a level that the workflows can commit to main?

@UlisesGascon
Copy link
Member Author

UlisesGascon commented Mar 31, 2023

As agreed on last meeting, the approach will be to migrate the Github actions with writing permissions to send a Pr with the changes:

In the meantime I can keep my fork running the actions and I can PR the changes until we make the refactor as my fork does not includes the branch protections. This won't impact negatively in the scorecard as it is a Pr that we will review 😉

UlisesGascon added a commit to UlisesGascon/security-wg that referenced this issue Apr 14, 2023
UlisesGascon added a commit to UlisesGascon/security-wg that referenced this issue Apr 14, 2023
RafaelGSS pushed a commit that referenced this issue Apr 15, 2023
UlisesGascon added a commit that referenced this issue May 23, 2023
#997)

* feat: Added PR generation capabilities to reporting scorecard pipelinere

Related: #908

* chore: changed dependency
UlisesGascon added a commit that referenced this issue May 23, 2023
* feat: Added PR generation capabilities to core index pipeline

Related: #908

* chore: changed dependency
UlisesGascon added a commit that referenced this issue May 23, 2023
* feat: Added PR generation capabilities to npm index pipeline

Related: #908

* chore: changed dependency
@UlisesGascon
Copy link
Member Author

I close the issues as the workflows are working fine now 🎉

@UlisesGascon UlisesGascon self-assigned this May 25, 2023
patrickm68 added a commit to patrickm68/security-wg-process that referenced this issue Sep 14, 2023
patrickm68 added a commit to patrickm68/security-wg-process that referenced this issue Sep 14, 2023
…e (#997)

* feat: Added PR generation capabilities to reporting scorecard pipelinere

Related: nodejs/security-wg#908

* chore: changed dependency
mattstern31 added a commit to mattstern31/security-wg-process that referenced this issue Nov 11, 2023
mattstern31 added a commit to mattstern31/security-wg-process that referenced this issue Nov 11, 2023
…e (#997)

* feat: Added PR generation capabilities to reporting scorecard pipelinere

Related: nodejs/security-wg#908

* chore: changed dependency
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants