Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Added PR generation capabilities to npm index pipeline #999

Merged
merged 2 commits into from
May 23, 2023

Conversation

UlisesGascon
Copy link
Member

Main changes

  • The npm index pipeline can be triggered manually also
  • The npm index pipeline now generates a PR with the changes with some predefined things like tagging or assignation

PR Preview (from my fork)

Captura de pantalla 2023-05-23 a las 9 29 30

Related

Related: #908

@marco-ippolito
Copy link
Member

marco-ippolito commented May 23, 2023

should we avoid creation of the pr when its triggered manually? also I think it might be good to use the option update-pull-request-title-and-body: true so that it will update the same pr on multiple run

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just saw the other PR.

@UlisesGascon
Copy link
Member Author

should we avoid creation of the pr when its triggered manually?

I believe that our current branch protection rules won't allow us to commit directly to the main branch from a PR

also I think it might be good to use the option update-pull-request-title-and-body: true so that it will update the same pr on multiple run

I will do it in a separate PR as I already merged #998

@UlisesGascon UlisesGascon merged commit 04e05c4 into main May 23, 2023
@UlisesGascon UlisesGascon deleted the fix/npm-pipeline branch May 23, 2023 16:43
UlisesGascon added a commit that referenced this pull request May 24, 2023
UlisesGascon added a commit that referenced this pull request May 24, 2023
UlisesGascon added a commit that referenced this pull request May 24, 2023
@UlisesGascon UlisesGascon mentioned this pull request May 24, 2023
UlisesGascon added a commit that referenced this pull request May 24, 2023
* chore: extended pipeline capabilities to update PRs

Related to #999 (comment)

* chore: extended pipeline capabilities to update PRs

Related to #999 (comment)

* chore: extended pipeline capabilities to update PRs

Related to #999 (comment)
patrickm68 added a commit to patrickm68/security-wg-process that referenced this pull request Sep 14, 2023
* chore: extended pipeline capabilities to update PRs

Related to nodejs/security-wg#999 (comment)

* chore: extended pipeline capabilities to update PRs

Related to nodejs/security-wg#999 (comment)

* chore: extended pipeline capabilities to update PRs

Related to nodejs/security-wg#999 (comment)
mattstern31 added a commit to mattstern31/security-wg-process that referenced this pull request Nov 11, 2023
* chore: extended pipeline capabilities to update PRs

Related to nodejs/security-wg#999 (comment)

* chore: extended pipeline capabilities to update PRs

Related to nodejs/security-wg#999 (comment)

* chore: extended pipeline capabilities to update PRs

Related to nodejs/security-wg#999 (comment)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants